| Message ID | 20231117-b4-feature_hdma_mainline-v6-2-ebf7aa0e40d7@bootlin.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp419453vqn;
Fri, 17 Nov 2023 02:04:20 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IHy1KCaGKSDNs/gtXykaUf1jK3Lyn6UDYAwq78jthBicNpHX3Gqjva+DIAdlpitGEjOxVQU
X-Received: by 2002:a17:902:e88e:b0:1cc:5aef:f2c3 with SMTP id
w14-20020a170902e88e00b001cc5aeff2c3mr6564290plg.22.1700215460050;
Fri, 17 Nov 2023 02:04:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1700215460; cv=none;
d=google.com; s=arc-20160816;
b=bDec+vptVgqEliST1n4BgK/B0QX/ywQySyEst7UOop2h5+nnizt5OgGHwdX3SeGfrI
IJCC5RpYgUGzwkWVE7YW9zFka3MGyLvtWaAp4ObzyQ0KHFgQFPaN+dc4CXNSw+RMbae1
faemJed/Q4XYOfekAEEO0GkHuB4kSK2L+3l9W2skqZgYmXbcUkO4hwOUYMPUTZT0C8LM
SxgwFXxPaRB7rYLcoTY/O7bwFQqSilldOy1P+c1chlIDIsHkbMl6VTtbryA3DpTTYGTS
9GOzyzsVmvLrNQBdaEeZgHK3XAH5JFbSEPaWmNqEeigHvhMlsca5ziC9ycotxK3fumWC
M09Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:cc:to:in-reply-to:references:message-id
:content-transfer-encoding:mime-version:subject:date:from
:dkim-signature;
bh=FAldIdFOcM6TSQgoc+utZ58ITzn88qsDQysRSDWf7aE=;
fh=Fko32OqwGgI5WpcqYpp5KigXgtelsKMiigtnZERCGL8=;
b=VOHsirKiYugIoaLGW0LJg5VaveHm016/3ge5fBFFbP6gWaZgqZecsi0/NNrHEn/DZ8
X/m+jSIPw3sCFpTduavH2TbDmkaA2AOyKFk5jT7m+mt/8UDYfomglp1aNkGsL6GWUCJs
73OHygL6FdNZi8uqsKHV4DHVdh4Y6bjK86Rkc5FmRIs+2bWzwq27B162RWJV0vZRtM4b
m7ns2bRwhnSDnewss9WF5rYFQAGobgiAs8f5Twt9G5or1rQVuINE49g5QIw2vBJuidRk
p2eviqIUS1YAiItRpcHiC9mgKI3dWov3oM5Ks3cdha5I6KMLHijQ8cas6CEnv+L10zfI
aflQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=CWRbqMYk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7])
by mx.google.com with ESMTPS id
y8-20020a634b08000000b005c17124d9b9si1540978pga.74.2023.11.17.02.04.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Nov 2023 02:04:20 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
client-ip=2620:137:e000::3:7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=CWRbqMYk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:7 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by snail.vger.email (Postfix) with ESMTP id 10B1380BC502;
Fri, 17 Nov 2023 02:04:19 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1345820AbjKQKEO (ORCPT <rfc822;jaysivo@gmail.com> + 30 others);
Fri, 17 Nov 2023 05:04:14 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230105AbjKQKEM (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 17 Nov 2023 05:04:12 -0500
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
[IPv6:2001:4b98:dc4:8::229])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3B6AD;
Fri, 17 Nov 2023 02:04:08 -0800 (PST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id B02BFFF80F;
Fri, 17 Nov 2023 10:04:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
t=1700215447;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=FAldIdFOcM6TSQgoc+utZ58ITzn88qsDQysRSDWf7aE=;
b=CWRbqMYkcicpcthfaTaZUOscd6Wt623MOsiQdZmUgWhnIc1T6SfQvhnfkr9w3z6sXRvzZg
+jSHd2ucjSFwLUtWTWNGpsEnB4irS2FCwHUNlJP6teX085KkgGMNBUVjMvxFIR565ru+la
/pdox0q4vBvNZsO9cPSteGHeJrfRWfEQEnVAhODfmwHcOo2ePeGqoeYYB7xoGCz4QHFiBK
gCm8GgfaA4CSOPTPjURP8gquTjdy8KBee5gEgBO55CaMj5ckVon35OBdD8YGy4cgr0WlL5
7Smf8QWcZf/zm6gSKw07/HBe6OQ5Y0RoccMolikPqPVtcjPnnIgJbkIqnxK4bw==
From: Kory Maincent <kory.maincent@bootlin.com>
Date: Fri, 17 Nov 2023 11:03:50 +0100
Subject: [PATCH v6 2/6] dmaengine: dw-edma: Fix wrong interrupt bit set for
HDMA
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231117-b4-feature_hdma_mainline-v6-2-ebf7aa0e40d7@bootlin.com>
References: <20231117-b4-feature_hdma_mainline-v6-0-ebf7aa0e40d7@bootlin.com>
In-Reply-To: <20231117-b4-feature_hdma_mainline-v6-0-ebf7aa0e40d7@bootlin.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Cai Huoqing <cai.huoqing@linux.dev>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Herve Codina <herve.codina@bootlin.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Manivannan Sadhasivam <mani@kernel.org>
X-Mailer: b4 0.12.4
X-GND-Sasl: kory.maincent@bootlin.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]);
Fri, 17 Nov 2023 02:04:19 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1782805126541395658
X-GMAIL-MSGID: 1782805126541395658
|
| Series |
Fix support of dw-edma HDMA NATIVE IP in remote setup
|
|
Commit Message
Köry Maincent
Nov. 17, 2023, 10:03 a.m. UTC
Instead of setting HDMA_V0_LOCAL_ABORT_INT_EN bit, HDMA_V0_LOCAL_STOP_INT_EN
bit got set twice, due to which the abort interrupt is not getting generated for
HDMA. Fix it by setting the correct interrupt enable bit.
Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v3:
- Split the patch in two to differ bug fix and simple harmless typo.
Changes in v6:
- Update commit message
---
drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c index 1f4cb7db5475..108f9127aaaa 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) /* Interrupt enable&unmask - done, abort */ tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | - HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN; + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);