From patchwork Fri Nov 17 20:12:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 166311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp788291vqn; Fri, 17 Nov 2023 12:15:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0z/LmCU1FhdLIBpnwbzHxz+yvFvRvZ/0eZN1nIFhZiNf7gIQQrXcisrcFcgtM7MRyyj5u X-Received: by 2002:a05:6a21:612:b0:187:858b:8c17 with SMTP id ll18-20020a056a21061200b00187858b8c17mr214923pzb.2.1700252159338; Fri, 17 Nov 2023 12:15:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700252159; cv=none; d=google.com; s=arc-20160816; b=TNbOKHU9thuPDBQV8nAh6Rjg+Vnqnsy2KiaDN8JwdI+3w2FpHJ/Wt4zQKw3AkNZVbM 5fMlUVRUcB/mOGUdVvJssfW5MjHzgfVoeVfAOiLdGf8XiPDPXcMq1DHIDe8WQbJwr7Ql Tf7JBoiFeOAwB2vAVyG2AS+yzJqsknVf7uDz90HgDj83KEib/Dv3RCeFOK+JbCE3JPxj 7DZiy6WU2avdQifeS1/NhGMBgNUkM6XEfUIfRSKS9FHdunB/3JU3Tl5ETNMoWirD181i 9Zqpv0lDVsYZ3EaGTb7KX6YHwoKOloxOA/nnrIejg2rhELORBvf083b1iRS/1LiOf8+8 c3bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=npvMQYAJSwyILZ7IKukB/DvG7sNQ93TySYJ1U4gDkl4=; fh=iMzJmnbboC4LJtlxOKimqPq82YSRfb3zCJyFaxC9c3g=; b=LuJMZHONpmw9F/VrbjxdZMHYX6UBRn3eGR34pijbR+c3iMxMHsc9Z3qPyHLME9M5Fi nNb4X22RgiSRCp8RPkndOqMXdK8zgJsKsvVn8xsYzmBbw0rqLzC9FEqyt74qjk6t9cyt SlmKcrw4iKT5byTXCy/IVraGBtVJCv3O6mijTS4UyBC1kIfTPlmoI4LPcxctgZNZxoxH k/U2XDwhhhgTRodO1axHvnKxgQsDH7eF4V2D6/uYdsa2xjVeGVHB292I6Iu6qEIovwrz NdpwxYTrcIiygyYWAgOc8dJ3yXShL+CTOnsXC0XodYJgyImlE5T9LLskFhYg2msJSHiB lvhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=dF4HhDH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id by29-20020a056a02059d00b0059c0f9ef964si2958840pgb.635.2023.11.17.12.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:15:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=dF4HhDH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6713E8088A4F; Fri, 17 Nov 2023 12:15:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235752AbjKQUOV (ORCPT + 29 others); Fri, 17 Nov 2023 15:14:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346154AbjKQUOD (ORCPT ); Fri, 17 Nov 2023 15:14:03 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D96510D9 for ; Fri, 17 Nov 2023 12:13:58 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3b566ee5f1dso1446450b6e.0 for ; Fri, 17 Nov 2023 12:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1700252038; x=1700856838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=npvMQYAJSwyILZ7IKukB/DvG7sNQ93TySYJ1U4gDkl4=; b=dF4HhDH2eqiJds+sz20xspLu3qG1xNOdNILpBOPIQlUyyAd/h6KZkNRbNNuCYrZuvG 42zo54xPs/eko/hE5oub++KHHUkCnGYIbv4p+2xIgz/IPQ6e0KsOon+CTZn7MywympNu oYh8XdrJbK3gLKJIzbrlD3wX+DsY5Ll/opwJh9SJKt9JBpjKzhe12AWXCvlcXdkYVpxa GJSl4jWRDwE9c3vUto2rD5w3tFfh/g/c630723YIhpvthgo9nOo2waY3gx/BdmNOexZO 7P2BZAidQZchZ5ouG7SqPpT64+d4u7uthtwRXC5M+KLgpoUxJasnS9SqQnHqWfXIHZw/ Ckvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700252038; x=1700856838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=npvMQYAJSwyILZ7IKukB/DvG7sNQ93TySYJ1U4gDkl4=; b=arnrjCngIYOWQ/wrnXpvq07rL3xZ9sZ+hT7INJ+3qAgOsVmMcd0fW+Yg9BH4ZB5p/d VYppAg40Zn4Py/fJkx1Q3RMJEeuC00HcSzLnNr6Ak6FYZ21sGl/9mQy/uI2k/lwqSnOn Ud5pEI6cr7XvYYrO1RwaPKEgOJLgEdbSo0Xu3j3LZlJXHHq113sVspL62FWAGx+GcJHX q3RYgZS06ez+knUf60G7ZqP7byhUe2x1nZ+MQ53e/L3+fYNULATglCRxGV3VabkqPK28 qE2tYKuln3/fOZhw1ClcbSV1u0vcMf+KDup78ESPIhVewzLdarbP1giqGezV81Y7wkaS tpEg== X-Gm-Message-State: AOJu0YwtHjSIBAAWwX6Iv9GB0KjOGavnfHjXIN6eqLJgw7vGuiyO16EN Ij6S3HQJGGIEFXTjYAFayC8DVw== X-Received: by 2002:a05:6808:1288:b0:3ab:84f0:b49d with SMTP id a8-20020a056808128800b003ab84f0b49dmr594399oiw.3.1700252037854; Fri, 17 Nov 2023 12:13:57 -0800 (PST) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id l21-20020a544515000000b003a8560a9d34sm393814oil.25.2023.11.17.12.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:13:57 -0800 (PST) From: David Lechner To: linux-spi@vger.kernel.org, devicetree@vger.kernel.org Cc: David Lechner , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Lars-Peter Clausen , linux-kernel@vger.kernel.org Subject: [PATCH 08/14] spi: axi-spi-engine: check for valid clock rate Date: Fri, 17 Nov 2023 14:12:59 -0600 Message-ID: <20231117-axi-spi-engine-series-1-v1-8-cc59db999b87@baylibre.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com> References: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 17 Nov 2023 12:15:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782843608282845417 X-GMAIL-MSGID: 1782843608282845417 This adds a check for a valid SCLK rate in the axi-spi-engine driver during probe. A valid rate is required to get accurate timing for delays and by not allowing 0 we can avoid divide by zero errors later without additional checks. Signed-off-by: David Lechner --- drivers/spi/spi-axi-spi-engine.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 819744246952..8a6fbb3bb3f1 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -532,6 +532,9 @@ static int spi_engine_probe(struct platform_device *pdev) host->transfer_one_message = spi_engine_transfer_one_message; host->num_chipselect = 8; + if (host->max_speed_hz == 0) + return dev_err_probe(&pdev->dev, -EINVAL, "spi_clk rate is 0"); + ret = devm_spi_register_controller(&pdev->dev, host); if (ret) return ret;