From patchwork Fri Nov 17 20:12:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 166304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp787407vqn; Fri, 17 Nov 2023 12:14:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnCELmG410AbfIfu79ALwOY0jO5pcU5Kvpka/9Vt3P/QpKRq1ARX5GcpyGDZdeRV+aY49h X-Received: by 2002:a92:d6c6:0:b0:359:412a:3358 with SMTP id z6-20020a92d6c6000000b00359412a3358mr600232ilp.24.1700252070010; Fri, 17 Nov 2023 12:14:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700252069; cv=none; d=google.com; s=arc-20160816; b=KopVU98E7mXnmYzXzOIcY8jPGW/36PHUCWIVGJSrLBXnPGDtNlnZA7pq80lWP309lR ncXIVRWY8x8JO2m+TUBu++WVFp3LQjAC+XXYeXG8gk42Jax/2MWYsfM8ec6b4PM+9Le5 +/be4DjnkkeVtHd6bE3vzot5UjLsE5XPJt67SWvnJoDaWU1b++Q7np+4tWG+gDw1tZ4N D5EXyA4/HXY++MS5tNyzuV/9HvwRWuQ9bv8GmO14z9kh1KOakzGXONae7UCoZgWb5PB/ UEOHQpl3bHzFGXuJm+/5KL0SY5qTgqIh+mHgvi+8p1SHYcU1UVmI4q0G3DDfXHS6jKOz 6oMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M1wQ6CLb/dDh5KiZFFpLs1bmPNGn2Z5vlnYTp1713SY=; fh=iMzJmnbboC4LJtlxOKimqPq82YSRfb3zCJyFaxC9c3g=; b=ru/N6+COa9Z1LwXeA1GCXedwthhFNI8TbEbPAAQW2rmHib0TemmVLxqGaw8se7utez 1Dri/82rfw9vK8/ojDOJnwigTOS2KRiqtIcbdZ6Bj5cp5mjBubAbdiAUYl7qTQ4IEoR4 SxkKqCLQ9uFH7msUeePBi25NYfiYl29Nq4AlHuRvPzkSpo5W2cTsUKbr8qw/TLenQmj2 dJ+bXfAeOei/r8CxtL4qJE5RMgWU4Rd+W6z4dCUoeU5t1ssNQ0aW6NCf2BkR8WZ1PGDn 5ks/SE1VDENd2Nh+sJVAC/W9q+6ySbjCucGZyY+E3LgK8V1rze5wRTBbJ7PPeyTC47vW RLIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="zs/TE/2d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b17-20020a656691000000b005ab1fd6fbc1si2560632pgw.847.2023.11.17.12.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:14:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="zs/TE/2d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 341F682AAEA5; Fri, 17 Nov 2023 12:14:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346214AbjKQUOO (ORCPT + 29 others); Fri, 17 Nov 2023 15:14:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235726AbjKQUOB (ORCPT ); Fri, 17 Nov 2023 15:14:01 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE00410D5 for ; Fri, 17 Nov 2023 12:13:57 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3b2df2fb611so1609902b6e.0 for ; Fri, 17 Nov 2023 12:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1700252037; x=1700856837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M1wQ6CLb/dDh5KiZFFpLs1bmPNGn2Z5vlnYTp1713SY=; b=zs/TE/2dzcTIHUUgBQPW21glYKrUWr6e4lez1HsM2FETRIb0q8ttXaWHDhMMvtxAvz PAhB3Tm0uoj1B5VYSmFBymiCNJ0qscRwXnixBcesVok1F1NthOM3gCQJ55ulb6TnQ81w QoE73k5cJYhWxylpLelYJJ9WOz/68NEgZf77Zx0lX97Ju/Mu1kuYqoQmdP9/AZnwdQKa tTR0PXgA2IwZFFujByP9vR/f06oghFv9yczgJDjOQWmB2ZuW3pJugDhDIl+vje0E7HCk PZ6+/txXyoTmm2d67EzqcMSCnYEhdm1ANSv96YH/3FiQaCQyBA+EZ7MB4QuoamUFPEdh 9RIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700252037; x=1700856837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M1wQ6CLb/dDh5KiZFFpLs1bmPNGn2Z5vlnYTp1713SY=; b=imBIKK6AUSZJTm+5s1peYQnkB0flDt+7qkJnA8PTP95EQkhnvwPRcSFQ9CKnPkMvni zxQLDXH46N3m7hsxQg/17GKQjNeEx34sb9CYFci01SpkH1Aburz3X0JqiImnvYEx+six dHNIVPd1j+btYwPCvKcjhesAeWBJwp1SapxG0pNolYaIP8RfXHu3a+apDqRmvKiAVwEw WNT4/QjnII22jwx7TtefUQFWXg2cfHoE8Nfvt2R/GX0Ct1Jv3JqL5H8QsiwXZI5bsvcc MHW6XssUgMmoprsagLC0aeIjSSrEzvaRRxVPEDwUcUwX2Utf5TsIfkB0nivFVGB99f2l nT1w== X-Gm-Message-State: AOJu0YwBthyXBWePystdeGkR/qHjjTzSFbwRMirbVNA0HZ1CmHGlzP/C XTyghPls7m6bzaaTfm3Y+71Upg== X-Received: by 2002:a05:6808:1922:b0:3b2:e70e:b448 with SMTP id bf34-20020a056808192200b003b2e70eb448mr531624oib.8.1700252037075; Fri, 17 Nov 2023 12:13:57 -0800 (PST) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id l21-20020a544515000000b003a8560a9d34sm393814oil.25.2023.11.17.12.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 12:13:56 -0800 (PST) From: David Lechner To: linux-spi@vger.kernel.org, devicetree@vger.kernel.org Cc: David Lechner , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Lars-Peter Clausen , linux-kernel@vger.kernel.org Subject: [PATCH 07/14] spi: axi-spi-engine: use devm_spi_register_controller() Date: Fri, 17 Nov 2023 14:12:58 -0600 Message-ID: <20231117-axi-spi-engine-series-1-v1-7-cc59db999b87@baylibre.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com> References: <20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 12:14:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782843514487717653 X-GMAIL-MSGID: 1782843514487717653 This replaces spi_register_controller() with devm_spi_register_controller() in the AXI SPI Engine driver. This saves us from having to call spi_unregister_controller() in the remove function. The remove function is also removed since it is no longer needed. Signed-off-by: David Lechner --- drivers/spi/spi-axi-spi-engine.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 81d7352d2b8b..819744246952 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -532,7 +532,7 @@ static int spi_engine_probe(struct platform_device *pdev) host->transfer_one_message = spi_engine_transfer_one_message; host->num_chipselect = 8; - ret = spi_register_controller(host); + ret = devm_spi_register_controller(&pdev->dev, host); if (ret) return ret; @@ -541,13 +541,6 @@ static int spi_engine_probe(struct platform_device *pdev) return 0; } -static void spi_engine_remove(struct platform_device *pdev) -{ - struct spi_controller *host = platform_get_drvdata(pdev); - - spi_unregister_controller(host); -} - static const struct of_device_id spi_engine_match_table[] = { { .compatible = "adi,axi-spi-engine-1.00.a" }, { }, @@ -556,7 +549,6 @@ MODULE_DEVICE_TABLE(of, spi_engine_match_table); static struct platform_driver spi_engine_driver = { .probe = spi_engine_probe, - .remove_new = spi_engine_remove, .driver = { .name = "spi-engine", .of_match_table = spi_engine_match_table,