Message ID | 20231116211739.3228239-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp122052vqn; Thu, 16 Nov 2023 13:17:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXDJpIXqZ2B6H2Q9U8kkE8nfgzC1Bkz8m43U+wo8jx81G/fyHR67/GAnu/ELfRoD8zHqJ3 X-Received: by 2002:a05:6a20:7da6:b0:186:bd68:facc with SMTP id v38-20020a056a207da600b00186bd68faccmr12568967pzj.28.1700169472370; Thu, 16 Nov 2023 13:17:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700169472; cv=none; d=google.com; s=arc-20160816; b=j173Li6S19myeE7jTOiZ1AyB5YVbVzr8f/H2gIlQql8JjKkV6vT5wO6axm+Wg0K7LK P162rlf06Jt1o6jENg+D3aSVvlRV4Gko/dNwIt08GqSM8XeWt4QRH2oDiyochozU5ssz BryivxBreXvi9Uugo+4qVcAudxlbNqoweyGXd0q/tVrKTZF9DL5wswiZbdE3hjJ8mfR5 58QfZ1VKUk+pR64RTapBQkxA97Bht1+ylkrOJ783zPgj3kMtySS+bFtNkU0Dz6gKxF6Z zmDV59dUnTdhc75wiW+65EisbH3qoqfWNqE5ZRrcFK4McrAsm6KjoGDBroO3DMKCdr8r ksYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=qnTKqQWM65hHmGWrh7eGkwdIKG6NV9DIncGlNOoqLgY=; fh=9qK7SVQLrVnNP03+Ygbjnkv8QXQOH0MdQRmTdFPiWxk=; b=Lzu56X7fkTz1gFwHNsqAq1PdwR2kqpP8D+XDVSV8hamKIHDbvzTekGIDoXZya7hptc 5PBOcR9+cgWotmYn/Ij49DrsZBzUwLC8OWJQG7/pmHFcrDpQlTYxUKpDcYd7uboCF54i 3U9yFgAY2iCsnuRl+PAaRj0cd4/0e/P5+tPM1Qbw7jZSdNj0zYbwv1+zOCw8Nx/XLJ1j BwUMUNk7sokrSEThgsSR9oi3/IhUWHpexhHLF//nARIGVliAz6Plkuy8f6oeuKc2kqZn /o9jYK9NZWym02heA7+aD6FwhRgEbWZ3v3RGQGhqQTfHeUJak7A4oBXExLO44KJU+dp2 7/iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w9-20020a63d749000000b0059b70e69eddsi294208pgi.300.2023.11.16.13.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 13:17:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7A5DE8028A5C; Thu, 16 Nov 2023 13:17:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbjKPVRs (ORCPT <rfc822;jaysivo@gmail.com> + 30 others); Thu, 16 Nov 2023 16:17:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKPVRr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 16 Nov 2023 16:17:47 -0500 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A205B0; Thu, 16 Nov 2023 13:17:44 -0800 (PST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-1f00b95dc43so660892fac.3; Thu, 16 Nov 2023 13:17:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700169464; x=1700774264; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qnTKqQWM65hHmGWrh7eGkwdIKG6NV9DIncGlNOoqLgY=; b=ax9MXv8UIQLPoWRVd3lBeGX3GcvztvrCZuAirWtBhDfj9zqQWxbMxBobJxQqL6Oef6 rwT7RO++2lQpX/tIrACjVtDMgQrMAudTQgjzUN4/+/tqFluM7vOx/AzWWpbOljTIuO2Y t39sWO8LOcjwgaWLh5yDonosT5GIosNhYYfBLCrxVZP5b0MI/8zK6XtlVwht0fl+S7sL lW4qggmuEZz0YYX+ogChV0Lk5v2URVVnc0Fsoh3C1xE7h2epKVA2K8fhIYOFXid3/4b6 yFgafai0Ov8uOXg7CcCuC0FDQsiiEpV8cW4RMqIGSK0iSJv0BWlG1U0I4g+eXUTKXSjm MMrA== X-Gm-Message-State: AOJu0YyOseU+ANelQeqM44lLsN1GssoxSmVklbgGiN5GTQ6eCQYYmEwK 1wPEoLOFuqJ4PIG/VGSB9A== X-Received: by 2002:a05:6870:2102:b0:1cc:c744:d320 with SMTP id f2-20020a056870210200b001ccc744d320mr22303935oae.53.1700169463720; Thu, 16 Nov 2023 13:17:43 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id mo49-20020a056871323100b001ea689d8969sm33233oac.48.2023.11.16.13.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 13:17:42 -0800 (PST) Received: (nullmailer pid 3228341 invoked by uid 1000); Thu, 16 Nov 2023 21:17:41 -0000 From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default Date: Thu, 16 Nov 2023 15:17:38 -0600 Message-ID: <20231116211739.3228239-1-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 13:17:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782756904281929213 X-GMAIL-MSGID: 1782756904281929213 |
Series |
arm/arm64: samsung: Enable W=1 on dtbs by default
|
|
Commit Message
Rob Herring
Nov. 16, 2023, 9:17 p.m. UTC
Samsung platforms are clean of W=1 dtc warnings, so enable the warnings
by default. This way submitters don't have to remember to run a W=1
build of the .dts files and the grumpiness of the maintainers can be
reduced.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Well, there's a couple of warnings on 32-bit, but they look fixable to
me.
There's a few other platforms we could do this to. Sadly, they are still
the minority. Otherwise, we could change the default and add a flag to
disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1).
---
arch/arm/boot/dts/samsung/Makefile | 3 +++
arch/arm64/boot/dts/exynos/Makefile | 4 ++++
2 files changed, 7 insertions(+)
Comments
On 16/11/2023 22:17, Rob Herring wrote: > Samsung platforms are clean of W=1 dtc warnings, so enable the warnings > by default. This way submitters don't have to remember to run a W=1 > build of the .dts files and the grumpiness of the maintainers can be > reduced. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Well, there's a couple of warnings on 32-bit, but they look fixable to > me. > > There's a few other platforms we could do this to. Sadly, they are still > the minority. Otherwise, we could change the default and add a flag to > disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1). 64-bit has still few warnings: https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ I guess these could be fixed by changing ports to port in the DTS and bindings. I assume drivers are ready for it. 32-bit I fixed in this cycle - last three commits - so all Samsung 32-bit platforms are free from W=1 dtc warnings (yay!). Best regards, Krzysztof
On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 16/11/2023 22:17, Rob Herring wrote: > > Samsung platforms are clean of W=1 dtc warnings, so enable the warnings > > by default. This way submitters don't have to remember to run a W=1 > > build of the .dts files and the grumpiness of the maintainers can be > > reduced. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Well, there's a couple of warnings on 32-bit, but they look fixable to > > me. > > > > There's a few other platforms we could do this to. Sadly, they are still > > the minority. Otherwise, we could change the default and add a flag to > > disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1). > > 64-bit has still few warnings: > https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ I may move that graph check to W=2. There's some cases where port@1 is optional and it doesn't really make sense to fix these. Also, Conor wants to do this for all of riscv, but this solution is per directory. So I need to rework it to use a different variable that can be per directory or global. Rob
On 21/11/2023 15:58, Rob Herring wrote: > On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 16/11/2023 22:17, Rob Herring wrote: >>> Samsung platforms are clean of W=1 dtc warnings, so enable the warnings >>> by default. This way submitters don't have to remember to run a W=1 >>> build of the .dts files and the grumpiness of the maintainers can be >>> reduced. >>> >>> Signed-off-by: Rob Herring <robh@kernel.org> >>> --- >>> Well, there's a couple of warnings on 32-bit, but they look fixable to >>> me. >>> >>> There's a few other platforms we could do this to. Sadly, they are still >>> the minority. Otherwise, we could change the default and add a flag to >>> disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1). >> >> 64-bit has still few warnings: >> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ > > I may move that graph check to W=2. There's some cases where port@1 is > optional and it doesn't really make sense to fix these. > > Also, Conor wants to do this for all of riscv, but this solution is > per directory. So I need to rework it to use a different variable that > can be per directory or global. Just to clarify, because I still have this patch in my inbox: I assume you are going to send a v2 of this, so I drop it. Best regards, Krzysztof
On Thu, Jan 25, 2024 at 12:31:42PM +0100, Krzysztof Kozlowski wrote: > On 21/11/2023 15:58, Rob Herring wrote: > > On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 16/11/2023 22:17, Rob Herring wrote: > >>> Samsung platforms are clean of W=1 dtc warnings, so enable the warnings > >>> by default. This way submitters don't have to remember to run a W=1 > >>> build of the .dts files and the grumpiness of the maintainers can be > >>> reduced. > >>> > >>> Signed-off-by: Rob Herring <robh@kernel.org> > >>> --- > >>> Well, there's a couple of warnings on 32-bit, but they look fixable to > >>> me. > >>> > >>> There's a few other platforms we could do this to. Sadly, they are still > >>> the minority. Otherwise, we could change the default and add a flag to > >>> disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1). > >> > >> 64-bit has still few warnings: > >> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ > > > > I may move that graph check to W=2. There's some cases where port@1 is > > optional and it doesn't really make sense to fix these. > > > > Also, Conor wants to do this for all of riscv, but this solution is > > per directory. So I need to rework it to use a different variable that > > can be per directory or global. > > Just to clarify, because I still have this patch in my inbox: I assume > you are going to send a v2 of this, so I drop it. We got https://lore.kernel.org/linux-devicetree/20231122-dtc-warnings-v2-0-bd4087325392@kernel.org/ out of this instead of a v2, did we not?
On 25/01/2024 18:51, Conor Dooley wrote: >>>> >>>> 64-bit has still few warnings: >>>> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ >>> >>> I may move that graph check to W=2. There's some cases where port@1 is >>> optional and it doesn't really make sense to fix these. >>> >>> Also, Conor wants to do this for all of riscv, but this solution is >>> per directory. So I need to rework it to use a different variable that >>> can be per directory or global. >> >> Just to clarify, because I still have this patch in my inbox: I assume >> you are going to send a v2 of this, so I drop it. > > We got > https://lore.kernel.org/linux-devicetree/20231122-dtc-warnings-v2-0-bd4087325392@kernel.org/ > out of this instead of a v2, did we not? Indeed, I forgot. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile index 7becf36656b1..b6a0e2beac00 100644 --- a/arch/arm/boot/dts/samsung/Makefile +++ b/arch/arm/boot/dts/samsung/Makefile @@ -1,4 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 + +KBUILD_EXTRA_WARN=1 + dtb-$(CONFIG_ARCH_EXYNOS3) += \ exynos3250-artik5-eval.dtb \ exynos3250-monk.dtb \ diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile index 6e4ba69268e5..45c996fba5e4 100644 --- a/arch/arm64/boot/dts/exynos/Makefile +++ b/arch/arm64/boot/dts/exynos/Makefile @@ -1,4 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 + +KBUILD_EXTRA_WARN=1 +DTC_FLAGS += -Wno-graph_child_address + dtb-$(CONFIG_ARCH_EXYNOS) += \ exynos5433-tm2.dtb \ exynos5433-tm2e.dtb \