From patchwork Thu Nov 16 18:07:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 165913 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6513:b0:164:83eb:24d7 with SMTP id sk19csp42363rwb; Thu, 16 Nov 2023 10:08:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlVgV5K6UZA4vvMbnQg5OzlYonY3ZZE4sn0IlbS84AbL30SCojXEvau20030pfUixoqEJf X-Received: by 2002:a05:6808:a08:b0:3a8:6a40:7dc0 with SMTP id n8-20020a0568080a0800b003a86a407dc0mr1083081oij.18.1700158104907; Thu, 16 Nov 2023 10:08:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700158104; cv=none; d=google.com; s=arc-20160816; b=ZnERG+pzvdP++9cgAp0/petl72/lBfvxEnBxh74537nenbi+GwcHzYNOFBWrA6zTHF lvOZ76fuA8nGdPLGQ1UmaKsVDqYUT5tUjWe/wkwunVrFzcR72mDSVjE7mYjf6po3PLOF n81I9+9VlNSv2uz94q+rwf/SnHsv9GarqnRXpd/4OIu+DAFuCBQpIRkYhpYPlkbSi8LZ UCPVITtqKtuN1X6nTJaPacrWNHErvUiaTmupLBrPsGlgJnaXhLEDAsgNkrrLoMf6VwjP dQS+IHzIutZQhB8aetytR3nLDxisvYhyMVQ9w071VToTRiuX+oBDC/kU39PIF66UkBc9 6dMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; fh=IQmJCxPvp1ZuEZ4xmMZzdl9jXmWmBntiQu4cA2IR9EY=; b=EtqaA4yJ34JFiZuCaKlCV4iYsT0jNWji12nJFmpMRNSmEFYCqkE+iIXwMM0urLHI6B 1Xo1UPCV7Zbng1HNexybWNOOud2mXJ+3m3DnN9GGGdki+FBHIs8wisO4BwZg+86tgM0A nMMmXy9lNVaPS2KSnkNwSkkAuWUgM0CSdONktZOhOsM96lzi6PUqXaRp5dxYKMqdxqcK uSOpA2+jmRpgItt1037kBpEbjEFJxCzKH8aaBpQfzIiORQnbKFxHoQkOhQDfFJ2unkie /OD5Cg7sCWCrm+CWDOduff48lFqLMNzy+HRsQeKdL98V0PwSr0YB1L6C5xfx9sdWlEbZ wtYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3NlFgy2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u3-20020a056808114300b003a86423b91fsi2687245oiu.166.2023.11.16.10.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:08:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3NlFgy2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C20F381CDE2A; Thu, 16 Nov 2023 10:08:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345368AbjKPSID (ORCPT + 30 others); Thu, 16 Nov 2023 13:08:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbjKPSIC (ORCPT ); Thu, 16 Nov 2023 13:08:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03C33D49 for ; Thu, 16 Nov 2023 10:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700158077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; b=g3NlFgy2WNFABIQMSA6+FYULD1hl+ZrQ1uavutzgH//ayBV2OksIxEsj1m2x+pyAyEwbOr 33+CrX6aFlcczFmd6wIwCEYOMSxwVpERHOvyVAc+UYKW8lRJjKbXXJtuYiUnTMG9O1baUX nGkCOz8963FLWx73omQYqudv52rEIyw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-hduKsP3VO6eiiLkjePYDqg-1; Thu, 16 Nov 2023 13:07:56 -0500 X-MC-Unique: hduKsP3VO6eiiLkjePYDqg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40a3efec9a7so6964435e9.1 for ; Thu, 16 Nov 2023 10:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158073; x=1700762873; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hPxzOncy5HIGVOblAN4i/IW7KR+JFRLvP+iQR6fOxe0=; b=mNCCezryEw07UYd3kQKZeeSTVMXtuwBhOhEFYr1qIqwitIqgI2dTHneQrOxtqcYGHU FLHT+eIaKW82YSw5Ziv7ZzriM07bg9cuoZKGd28HWBD05vTwXWVUcD89bbZBfq+zha6u nOMp95DfmGKpBH329BFT7OjmqmDZ2ve7j3qT77q4k4/SLguf+H69W8YGFpoCIkk59z0W JFCj1FOId4mfyYGiRDHuHqW9qFmACrCvsnkqhzLXkm1AbQRk+Gzno6FsYm0hCbF1d+ta etO+KtwPaidcA6idcITjhDVxhMZM8nFLgPeI5mww39EIhmjG3n4EYRZVi/bAvgmShy+I iMPg== X-Gm-Message-State: AOJu0Yxup4L1PTK7KyQt4ZJa+iMvZ0AJ3np64vFetdy1krep1HmuWhg7 QTx3K29Cbxto3Ee8yc7ItBtaKvk8YRIM1m+RkpgSbFdGH1B51/a7i4K41pcaNdUrClYRfFTc+BO elXFKXu/ZtEpozZmgdSS+RygUC4PmeClNI1WtFP9ztjOfYKZ0WGs5qQghIN6ia7VeWu7wgoaUFK ESDIpjraA= X-Received: by 2002:a05:600c:c0f:b0:402:e68f:8896 with SMTP id fm15-20020a05600c0c0f00b00402e68f8896mr14609083wmb.0.1700158073656; Thu, 16 Nov 2023 10:07:53 -0800 (PST) X-Received: by 2002:a05:600c:c0f:b0:402:e68f:8896 with SMTP id fm15-20020a05600c0c0f00b00402e68f8896mr14609042wmb.0.1700158073266; Thu, 16 Nov 2023 10:07:53 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id w8-20020a05600c474800b0040836519dd9sm61664wmo.25.2023.11.16.10.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:07:52 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Sahaj Sarup , Javier Martinez Canillas , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Rob Herring , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] dt-bindings: display: ssd1307fb: Change "solomon,page-offset" default value Date: Thu, 16 Nov 2023 19:07:37 +0100 Message-ID: <20231116180743.2763021-1-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 10:08:22 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782744984878541053 X-GMAIL-MSGID: 1782744984878541053 This is used to specify the page start address offset of the display RAM. The value is used as offset when setting the page start address with the SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to 1 if the property is not present in the Device Tree. But the datasheet mentions that the value on reset for the page start is a 0, so it makes more sense to also have 0 as the default value for the page offset if the property is not present. In fact, using a default value of 1 leads to the display not working when the fbdev is attached to the framebuffer console. Reported-by: Sahaj Sarup Signed-off-by: Javier Martinez Canillas --- .../devicetree/bindings/display/solomon,ssd1307fb.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index 3afbb52d1b7f..badd81459aaa 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -35,7 +35,7 @@ properties: solomon,page-offset: $ref: /schemas/types.yaml#/definitions/uint32 - default: 1 + default: 0 description: Offset of pages (band of 8 pixels) that the screen is mapped to