From patchwork Thu Nov 16 06:30:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Shumilin X-Patchwork-Id: 165710 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3020623vqg; Wed, 15 Nov 2023 22:31:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuWEcjxPUbcvJBiNTRH5bmzkZsbVvexq4KPhQqfq/VS+YfTQTxRfs3oPaYlVHmFmJDNRGA X-Received: by 2002:a17:90b:3a8d:b0:283:21d3:11eb with SMTP id om13-20020a17090b3a8d00b0028321d311ebmr12513559pjb.3.1700116276807; Wed, 15 Nov 2023 22:31:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700116276; cv=none; d=google.com; s=arc-20160816; b=VAu/GGbhe/y7FwvZ/IFBmSiN7xbM0RftGSrE15O57uUthnMsmrleDHx6J88pCg8D1K 1CKDbAuGZscj/mWF2qwqLgzZi9E1mpE1nPSbqcZXG4as8HuJEv+O453mVfVPYRFDgf7G kZq35yXy2Oz6hgNLNSOHt/HIJLPyZgzQKPfD1cLqKWOO6PGR71x8vj6mIlKKz9BDC9bj n8Nrw5xVuaYCmmg2bLwOypV7WB4HgPU5g8DFjDrRiiSTYh+eWW54I+Uq7p3p7yzoED+6 PkxWCu7KIkoKKoyyHCTVMvujstX2W1L6FPQp2hu+mI7/zr483VnpjJ3yoyB5c4J5XjMx Mwyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wbaIlybzkkqnUkhol4Lh9dNTTl2ITokMciVUyt4etsA=; fh=Gwa7GV/cx7+bKMbWPn+vyf+0RmtNXKo6RQ4/wFRzxKU=; b=gZFLJM+jr4uiG4EUHhBe5cphUtjjJ38HKYngBvfa9ZM62NFTn4MZ8X3sNzk1sejE2t d702+iqJleDR1vrKXlTocwAgCBZvm9pUbGSoE8oA6a+gq0OdPVgXDXWm4IUL3Qk17qX6 by2bXz3AIX9CVCSdFQPZvAGYz+LX5KZuMDXtj9qgiiNCdWnyK7OvR3XCQYdDtjU3jSyK moAcO/WdUZp/LWxbCQg3t+KrVrelPAoU0gTugxK4cY2w0pW/ORtR8XZ8QfXXdqXwWMbv Q7yZsHXZwMd3gb/BsrDa/OLvjpnsNiZzO/TVeqbRgGHB9Cj7869yMtvCDHXQn5ddVolY ppsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b=kPjlYx5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a14-20020a17090ad80e00b0027ff697a057si2820703pjv.0.2023.11.15.22.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 22:31:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b=kPjlYx5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7F07D813EAAF; Wed, 15 Nov 2023 22:31:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjKPGbM (ORCPT + 29 others); Thu, 16 Nov 2023 01:31:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjKPGbI (ORCPT ); Thu, 16 Nov 2023 01:31:08 -0500 Received: from mail.nppct.ru (mail.nppct.ru [195.133.245.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 597E51A5 for ; Wed, 15 Nov 2023 22:31:01 -0800 (PST) Received: from mail.nppct.ru (localhost [127.0.0.1]) by mail.nppct.ru (Postfix) with ESMTP id 7368C1C0D74 for ; Thu, 16 Nov 2023 09:30:58 +0300 (MSK) Authentication-Results: mail.nppct.ru (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nppct.ru DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nppct.ru; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:to:from:from; s=dkim; t=1700116258; x= 1700980259; bh=/9MO8o7o6nntPf+7n/of28fm2Es83s6OBU6s1H6hwTA=; b=k PjlYx5ZWDj+EpWLiT3v60MmQyXnhu+8FlV9aPRkwbH+idUXuV7+J7zUFtVCV3xTM sJewLvpk6FMhZIvUT4Z1uwxLaZ5QA/USQ/1yBayGwfRX4anAuTmWR4aX2Ni85Ayl vh0VFv3L7eNXGF29bRZAVLF/MxREFAs7Wax1NiS42Q= X-Virus-Scanned: Debian amavisd-new at mail.nppct.ru Received: from mail.nppct.ru ([127.0.0.1]) by mail.nppct.ru (mail.nppct.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Fe-r_TlrEIJv for ; Thu, 16 Nov 2023 09:30:58 +0300 (MSK) Received: from localhost.localdomain (mail.dev-ai-melanoma.ru [185.130.227.204]) by mail.nppct.ru (Postfix) with ESMTPSA id 57B921C061A; Thu, 16 Nov 2023 09:30:55 +0300 (MSK) From: Andrey Shumilin To: Karol Herbst Cc: Andrey Shumilin , Lyude Paul , Danilo Krummrich , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, ykarpov@ispras.ru, vmerzlyakov@ispras.ru, vefanov@ispras.ru Subject: [PATCH] therm.c: Adding an array index check before accessing an element. Date: Thu, 16 Nov 2023 09:30:28 +0300 Message-Id: <20231116063028.35871-1-shum.sdl@nppct.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 22:31:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782701125425845671 X-GMAIL-MSGID: 1782701125425845671 It is possible to access an element at index -1 if at the first iteration of the loop the result of switch is equal to 0x25 Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Shumilin --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c index 5babc5a7c7d5..78387053f214 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c @@ -180,6 +180,8 @@ nvbios_therm_fan_parse(struct nvkm_bios *bios, struct nvbios_therm_fan *fan) cur_trip->fan_duty = duty_lut[(value & 0xf000) >> 12]; break; case 0x25: + if (fan->nr_fan_trip == 0) + fan->nr_fan_trip++; cur_trip = &fan->trip[fan->nr_fan_trip - 1]; cur_trip->fan_duty = value; break;