From patchwork Wed Nov 15 16:39:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 165482 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2661715vqg; Wed, 15 Nov 2023 08:39:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEF69fHgT6Oxq5tDekVDP5p4hMjNUeSpEyJnhtr7AZxfpBz81E5ZL+pHAfVE70aytwiPSvT X-Received: by 2002:a17:902:f683:b0:1ca:b820:74ed with SMTP id l3-20020a170902f68300b001cab82074edmr6965950plg.14.1700066389753; Wed, 15 Nov 2023 08:39:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700066389; cv=none; d=google.com; s=arc-20160816; b=kB06L9YQMRCEHysGi4LgY091Hf4W8ieWLPhS5kB25eGwHvMPjzgPh99/YBeGJodZbG dDP4aIwPPF3ONbJAdFstq7s2KxeIK8KBZwoUamLAwittrz2dAWn07fnhAnDABvlxL9FF 6ZeMj/ZvMKARCOTPwoGuIHmGxQnnq1hKGHQzTlAe22+KcLuZYbYIvx3yEHdb0ICs0zie cUyRz/XVxdpjF4Mc7XM3cRXRN7VMMSeeNK9wU4yRCTXZwT43pwVdx/DjO8QeDsdeFF4E m+C5dcIGHFGKiGMzYZgn66rzQNZJ4s8+ndTqvlyk2QX5n7fhkOyGQm50Y2GADJYfrMdG o+7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oJYa60ZycHhtgv5EnoNeCTdHHtPcZenZf0K8POVXSIo=; fh=FP+ffrafBoziKtAld7u50Ql/WsbhgFISxH3NOU3Jvlo=; b=biqDG7YGeRBUMt3TW/AMRCczBKs+259hL5yiuJpV47uiz6kVqj/lWU86wK1GMME+Zh RsOrT97eDpDeYt3vByCZ8HJ9nNSp1EJFp3hH/+hmbjvId9cZ3fxtclTS6u50lwtoQU3A b2O0jIkntUnlzhnSioInO4Ije0YIp4RPco65XWTbYm+bW23radFAn8MH9lxSUWY8mwGa 6Mc295GY7G0QUp6Xrkshrjd/+280H2EYwEiyip7H2yS/ULPwgF6kWB4UpFPMLRXdI5cg KBG36Jzarkc+Rn+CtSEJcXGlmJkIXqPGsrfe9L6GBS78FCVW+vsmMO81ADzwtvqwrWQU u1Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y1sPNITG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id l7-20020a170902f68700b001cc283d99a6si11012715plg.474.2023.11.15.08.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:39:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y1sPNITG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 01D8F81A3363; Wed, 15 Nov 2023 08:39:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbjKOQjg (ORCPT + 29 others); Wed, 15 Nov 2023 11:39:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232122AbjKOQj2 (ORCPT ); Wed, 15 Nov 2023 11:39:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ADD98E for ; Wed, 15 Nov 2023 08:39:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF136C433C8; Wed, 15 Nov 2023 16:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700066364; bh=gfk8zALZbdkLMNgU9Gvg6x8rMFGs5nttVZo1WOrF8z4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y1sPNITGGaeCwOfznhyoXmKJGEFd0tZ++yksjkpidz9p2R/pI7A2/vyZIT56zhhQl H2Zu9ECdXB+0ViFFD6rL81ZhRKBUQZyPJH+TRGJd0uykgthPOEZQoH4pkqwp1OgRO8 eYlBs17wIOYFJLxu3w1XbQdFeHSizwRRIevYRVRgGJ//mZ4V8jxK8KU7JV/vsSeZTb URJPS9RZMjJLmAgylqCEozfgTL0d/2w3DOcTaTRb/MK3jaEUlXJkdguHa2E+ZApntr tMVIhYfRW36fi9h6gfZaDTvrREzef+uaBCG6JSDvqYshritwA52uQ5OjRT9PMK+uf9 VCIgX3hpVyDsQ== From: Oded Gabbay To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Dafna Hirschfeld Subject: [PATCH 05/10] accel/habanalabs/gaudi2: fix undef opcode reporting Date: Wed, 15 Nov 2023 18:39:07 +0200 Message-Id: <20231115163912.1243175-5-ogabbay@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231115163912.1243175-1-ogabbay@kernel.org> References: <20231115163912.1243175-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:39:49 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782648814594224217 X-GMAIL-MSGID: 1782648814594224217 From: Dafna Hirschfeld currently the undefined opcode event bit in set only for lower cp and only if 'write_enable' is true. It should be set anyway and for all streams in order to report that event to userspace. Signed-off-by: Dafna Hirschfeld Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c index b739078c2d87..5075f92d15cc 100644 --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c @@ -7929,21 +7929,19 @@ static int gaudi2_handle_qman_err_generic(struct hl_device *hdev, u16 event_type error_count++; } - if (i == QMAN_STREAMS && error_count) { - /* check for undefined opcode */ - if (glbl_sts_val & PDMA0_QM_GLBL_ERR_STS_CP_UNDEF_CMD_ERR_MASK && - hdev->captured_err_info.undef_opcode.write_enable) { + /* check for undefined opcode */ + if (glbl_sts_val & PDMA0_QM_GLBL_ERR_STS_CP_UNDEF_CMD_ERR_MASK) { + *event_mask |= HL_NOTIFIER_EVENT_UNDEFINED_OPCODE; + if (hdev->captured_err_info.undef_opcode.write_enable) { memset(&hdev->captured_err_info.undef_opcode, 0, sizeof(hdev->captured_err_info.undef_opcode)); - - hdev->captured_err_info.undef_opcode.write_enable = false; hdev->captured_err_info.undef_opcode.timestamp = ktime_get(); hdev->captured_err_info.undef_opcode.engine_id = gaudi2_queue_id_to_engine_id[qid_base]; - *event_mask |= HL_NOTIFIER_EVENT_UNDEFINED_OPCODE; } - handle_lower_qman_data_on_err(hdev, qman_base, *event_mask); + if (i == QMAN_STREAMS) + handle_lower_qman_data_on_err(hdev, qman_base, *event_mask); } }