[v1,3/3] EDAC, pnd2: Sort headers alphabetically

Message ID 20231115154940.664664-3-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/3] EDAC, pnd2: Replace custom definition by one from sizes.h |

Commit Message

Andy Shevchenko Nov. 15, 2023, 3:49 p.m. UTC
  Sort the headers in alphabetic order in order to ease
the maintenance for this part.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/edac/pnd2_edac.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
  

Comments

Qiuxu Zhuo Nov. 16, 2023, 8:32 a.m. UTC | #1
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ...
> 
> Sort the headers in alphabetic order in order to ease
> the maintenance for this part.

This patch LGTM. Thanks!

Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/edac/pnd2_edac.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
> index 676e02c8dc43..1bbedd59e36b 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -16,19 +16,20 @@
>   * rank, bank, row and column using the appropriate "dunit_ops" functions/parameters.
>   */
>  
> -#include <linux/module.h>
> -#include <linux/init.h>
> -#include <linux/pci.h>
> -#include <linux/pci_ids.h>
> -#include <linux/slab.h>
> +#include <linux/bitmap.h>
>  #include <linux/delay.h>
>  #include <linux/edac.h>
> -#include <linux/mmzone.h>
> -#include <linux/sizes.h>
> -#include <linux/smp.h>
> -#include <linux/bitmap.h>
> +#include <linux/init.h>
>  #include <linux/math64.h>
> +#include <linux/mmzone.h>
>  #include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/pci.h>
> +#include <linux/pci_ids.h>
> +#include <linux/sizes.h>
> +#include <linux/slab.h>
> +#include <linux/smp.h>
> +
>  #include <linux/platform_data/x86/p2sb.h>
>  
>  #include <asm/cpu_device_id.h>
  

Patch

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 676e02c8dc43..1bbedd59e36b 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -16,19 +16,20 @@ 
  * rank, bank, row and column using the appropriate "dunit_ops" functions/parameters.
  */
 
-#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/pci.h>
-#include <linux/pci_ids.h>
-#include <linux/slab.h>
+#include <linux/bitmap.h>
 #include <linux/delay.h>
 #include <linux/edac.h>
-#include <linux/mmzone.h>
-#include <linux/sizes.h>
-#include <linux/smp.h>
-#include <linux/bitmap.h>
+#include <linux/init.h>
 #include <linux/math64.h>
+#include <linux/mmzone.h>
 #include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/pci_ids.h>
+#include <linux/sizes.h>
+#include <linux/slab.h>
+#include <linux/smp.h>
+
 #include <linux/platform_data/x86/p2sb.h>
 
 #include <asm/cpu_device_id.h>