From patchwork Wed Nov 15 15:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 165439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp2605353vqg; Wed, 15 Nov 2023 07:14:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+sLp65riFA0t987lWGgAkmCgxbp0WttZeZmxePoQgiNPLiktuMtfIaTZFaLmjLgbFHVtP X-Received: by 2002:a05:6a21:6d96:b0:186:4430:5d16 with SMTP id wl22-20020a056a216d9600b0018644305d16mr13641357pzb.61.1700061265142; Wed, 15 Nov 2023 07:14:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700061265; cv=none; d=google.com; s=arc-20160816; b=fyTmiccQ6St8B1Q3E+ItLV8eOOALK+EsfsJUH0JjqqY1V+fHBc2koYzX+BsXUPC1Rw uUcffSzAGYbvZE7b9hx0kmLXuYMNPdvopcrONc4AaQ9RuTuGeqpHm3GyuT9Wl0PbeNrL r9Bq35hbZpkG3tnQDZm9kMfLFjPJRSMo4nmif9ECKfho4FGwsVYRr+xGOMxPjZ5lKxZ0 bQQKN7yMqqiGnGCGs+u+8WSk8WOBD9tKP1HDtnK5uzAnunZyhOkrMcR4Mj021lU1NfXQ iiUBckc2Ud2aekL/ecxzamqVWqyUUb399blDpUAihsi61GHNOsefQlcv8HPNZaV2biCT bugg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6D0IcbnKu38KXda50Tk8L29X61iI2OOdAtrKLf2f1Mo=; fh=vOxJ5zAh/ByOGHIIhVBN1rQVKUP9RG+2PkGMcshoCBs=; b=FuuEn5cbhG9zM4xnqh8tSsrd/6YdTPQVOsLwFTy25kZpBC675UaFoZ98w/Wy9fQtSr j11h+l1I15Z7ND16QyAyJGoQiZTqqmyScyr0nQE+gVjgFUSJE6kHy4CyHfFwjh1vRwlf V+LgMqU+uHfB8P2YrVoI90FIt9qnpsowtqzA3VSdQhky01AZFDwVji7x61VpokmPc+zA Rlr/WCGlsVcNoVhE4gotwrnliJ1v83xzTQ6Cw3jA7duK1Z1UnJY0kWgiKwo87GrxW1aS CFUftonYzt4XBTOw235ermvGeQ7IM7pGJin5xZ5JffldChyotGGAA7cS45qlZH6uYthb 8zjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5m+7PM5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id a34-20020a634d22000000b00577448019cbsi9877969pgb.841.2023.11.15.07.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 07:14:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5m+7PM5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DB97681E14E8; Wed, 15 Nov 2023 07:14:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344473AbjKOPOW (ORCPT + 29 others); Wed, 15 Nov 2023 10:14:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344472AbjKOPOL (ORCPT ); Wed, 15 Nov 2023 10:14:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CAA1A7 for ; Wed, 15 Nov 2023 07:14:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DAFC433C7; Wed, 15 Nov 2023 15:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700061248; bh=9FyYN/LMD2/fmw8fX0LrTB664VhgSDnzIJOwUJw0Y/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s5m+7PM5vOqzBpNbL1+fn6Ycsl2BUOIivbf/wNwef9DrWYraapI6EjD0i1SiJvFMy 6TbCpVDi4b1Ihc+IpXrvrfcwYC5GveDUg7zyIv9CYD/e7bENZGW2mW6W2h7ibG4AT6 5JrpGoK8wnI64jYVgpKnlQcXkth5RCKe3bnztzcitkEoihyqPiN5MaSlRB4X5LQkjV vlIGQT6RpjUI1ouzn6pt89RalvhyDri6tqBPdFa25uSkP4gOZwr4vZxUGNogdnRnm0 suOyFAz8RHMJQA9Ct/cpWVLqqueumDGCWhU9BtTcV6cj/fSOHRsNR0gTBVKs4Y9RQx b5GfqpUBu5tUw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , x86@kernel.org, "Rafael J . Wysocki" Subject: [PATCH 4/4] x86: Remove the current_clr_polling() call upon mwait exit Date: Wed, 15 Nov 2023 10:13:25 -0500 Message-ID: <20231115151325.6262-5-frederic@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231115151325.6262-1-frederic@kernel.org> References: <20231115151325.6262-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 07:14:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782643441213348323 X-GMAIL-MSGID: 1782643441213348323 mwait_idle_with_hints() is mostly called from cpuidle which already sets back TIF_NR_POLLING and fold TIF_NEED_RESCHED if necessary. The only non-cpuidle caller is power_saving_thread() which acts as an idle loop and is the only reason why mwait_idle_with_hints() carries a costly fully ordered atomic operation upon idle exit. Make this overhead proper to power_saving_thread() instead which already duplicates quite some cpuidle code. Acked-by: Rafael J. Wysocki Signed-off-by: Frederic Weisbecker --- arch/x86/include/asm/mwait.h | 1 - drivers/acpi/acpi_pad.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/mwait.h b/arch/x86/include/asm/mwait.h index 920426d691ce..c1be3775b94a 100644 --- a/arch/x86/include/asm/mwait.h +++ b/arch/x86/include/asm/mwait.h @@ -134,7 +134,6 @@ static __always_inline void mwait_idle_with_hints(unsigned long eax, unsigned lo } } } - current_clr_polling(); } /* diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index bd1ad07f0290..86b57123713f 100644 --- a/drivers/acpi/acpi_pad.c +++ b/drivers/acpi/acpi_pad.c @@ -175,6 +175,7 @@ static int power_saving_thread(void *data) stop_critical_timings(); mwait_idle_with_hints(power_saving_mwait_eax, 1); + current_clr_polling(); start_critical_timings(); tick_broadcast_exit();