mbox

[GIT,PULL,v1,0/2] KVM: s390: two small but important fixes

Message ID 20231115125111.28217-1-imbrenda@linux.ibm.com
State New
Headers

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-6.7-1

Message

Claudio Imbrenda Nov. 15, 2023, 12:51 p.m. UTC 
  Hi Paolo,

two small but important fixes, please pull :)


Claudio



The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:

  Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-6.7-1

for you to fetch changes up to 27072b8e18a73ffeffb1c140939023915a35134b:

  KVM: s390/mm: Properly reset no-dat (2023-11-14 18:56:46 +0100)

----------------------------------------------------------------
Two small but important bugfixes.

----------------------------------------------------------------
Claudio Imbrenda (2):
      KVM: s390: vsie: fix wrong VIR 37 when MSO is used
      KVM: s390/mm: Properly reset no-dat

 arch/s390/kvm/vsie.c   | 4 ----
 arch/s390/mm/pgtable.c | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Paolo Bonzini Dec. 8, 2023, 6:13 p.m. UTC | #1 
On Wed, Nov 15, 2023 at 1:51 PM Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
>
> Hi Paolo,
>
> two small but important fixes, please pull :)

Done, thanks.

Paolo

>
> Claudio
>
>
>
> The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:
>
>   Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)
>
> are available in the Git repository at:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-master-6.7-1
>
> for you to fetch changes up to 27072b8e18a73ffeffb1c140939023915a35134b:
>
>   KVM: s390/mm: Properly reset no-dat (2023-11-14 18:56:46 +0100)
>
> ----------------------------------------------------------------
> Two small but important bugfixes.
>
> ----------------------------------------------------------------
> Claudio Imbrenda (2):
>       KVM: s390: vsie: fix wrong VIR 37 when MSO is used
>       KVM: s390/mm: Properly reset no-dat
>
>  arch/s390/kvm/vsie.c   | 4 ----
>  arch/s390/mm/pgtable.c | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
>
> --
> 2.41.0
>
Paolo Bonzini Dec. 8, 2023, 9:02 p.m. UTC | #2 
On Fri, Dec 8, 2023 at 7:13 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >       KVM: s390/mm: Properly reset no-dat

A small question on this one, would it make sense to clear _all_
gmap-related bits, including _PGSTE_GPS_ZERO?

Paolo
Claudio Imbrenda Dec. 11, 2023, 10:04 a.m. UTC | #3 
On Fri, 8 Dec 2023 22:02:43 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On Fri, Dec 8, 2023 at 7:13 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >       KVM: s390/mm: Properly reset no-dat  
> 
> A small question on this one, would it make sense to clear _all_
> gmap-related bits, including _PGSTE_GPS_ZERO?

That's a good question, I'll have to think about it.

In general, though, not resetting it will not cause issues in the guest.