From patchwork Wed Nov 15 03:13:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 165161 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:a59:b0:164:83eb:24d7 with SMTP id 25csp2359088rwb; Tue, 14 Nov 2023 19:14:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE05KJI9tLF7SDIcK2Lror+BwulX3+hgQ4ui6bjYkdTC+ijKBW2gotK5r5+v3OOIto0N8sR X-Received: by 2002:a05:6a20:840b:b0:186:de1b:666 with SMTP id c11-20020a056a20840b00b00186de1b0666mr7643260pzd.25.1700018051862; Tue, 14 Nov 2023 19:14:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700018051; cv=none; d=google.com; s=arc-20160816; b=KxM7t6BFkwXFG/vNnt2zU1cQzBk7pU03MOFg59t0XRd4XUFLynqRqmHketxX/Pk0s0 GHqELcBUr51CI6jIplgsrpEMes+71TQRDqYXCiCv0p0gr/RzVegdLG6bnDwZByJe4q5/ 9y2gOc7ItiHUhIKStNRE4CpFhU8mM/RC/KZSAtSj1XBM9XL2F2I0xDdWxL24mwjmTOXw N60wR4Unn5UZZwR122LUz77uOc4HNEt4D+WqVnvpCA/9TzqKZHoSo0vVNcesLMZ875Ko /OWn5o9iuMIWS+vXwBjbJDJCyjUjQ82rpuK+I6tiKc8vLevYX5+EBa5PVSpUDCcBAPql ku8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NErcy/+NkjJG66Pd9ZBjrsXovEkh038xkd31ogtXkEg=; fh=TapvEXZTIZB6cr1I2j4y+MsEQWH4VaZKMFgKGEDdR6A=; b=o9CLup2xeaDMghQxuvJM74/akZSw/lVm6K5wqPhYJDKngpmQcBYDsuRCC+bzzn2/2E UqyAiZ12vYRdlU6+jYqBlM9Qf1R5bhaHU1qWd0Oy0VFU6UKH4FkDYs/RN7oXvuWtwUW8 8nQiDpG2N0yDuxsOmBUC2tw1PN/CJ3bwb8HTLtbSNrSrywlBpDRi+8enhpmvXRfY2sdZ gYrB7SQ78S/ZxYE3lIoQGZPkkWLW+qWnOuqlCG/pjBE/O8Zi4FA4L0HH96kZp3wRInhs 7XGfUhOn6vgEFrWSVulX2KP3bByqZ4qH6eDLBVkSs4No1EVrv/GNBDb0jg9AL6rtjbGt EX5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b12-20020a170902b60c00b001ae40e07fb0si9020632pls.216.2023.11.14.19.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 19:14:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A5B0980CB142; Tue, 14 Nov 2023 19:14:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234330AbjKODNt (ORCPT + 28 others); Tue, 14 Nov 2023 22:13:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjKODNs (ORCPT ); Tue, 14 Nov 2023 22:13:48 -0500 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 500FEA7; Tue, 14 Nov 2023 19:13:44 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VwRJmGm_1700018010; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VwRJmGm_1700018010) by smtp.aliyun-inc.com; Wed, 15 Nov 2023 11:13:41 +0800 From: Jiapeng Chong To: kent.overstreet@linux.dev Cc: bfoster@redhat.com, linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] bcachefs: Remove the unused variable journal_flags Date: Wed, 15 Nov 2023 11:13:29 +0800 Message-Id: <20231115031329.31138-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 14 Nov 2023 19:14:09 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782598128832849331 X-GMAIL-MSGID: 1782598128832849331 Variable journal_flags is not effectively used, so delete it. fs/bcachefs/btree_update_interior.c:1057:11: warning: variable 'journal_flags' set but not used. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7559 Signed-off-by: Jiapeng Chong --- fs/bcachefs/btree_update_interior.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c index 9affcb22d9cb..18e5a75142e9 100644 --- a/fs/bcachefs/btree_update_interior.c +++ b/fs/bcachefs/btree_update_interior.c @@ -1054,7 +1054,6 @@ bch2_btree_update_start(struct btree_trans *trans, struct btree_path *path, unsigned nr_nodes[2] = { 0, 0 }; unsigned update_level = level; enum bch_watermark watermark = flags & BCH_WATERMARK_MASK; - unsigned journal_flags = 0; int ret = 0; u32 restart_count = trans->restart_count; @@ -1068,10 +1067,6 @@ bch2_btree_update_start(struct btree_trans *trans, struct btree_path *path, flags &= ~BCH_WATERMARK_MASK; flags |= watermark; - if (flags & BCH_TRANS_COMMIT_journal_reclaim) - journal_flags |= JOURNAL_RES_GET_NONBLOCK; - journal_flags |= watermark; - while (1) { nr_nodes[!!update_level] += 1 + split; update_level++;