From patchwork Tue Nov 14 22:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 165125 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:a59:b0:164:83eb:24d7 with SMTP id 25csp2255426rwb; Tue, 14 Nov 2023 15:02:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHl4YjJbgNrE7kU0ECQFWP5bBKYQaxB9XKwdtoVX9+dd2pdSnLQa3q7eyQYGlTe+lDyyam0 X-Received: by 2002:a05:6870:f609:b0:1f0:597d:fe25 with SMTP id ek9-20020a056870f60900b001f0597dfe25mr14819201oab.45.1700002921813; Tue, 14 Nov 2023 15:02:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700002921; cv=none; d=google.com; s=arc-20160816; b=RQq0moHA2m8I9b/i84gTaBawy0T85UEA6aIwwOJsbP5Sgvx1oKW6/Em61+iq2Fk9t0 fb/UsNvTRBriEGdINKLfVJczXhd/ebrRpyhe4V6GuumcrND83z+0Sg6uxRJQMCCwyQ7O KkpZ42PIRVNENnKJKlZoTfTByQG1SjfdxG/2jrwtVE2aYVRG/tIWPSJfSUgNVJ98UPOv OP0oLiZPB/JHr580Rk+gmsXk0hgBx/n9mVEh1rrqPaEfB9J/TJ1UZmBZxI+lAWaZuc98 2AFg5VzorG/G6TPppAUCLu41SFhBO8tYV0SqjL7/vbVToiELRQrRAyp8nlbXekDnQGm0 MEhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cpJg20SvqJHFde7hdRwbQhfmXK7eKDJA+6y+igvktAk=; fh=LaCKDShnR+ozrrSQ0mRdij6kZAEWj/Wyvmszaw04AvU=; b=ufRcKBZk1iPXbXw5X1K32oc0NdZi2lvwR4EZ+MEUiSOCz0cFKet107YsKFPqD+3LO4 RiqPzH8cl0JWaVqw5qJsU2o0yhf6GloDYagQYgtG+FAJTEnicZlU/tdX5YNNAT2HJRZw 9TKoxHOhdIMuHMRib8ekMyW1XviaGIg8qnxJ/zn1kMmiSYjlxRu4aHf+s1GOpx0OwQe0 07FchIWTmf5G/Y68inVbV0bfQvQTVrlkPQCpEDcxKrJe/DlLW+rO0F61F/x4u/po50RS elM+82vqa4o50PxaYlY+NXCvls3jyKxM4t/iuXZ6q06ATY+YcDR58AG2V7J2N6CHIsHn nOGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marek.ca header.s=google header.b=CaIrtYL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id zg22-20020a0568716b1600b001e9b54e6380si2803476oab.98.2023.11.14.15.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 15:02:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@marek.ca header.s=google header.b=CaIrtYL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8F98C8036925; Tue, 14 Nov 2023 15:01:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234129AbjKNXAu (ORCPT + 29 others); Tue, 14 Nov 2023 18:00:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234233AbjKNXAm (ORCPT ); Tue, 14 Nov 2023 18:00:42 -0500 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95E1F100 for ; Tue, 14 Nov 2023 15:00:38 -0800 (PST) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5a82f176860so71592837b3.1 for ; Tue, 14 Nov 2023 15:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1700002838; x=1700607638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cpJg20SvqJHFde7hdRwbQhfmXK7eKDJA+6y+igvktAk=; b=CaIrtYL5zP0EobCPzSK6v6WsO7JTWvxsYT2Fk+qkRLqrw8VCSNwwlWuBlhvXZMTRp1 TqAZbUOTuW0OOJvdX5DTGc8ow89MFeXVDCwzfS+z1QqnZhroFynj/pLQfTkjUvTqv/Xl lNXfDC7TbkWDJUYCtrihj7tMBipBRxaAmts6TAtUaspKMyHjkvD2N7G5gH7X+98NliLA tp/yXHHr36EZxroiykF33hgrv25gzDV4cp3qge/d14LASuA/eCq8z32bUbkkjzPMlzpq oSYkENDpt3F3JyDHDbSZlBYSjk2V2GeWmsfumMZUOFNKZibTv7YNaAtgG3iDqbynJ6y0 EKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700002838; x=1700607638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cpJg20SvqJHFde7hdRwbQhfmXK7eKDJA+6y+igvktAk=; b=Vn7YtOzBDZeLBGOJfeP46ILbO8Qn5mWxPLqQw5QuPgeCG0bgnUOG0Hw0IBfENmgmlu W/SjigRAJvurLwZpwKUFup042u7W4PYc+eCPqRp+yimjoQ6vEiheC7US4vqvQkHiuB76 RT2Rw9zrYBNEX0p0ZuBpTSNJM9XEi25lIoGH7p/RO3uf1EPnXHrliuC3haQlSJmeGFNu j64Ue63+WnVzmC9DNDplc2l/4IdyttcPakInHUtyecNsZUqF+q0LTAMkHdTxvK0KfU+V q5/2gQURwu2mvBhRaioD5KYskLipifompfVKnklG3KCz7vjB2lkV/xoxMDGtzWtYDjfS S6Gw== X-Gm-Message-State: AOJu0Yzr5EWPHUTwRM7sQzgIFlTQhkVqTOj3BirsYTdXDgQLP/wiA/ES UWmiZF+JkAJp6HI1aLxgdQWuGQ== X-Received: by 2002:a0d:ca84:0:b0:5a7:bfbf:1bbb with SMTP id m126-20020a0dca84000000b005a7bfbf1bbbmr11185827ywd.17.1700002837716; Tue, 14 Nov 2023 15:00:37 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id u2-20020a05621411a200b00674a45499dcsm25274qvv.88.2023.11.14.15.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 15:00:37 -0800 (PST) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Jessica Zhang , Konrad Dybcio , Jiasheng Jiang , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding Date: Tue, 14 Nov 2023 17:58:32 -0500 Message-Id: <20231114225857.19702-5-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20231114225857.19702-1-jonathan@marek.ca> References: <20231114225857.19702-1-jonathan@marek.ca> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 14 Nov 2023 15:01:49 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782582263793884773 X-GMAIL-MSGID: 1782582263793884773 Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 66f198e21a7e..842765063b1b 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -877,6 +877,8 @@ static void dsi_update_dsc_timing(struct msm_dsi_host *msm_host, bool is_cmd_mod /* DSI_VIDEO_COMPRESSION_MODE & DSI_COMMAND_COMPRESSION_MODE * registers have similar offsets, so for below common code use * DSI_VIDEO_COMPRESSION_MODE_XXXX for setting bits + * + * pkt_per_line is log2 encoded, >>1 works for supported values (1,2,4) */ reg |= DSI_VIDEO_COMPRESSION_MODE_CTRL_PKT_PER_LINE(pkt_per_line >> 1); reg |= DSI_VIDEO_COMPRESSION_MODE_CTRL_EOL_BYTE_NUM(eol_byte_num);