From patchwork Tue Nov 14 22:36:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Karan Tilak Kumar (kartilak)" X-Patchwork-Id: 165116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:a59:b0:164:83eb:24d7 with SMTP id 25csp2245151rwb; Tue, 14 Nov 2023 14:36:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMIiPhLA74gsLtZ/YCac+nZNALf3xIgivb9OaIVWsVTTuCEbVPaId//Hl4bI4j6B50upAw X-Received: by 2002:a17:902:6bc1:b0:1cc:2575:db14 with SMTP id m1-20020a1709026bc100b001cc2575db14mr2951042plt.60.1700001413117; Tue, 14 Nov 2023 14:36:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700001413; cv=none; d=google.com; s=arc-20160816; b=p+HGyyp+h3f+uW0FfaFf9ZTp2r1O/nqz1PoE9DQgSqOG4aJo7oaL1Uc56Yf61lu8G8 h1tnUnqofTfFkJ+SKxBKbVAGfuAorHUEyFb1kZEnksql+Zivkm9hII1vrorz63Pl8R3U AkQmbSQJUFlWcuCJcMhgzz26kmthft3SpBCSQB2uMhSUDYIP3DGo49qJb06C1VLINhDE TDnyVF8GPCvp7ENV26Xl296HLBKz/d9ZU6v4MJpLxCrY/Gw5/AAwEIUOAZGqdtE3hFgd kZYp2cbS29D+4QUoQiTrCLlZntRLrCF08eaIYDpiuu/OEjWNsXAQKd1+J2AJG3aKP32n WPcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ov+22JfMWX71JUrjb9pbSfvsIvqm6DfNrkyUATv3g3I=; fh=cjiSjcSDv/XIT1wsutvtplR3SRaqRNwT1M35P++mOs8=; b=hnj09D7xlx5kmDMprUdQ3UrCj8JOzx1/FOqUK6vvlIOxr5EWSMXgQ3F7bLa0IjARJT 0p7avUpoU+X+UCqkZle0tx7e1HuFygz80g9yUN7hJ4Zh2RtbHU0SFDEQWBTogaUt/xjN xdFQdvu0q7WbxiQGPoqBKbbPW99tJML2MKpEdA7gR1aXqdgfDhsCGtrYBWGaW3B0Zw2l 0TY4rS1UVlCb+ZKcdnGWo3pq3DExeqh8s9/VmP876YxX6MKWlwtMUSUDfxvK7slsk2lV 593EpXcGM4a/KZtr9p/yD9Brttj0s41y7i3nQPzGLrIW4e6zTAgOpXKNP7LgbzbCpvGO 5GvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cisco.com header.s=iport header.b=Rh9vIHHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=cisco.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b23-20020a170902d89700b001bdcd2e1706si8462163plz.196.2023.11.14.14.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 14:36:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@cisco.com header.s=iport header.b=Rh9vIHHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=cisco.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8AAB180784E9; Tue, 14 Nov 2023 14:36:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234170AbjKNWgg (ORCPT + 29 others); Tue, 14 Nov 2023 17:36:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234107AbjKNWge (ORCPT ); Tue, 14 Nov 2023 17:36:34 -0500 Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E302AC1; Tue, 14 Nov 2023 14:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2379; q=dns/txt; s=iport; t=1700001392; x=1701210992; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=aqgGUKGQBVUTfW7p4uxQ1YKLQ3kFd6K4NBe7f3cePAw=; b=Rh9vIHHvrIji3iJVqIu3+/ZNccCtYDu9409896kgeSsMLoJ9/MEEHqKT FIQaVqRtV0+uv7kvLKBl2BufEvX+45MzRXVQ2aISadM7Kk9P1kQNdQeXI fxjLIL5yE9lpb4B9uZBG0ubd2cLCHksq4F0nQ4Bfe7k9EyBT8UrdVuaMv k=; X-CSE-ConnectionGUID: FSC3dlcaT7uxAwB0SlVC6A== X-CSE-MsgGUID: qatHh0ujToOl2Cnj45dALQ== X-IronPort-AV: E=Sophos;i="6.03,303,1694736000"; d="scan'208";a="139025490" Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by rcdn-iport-3.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 22:36:31 +0000 Received: from localhost.cisco.com ([10.193.101.253]) (authenticated bits=0) by rcdn-core-8.cisco.com (8.15.2/8.15.2) with ESMTPSA id 3AEMaNhm028773 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 14 Nov 2023 22:36:30 GMT From: Karan Tilak Kumar To: sebaddel@cisco.com Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Karan Tilak Kumar , Hannes Reinecke Subject: [PATCH v3 08/13] scsi: fnic: Define stats to track multiqueue (MQ) IOs Date: Tue, 14 Nov 2023 14:36:21 -0800 Message-Id: <20231114223621.634071-1-kartilak@cisco.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Authenticated-User: kartilak@cisco.com X-Outbound-SMTP-Client: 10.193.101.253, [10.193.101.253] X-Outbound-Node: rcdn-core-8.cisco.com X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 14 Nov 2023 14:36:50 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782580681717647949 X-GMAIL-MSGID: 1782580681717647949 Define an array to track IOs for the different queues, print the IO stats in fnic get stats data. Reviewed-by: Sesidhar Baddela Reviewed-by: Arulprabhu Ponnusamy Reviewed-by: Hannes Reinecke Signed-off-by: Karan Tilak Kumar --- drivers/scsi/fnic/fnic_stats.h | 2 ++ drivers/scsi/fnic/fnic_trace.c | 11 +++++++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/scsi/fnic/fnic_stats.h b/drivers/scsi/fnic/fnic_stats.h index 07d1556e3c32..9d7f98c452dd 100644 --- a/drivers/scsi/fnic/fnic_stats.h +++ b/drivers/scsi/fnic/fnic_stats.h @@ -2,6 +2,7 @@ /* Copyright 2013 Cisco Systems, Inc. All rights reserved. */ #ifndef _FNIC_STATS_H_ #define _FNIC_STATS_H_ +#define FNIC_MQ_MAX_QUEUES 64 struct stats_timestamps { struct timespec64 last_reset_time; @@ -26,6 +27,7 @@ struct io_path_stats { atomic64_t io_btw_10000_to_30000_msec; atomic64_t io_greater_than_30000_msec; atomic64_t current_max_io_time; + atomic64_t ios[FNIC_MQ_MAX_QUEUES]; }; struct abort_stats { diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c index be0d7c57b242..aaa4ea02fb7c 100644 --- a/drivers/scsi/fnic/fnic_trace.c +++ b/drivers/scsi/fnic/fnic_trace.c @@ -204,6 +204,7 @@ int fnic_get_stats_data(struct stats_debug_info *debug, int len = 0; int buf_size = debug->buf_size; struct timespec64 val1, val2; + int i = 0; ktime_get_real_ts64(&val1); len = scnprintf(debug->debug_buffer + len, buf_size - len, @@ -266,6 +267,16 @@ int fnic_get_stats_data(struct stats_debug_info *debug, (u64)atomic64_read(&stats->io_stats.io_btw_10000_to_30000_msec), (u64)atomic64_read(&stats->io_stats.io_greater_than_30000_msec)); + len += scnprintf(debug->debug_buffer + len, buf_size - len, + "------------------------------------------\n" + "\t\tIO Queues and cumulative IOs\n" + "------------------------------------------\n"); + + for (i = 0; i < FNIC_MQ_MAX_QUEUES; i++) { + len += scnprintf(debug->debug_buffer + len, buf_size - len, + "Q:%d -> %lld\n", i, (u64)atomic64_read(&stats->io_stats.ios[i])); + } + len += scnprintf(debug->debug_buffer + len, buf_size - len, "\nCurrent Max IO time : %lld\n", (u64)atomic64_read(&stats->io_stats.current_max_io_time));