From patchwork Mon Nov 13 22:03:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 164651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1501696vqg; Mon, 13 Nov 2023 14:03:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4dSHwn6I5kIvFWlKa1+vwTs+ePSRXKLG4V3EZaf+sN4pEm2h4O0qt3hklgcWjA6BKC230 X-Received: by 2002:a17:902:aa01:b0:1cc:6b5a:a2f1 with SMTP id be1-20020a170902aa0100b001cc6b5aa2f1mr584956plb.8.1699913033466; Mon, 13 Nov 2023 14:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699913033; cv=none; d=google.com; s=arc-20160816; b=SEDC35Lb/pWpFeF++wRj33C1I/HyvU/rs/0TwfdI8llipZn5zE7UzUYUXYpkTiDfX9 ciNxHOGlUxYzknfyK6WXPnaYtsXBFFac+9IFpaDFZaCysXVIXaQBtmerq7uHOxLIXpE3 aBgFJ2Eqzxmh5naaIJhzGsV6jqnWfVFytLDw+WnOoS/6kebKPYuVI4fneW4T+cyod0AY nLolxvfRH5yFX8Tekg8h0fhohp/6iJ80CEBri8m4fPea1nTQ2fkdAyqLQ3aiR+x3WZvj fVKqMYvDrt4yv54HymuL7fsE6Y84KfkyYn34iwNQljyKghMNbtJJW+JaeEIW/bmbYlN0 I2cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9wHt1y4ejnJd921KjVYe9hFRIgH414oH2HmYV9sXAfY=; fh=SyYJqaqpG9SrnmjTM3P4C7jfH9YuT/5katwtyDmp4cw=; b=wXudn5+6ZuyqMS0omt0haKqmoHJC8WHxdpx3eL5y+sJLGJ2HIyzLibsr0a5M58bDpz OMrROuDAGp26FH2eBlyr252Xl59ArqdNFDNg4aJzPX64JyRMk1Im66uox+1ZmhpPE+b9 eYkql7Y82RZtJCv3I/1+hL+VF02sSPZq+ByGtcCx2Zp0CQZ2Deyq80bV4VLUUNwmhfhI Fyoq3cW2QPidmqhysJiOzigKazT8utE9/JX+mQgDPr4IcR89ZoF6vybO6yYCHr2Kqaxr x2R5fwBlL8jEk1UeDlh5dRI03Rn2tEkbSOOvEovkAkqoUCySNADkpmdO9UxiokguILT4 o5ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PnuG9IvL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id p4-20020a170902e74400b001ca81fa0661si6671817plf.508.2023.11.13.14.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 14:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PnuG9IvL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4393480560F8; Mon, 13 Nov 2023 14:03:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbjKMWDk (ORCPT + 30 others); Mon, 13 Nov 2023 17:03:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjKMWDg (ORCPT ); Mon, 13 Nov 2023 17:03:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD0FBD6C; Mon, 13 Nov 2023 14:03:33 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFD99C433C7; Mon, 13 Nov 2023 22:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699913013; bh=eoPOFwQKBI5DH/2gslFAWw1LIbFtVuvG1rrdOcMjkuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PnuG9IvL/cfjbq3+PKfG7YJgkpJMoQAeklUwZqrQWAv65hjHYmSrUDQ9Cxn3aNMg8 zqrgtWB06wlWD7xEWqtP4YvcMu4YRw09MnCVwFjt6PE1BqCZ5sWgdmiqibDddNK3ep qXvxMTjomFmYW5/+KmVLm8/kd3LH+dWSJjtVulnzAtrTz8ZOvZ288auFM/3j6m4Y3H C7zJYHi4o1p5kGpgMr+JoE/BJhVs+e3hzg7XhVjK4LAhugdF4RNmivre6lQlu7dw83 vFlvlYeLAEkPuKl0PxcjkLcfGQPN4H5nm8y3j4QvuH1D2Hfq1jGyTnIm1q1lv80i+v +O29HMB2R/bVg== From: Frederic Weisbecker To: "Rafael J . Wysocki" Cc: LKML , Frederic Weisbecker , Daniel Lezcano , linux-pm@vger.kernel.org Subject: [PATCH 2/2] cpuidle: Remove unnecessary current_clr_polling() on poll_idle() Date: Mon, 13 Nov 2023 17:03:26 -0500 Message-ID: <20231113220326.7933-3-frederic@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113220326.7933-1-frederic@kernel.org> References: <20231113220326.7933-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 13 Nov 2023 14:03:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782488009026938025 X-GMAIL-MSGID: 1782488009026938025 There is no point in clearing TIF_NR_POLLING and folding TIF_NEED_RESCHED upon poll_idle() exit because cpuidle_idle_call() is going to set again TIF_NR_POLLING anyway. Also if TIF_NEED_RESCHED is set, it will be folded and TIF_NR_POLLING will be cleared at the end of do_idle(). Acked-by: Rafael J. Wysocki Signed-off-by: Frederic Weisbecker --- drivers/cpuidle/poll_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpuidle/poll_state.c b/drivers/cpuidle/poll_state.c index 9b6d90a72601..d5cb3eb85a54 100644 --- a/drivers/cpuidle/poll_state.c +++ b/drivers/cpuidle/poll_state.c @@ -40,8 +40,6 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev, } raw_local_irq_disable(); - current_clr_polling(); - return index; }