From patchwork Mon Nov 13 20:07:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Harshit Mogalapalli X-Patchwork-Id: 164636 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1447797vqg; Mon, 13 Nov 2023 12:09:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWlFBy1yJ90JBYHZEN789ul7qGKu0bpjyg+2tWv+VHiTkxdD71G+A9izphRhfw3deKQXpA X-Received: by 2002:a05:6830:344c:b0:6d6:4d8f:56d6 with SMTP id b12-20020a056830344c00b006d64d8f56d6mr184222otu.13.1699906144443; Mon, 13 Nov 2023 12:09:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699906144; cv=none; d=google.com; s=arc-20160816; b=BLkuxIhgIIBAbeW9NSb92ixs+SHfzuvUR63+ivfjNuk00eEi2cqTXAWf0mrUKjR9By RIq6SZXhIw/kBBAb1D7A11cefcxjxa/IKYbUx7n74oRtUpkdd7TdH58UZ0LiNHYURPiP QBAwGPOt9PYOUtKOuqt6NM/fvdOUAOgnYktRBllMni4a1xYG+p6C7ycEzRwxGqvdlcvb RFiEK4LT9rC+Fn8LdYbN6YY6BuRrs/s3uGM6WqKZarRRQcq//DqBOzliOcWBTalMWZVg jL/O7o47Qt0hGlaZuJclEJmsRprkmNZfOCCUzvxye4ZEIWdxX3H9vSya6Hxx5v+k7qQJ opgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XDtSBsTn2b+kLXz7T7QRWj63RVMlaoXCIevLvCLxJ70=; fh=Q5UJK/+TFmcTguj5mfgprzb0aHnD1zW+bK3PDJulktc=; b=uAQw2pe1cOrRKiUC60eAzThhCQp06LzCMvJ3P/oDDeeXfULWQkGtq894Vn6BagXWsA Mt2q3fK7hkJLORxINRgJyChPAvz7R8+/POuPIH3Rpmnor83PXnlA4OF6d/Ae7EBchYE4 GOwQH0Oy3+MnwOP5zqZb58GNBB9+gK45+X329s9ReY+F8iEiDKExvEtzG9um2pCaRYAW wVuA4f+BwhdMUCmimimSqPU2lHbWxREHBmDzZxBWMF9Uner7F/SKkXQzRPAOZ1JEgX14 FWK60cJTXjjNPmex1b4AvaaZw51nOS6Y2AyfPl6W7oW9le68mj9nzvBrPqZVElb6ayRS QcVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=LJdy6XDI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id i62-20020a638741000000b005ab7b51ab6csi6058909pge.515.2023.11.13.12.09.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 12:09:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=LJdy6XDI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A5A8680AD517; Mon, 13 Nov 2023 12:09:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231860AbjKMUIh (ORCPT + 30 others); Mon, 13 Nov 2023 15:08:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbjKMUIf (ORCPT ); Mon, 13 Nov 2023 15:08:35 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591A1D73; Mon, 13 Nov 2023 12:08:32 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADHiQqF005408; Mon, 13 Nov 2023 20:08:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-03-30; bh=XDtSBsTn2b+kLXz7T7QRWj63RVMlaoXCIevLvCLxJ70=; b=LJdy6XDIxi9TQ4h7uls8OEJ8nZkTlBTV0t8QxzSz0UWVUdzi+ePBs3mC2qgZbHgtK3tv Kee3+NCOD1hLXE73bNBY7qEz69/YXnJOv1sUFS4KpyYwJZCHteDSbysgEGqKi1M6DhYH 2aR6c3vfNKAZ3PO1Ma42wXwlaQdd5QjIBfUIA4OcXzLacNRfZ6gpdPrdMFKLBys4qUzp ERtra5gwVg9+IGtD8zvtez9N9eRnF9Juvmes1wEBmcDHfnoi8Fy3J7or9OsewsT4vfNY 3SLHdaHRHyyz33p+vPWFlLhP5uZg+34r8CaOzjr4LXvXxnxFCE58/+C0+t45jvMuJVqQ Wg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2n3bmf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 20:08:24 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADJBbRj029773; Mon, 13 Nov 2023 20:08:22 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uaxqqe9h3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 20:08:22 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ADK7jMb026381; Mon, 13 Nov 2023 20:08:19 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uaxqqe8vg-4; Mon, 13 Nov 2023 20:08:19 +0000 From: Harshit Mogalapalli To: Jorge Lopez , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, error27@gmail.com, vegard.nossum@oracle.com, harshit.m.mogalapalli@oracle.com Subject: [PATCH v4 4/4] platform/x86: hp-bioscfg: Remove unused obj in hp_add_other_attributes() Date: Mon, 13 Nov 2023 12:07:40 -0800 Message-ID: <20231113200742.3593548-4-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com> References: <20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-13_11,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311130160 X-Proofpoint-GUID: tTpdJjZZ50TmSNtiiGd8B6eNI1NPnQc0 X-Proofpoint-ORIG-GUID: tTpdJjZZ50TmSNtiiGd8B6eNI1NPnQc0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 13 Nov 2023 12:09:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782480785379169942 X-GMAIL-MSGID: 1782480785379169942 acpi_object *obj is unused in this function, so delete it, also delete a unnecessary kfree(obj); Signed-off-by: Harshit Mogalapalli Reviewed-by: Ilpo Järvinen --- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c index 6ddca857cc4d..8c9f4f3227fc 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -575,80 +575,78 @@ static void release_attributes_data(void) /** * hp_add_other_attributes() - Initialize HP custom attributes not * reported by BIOS and required to support Secure Platform and Sure * Start. * * @attr_type: Custom HP attribute not reported by BIOS * * Initialize all 2 types of attributes: Platform and Sure Start * object. Populates each attribute types respective properties * under sysfs files. * * Returns zero(0) if successful. Otherwise, a negative value. */ static int hp_add_other_attributes(int attr_type) { struct kobject *attr_name_kobj; - union acpi_object *obj = NULL; int ret; char *attr_name; attr_name_kobj = kzalloc(sizeof(*attr_name_kobj), GFP_KERNEL); if (!attr_name_kobj) return -ENOMEM; mutex_lock(&bioscfg_drv.mutex); /* Check if attribute type is supported */ switch (attr_type) { case HPWMI_SECURE_PLATFORM_TYPE: attr_name_kobj->kset = bioscfg_drv.authentication_dir_kset; attr_name = SPM_STR; break; case HPWMI_SURE_START_TYPE: attr_name_kobj->kset = bioscfg_drv.main_dir_kset; attr_name = SURE_START_STR; break; default: pr_err("Error: Unknown attr_type: %d\n", attr_type); ret = -EINVAL; kfree(attr_name_kobj); goto unlock_drv_mutex; } ret = kobject_init_and_add(attr_name_kobj, &attr_name_ktype, NULL, "%s", attr_name); if (ret) { pr_err("Error encountered [%d]\n", ret); goto err_other_attr_init; } /* Populate attribute data */ switch (attr_type) { case HPWMI_SECURE_PLATFORM_TYPE: ret = hp_populate_secure_platform_data(attr_name_kobj); break; case HPWMI_SURE_START_TYPE: ret = hp_populate_sure_start_data(attr_name_kobj); break; default: ret = -EINVAL; } if (ret) goto err_other_attr_init; mutex_unlock(&bioscfg_drv.mutex); return 0; err_other_attr_init: kobject_put(attr_name_kobj); unlock_drv_mutex: mutex_unlock(&bioscfg_drv.mutex); - kfree(obj); return ret; }