From patchwork Mon Nov 13 20:07:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Harshit Mogalapalli X-Patchwork-Id: 164634 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1447537vqg; Mon, 13 Nov 2023 12:08:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8SQd/8PyLutxxmL00mwzrPounJNwg5C9w+GQRurTrifuP+8j+2X/IBCoCRsuEj7XozieG X-Received: by 2002:a05:6a21:339e:b0:171:a8bc:74b2 with SMTP id yy30-20020a056a21339e00b00171a8bc74b2mr6308782pzb.7.1699906116031; Mon, 13 Nov 2023 12:08:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699906116; cv=none; d=google.com; s=arc-20160816; b=mOZl4Jy8ydeGwVZYASarJtPiANY73DwUhVJ+3KXAHwHPx0+n6WWsENw0Hoqk7JTVps Ox0vNawbLIz+d6Y/esdB9HhRRPx5yCBVmAta6G/h02Yf7xerjdqoEkZ8DZM4RODNL4Ir JZJS827CZibzDxj8egFFwniYX4K20K8nvbAJAsmUYSWikoBMIuWwBF62pVF0d3YAQE76 eCNP5V50OWPB+5Ly9j6jYkUaxY6mHHW8Ikx0ZuO+vBRmAVIgR9v0ekkNC2226k56Gvej dbjiXD+G5iWZbyyAkEzkoSa9XGYlrbjpOqWPN4k90PF9+tP1sYTFAWVyeKQcIrym0PNW spJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wRDNb5kwLbA9iZoe1kAxP+fQShQcH6es5bJIqUJvS3g=; fh=4fC3GxYxlzhBI33i5mhF9WKoN5XVaECBiUz/s3aJGuk=; b=CL7AGtH975UrfVEYE5wpvoXBp4aD/avHGM/1SylkSu2Rk9hMnQtHZyAvFi1pxSjo5Y ZTlQE2sj0lkUA84is0mBVVOcCsSk/N5k3XXu6KesDkNmZ16T6lb8HqVGVRAcDSp6NOQr Us1EzobWD09nOG9gYyIpSyNKEjtpCAA5/8uP7zz4YdmV1Uah+3SV28+WGZ+jY02T6mVB 8jvKXXkwHLGTKFKUy/BiFv5goFjCBl/gRJMIsPysvN2MYZ6ctUqKFzc0QuXdtRrBY8RD IvbT5xt7S4FTr876WD6YdJpJ7Bc4CxMNRohaaUOdfPwDoUGexzYhmxm7NsdEGr2A0S6R a6og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=KhsOWGOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id w6-20020a056a0014c600b006be322191e1si6772189pfu.254.2023.11.13.12.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 12:08:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=KhsOWGOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7D2F3805F3C5; Mon, 13 Nov 2023 12:08:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbjKMUIP (ORCPT + 30 others); Mon, 13 Nov 2023 15:08:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231787AbjKMUIM (ORCPT ); Mon, 13 Nov 2023 15:08:12 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0C3C10F4; Mon, 13 Nov 2023 12:08:05 -0800 (PST) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADHipwW019571; Mon, 13 Nov 2023 20:07:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2023-03-30; bh=wRDNb5kwLbA9iZoe1kAxP+fQShQcH6es5bJIqUJvS3g=; b=KhsOWGOjCaym6P4itiKotXonHl2TFZkKcYBWtXFg+NYW0OZOkAM+D87j9NJOSaniuARK Mf78OshxIUXjCCiX7nQfx3eusV5/UFeuBCQLhJ+0vwFMBIzKk0M17oqop1LPZnF1RvwK bOSPCp6kaG99Im3KYz2WgoudUqAv5vX8BmVh3NzkBs2jjFMdqhi7Zhp70azZwGazKpBj f86j9fmyQIqtXFUP/n93dxC75qBWdhJDyVszZsBI2xu3bFrYBgqz14mbx6y1o4ZrAxZy jDbfyp4WQa3V3K3YA2oj42XOG6qsCyr3FnKE7vThNyu4H+cNr/9DD0zuuCxebjTetfmr rA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2m2bn40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 20:07:53 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADIs0QQ029926; Mon, 13 Nov 2023 20:07:52 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uaxqqe90n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 20:07:52 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ADK7jMZ026381; Mon, 13 Nov 2023 20:07:51 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uaxqqe8vg-3; Mon, 13 Nov 2023 20:07:51 +0000 From: Harshit Mogalapalli To: Jorge Lopez , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, error27@gmail.com, vegard.nossum@oracle.com, harshit.m.mogalapalli@oracle.com, kernel test robot Subject: [PATCH v4 3/4] platform/x86: hp-bioscfg: Fix error handling in hp_add_other_attributes() Date: Mon, 13 Nov 2023 12:07:39 -0800 Message-ID: <20231113200742.3593548-3-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com> References: <20231113200742.3593548-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-13_11,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311130159 X-Proofpoint-GUID: 8vncgvzQNdwgDn8i-l236l5OQyNMstFQ X-Proofpoint-ORIG-GUID: 8vncgvzQNdwgDn8i-l236l5OQyNMstFQ X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 13 Nov 2023 12:08:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782480755329034021 X-GMAIL-MSGID: 1782480755329034021 'attr_name_kobj' is allocated using kzalloc, but on all the error paths it is not freed, hence we have a memory leak. Fix the error path before kobject_init_and_add() by adding kfree(). kobject_put() must be always called after passing the object to kobject_init_and_add(). Only the error path which is immediately next to kobject_init_and_add() calls kobject_put() and not any other error path after it. Fix the error handling after kobject_init_and_add() by moving the kobject_put() into the goto label err_other_attr_init that is already used by all the error paths after kobject_init_and_add(). Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202309201412.on0VXJGo-lkp@intel.com/ Signed-off-by: Harshit Mogalapalli Reviewed-by: Ilpo Järvinen --- This is based on static analysis, only compile tested. v3->v4: Add more explicit statement on how we are fixing it, suggested by Ilpo --- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c index a3599498c4e8..6ddca857cc4d 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -575,77 +575,79 @@ static void release_attributes_data(void) /** * hp_add_other_attributes() - Initialize HP custom attributes not * reported by BIOS and required to support Secure Platform and Sure * Start. * * @attr_type: Custom HP attribute not reported by BIOS * * Initialize all 2 types of attributes: Platform and Sure Start * object. Populates each attribute types respective properties * under sysfs files. * * Returns zero(0) if successful. Otherwise, a negative value. */ static int hp_add_other_attributes(int attr_type) { struct kobject *attr_name_kobj; union acpi_object *obj = NULL; int ret; char *attr_name; attr_name_kobj = kzalloc(sizeof(*attr_name_kobj), GFP_KERNEL); if (!attr_name_kobj) return -ENOMEM; mutex_lock(&bioscfg_drv.mutex); /* Check if attribute type is supported */ switch (attr_type) { case HPWMI_SECURE_PLATFORM_TYPE: attr_name_kobj->kset = bioscfg_drv.authentication_dir_kset; attr_name = SPM_STR; break; case HPWMI_SURE_START_TYPE: attr_name_kobj->kset = bioscfg_drv.main_dir_kset; attr_name = SURE_START_STR; break; default: pr_err("Error: Unknown attr_type: %d\n", attr_type); ret = -EINVAL; - goto err_other_attr_init; + kfree(attr_name_kobj); + goto unlock_drv_mutex; } ret = kobject_init_and_add(attr_name_kobj, &attr_name_ktype, NULL, "%s", attr_name); if (ret) { pr_err("Error encountered [%d]\n", ret); - kobject_put(attr_name_kobj); goto err_other_attr_init; } /* Populate attribute data */ switch (attr_type) { case HPWMI_SECURE_PLATFORM_TYPE: ret = hp_populate_secure_platform_data(attr_name_kobj); break; case HPWMI_SURE_START_TYPE: ret = hp_populate_sure_start_data(attr_name_kobj); break; default: ret = -EINVAL; } if (ret) goto err_other_attr_init; mutex_unlock(&bioscfg_drv.mutex); return 0; err_other_attr_init: + kobject_put(attr_name_kobj); +unlock_drv_mutex: mutex_unlock(&bioscfg_drv.mutex); kfree(obj); return ret; }