Message ID | 20231112184403.3449-3-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp819946vqg; Sun, 12 Nov 2023 10:44:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSkWMQXriJG8pbO3Nmr50+qlYxw0oEYHJNeJiR2sv36juLVeEfN1P7dhjf8ugYK7MS7Jdh X-Received: by 2002:a25:2d1f:0:b0:d7f:af26:2c7e with SMTP id t31-20020a252d1f000000b00d7faf262c7emr4045182ybt.20.1699814664900; Sun, 12 Nov 2023 10:44:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699814664; cv=none; d=google.com; s=arc-20160816; b=nzMDOv4aSHsqfu1rfEWBZiVeM/nDN7XGAyEgLZKsbzoLeHKswoD75MO+bbMIRNLnXI 1PgrsaGgLIyrKiyJLu29wc4/RuU1/KZ4ogrMVYh4RRioenDpBWbz+u0L+h5AGWsTP3i6 cGzbl85ycHHMhckhyyTnNWAWg6kXU4gaedEpmoy4CqHJHEWCKFnA5lnj0qVqlOFpmhyr 2WCb0NzzoSDHKFMxBtVIyaWpwnmJieNEGovbf3crkzmxyr0cBQFH48kCVg8SdF6ewqlD gBUbnbnRy6qAM3f3MwNVm4WjQ1/vjAnu3fYEGhyvk+ppdnQcm4kMfAvs1kbet6A/957W 1muA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LKapjGZo46m2u3Pg+KgGkylJklW8QTl7gfgNZK8ZJCY=; fh=/eZdsLKDAbV7BjxDNEAr94270BA8RfqVUBuOgfNvL10=; b=n2zCndqnpoPV2HBFsi7KOyEM62qgaKwXxW+IRryIHijeNaBaZ8GvnU7MI07xGXlOpe 7UacUufW/kqXHhGjom8dOMTEaPFcUwytOsm2pHEofz9Nimu9If99fIT1beuXkN+10PyY KTzC0JC2iiT1hWbmSIu5besAO8Ll0ePEk4LAsvwYtMPDUXXWn0o+QCK2m/Qsw9nOHx/j HwZnaRtuo3JVT2TlZWjltYUTrN/e8elI8IW6mPKsKn4/U2bbA4DMV/0IHQw5Ki/1/I2S tTKysDkn3wrIi+bIJiPXV7d0OtKvF+C+Wca2QTgRyHlRn/sxFvCCgAMg4OZ2JrHUbtLv 6kOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iw0kFUuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t35-20020a056a0013a300b006bd7cfa8497si4283073pfg.83.2023.11.12.10.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 10:44:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iw0kFUuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 07A298050D3D; Sun, 12 Nov 2023 10:44:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbjKLSoR (ORCPT <rfc822;lhua1029@gmail.com> + 30 others); Sun, 12 Nov 2023 13:44:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbjKLSoQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Nov 2023 13:44:16 -0500 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8BC273E for <linux-kernel@vger.kernel.org>; Sun, 12 Nov 2023 10:44:13 -0800 (PST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-5bf58204b7aso38447157b3.3 for <linux-kernel@vger.kernel.org>; Sun, 12 Nov 2023 10:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699814653; x=1700419453; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LKapjGZo46m2u3Pg+KgGkylJklW8QTl7gfgNZK8ZJCY=; b=iw0kFUuRxQS4MRdP9ZPJzS7oPkfkXebd7c3njWsPui62lFi9tOfKXScs9zrlWtyZke 7Jjc8kGfU+f64JD0OYZCI1omZqi9njEXxR740nn4JJzH/eZiaSfCNdKUBD8f4rdS4gYe EKoch+HpXgXPOyKP6E2gd+3uyLdzti8z8XACNYyHq6L781CWAslb0/Cq8DtkFNC3E7A7 FyZ66B8dO0eri9nfL5KYHQZz3r+dx6KxpMQSAfVJs9BWzQXBgRGcsQjgCdGuW7oD7rPU ojtYcCugoS5kp/dVJ41ajgLFRVxoQBg4yCV03ckCIZTUPQjDxUz++GTn3yssESJmKRdI LtJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699814653; x=1700419453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LKapjGZo46m2u3Pg+KgGkylJklW8QTl7gfgNZK8ZJCY=; b=S0iCcCm9uBA6zMavbWknHON68ABusaKRqmSwUTvS3DN70Ty6y+x+2AozmUzPmICQPb +u3DB/c0fk4twfuF1vtBYyoqtDRQJ372PIaKd9AoyurqgrFSnrjEt2YEFYOqE5Swgji9 76nmAD97Yg7lYZEoIU1qDbN11UhPdz9Jlb2wyNxfGRPGRpguqEvVntXuNPox6MEZsxYb 6V5H8Kdb2WYzwmJcFJ0qawpIhPtG8pwhAT02eOumRORV6BAP7FERss77YLCdozBMM+7O qfCMyQ9SfsPTJLL49iA4HN7Fby1Jg4pEL1I84phZttWkoncB2eAljv/c6IOINZlIKTDN p3yw== X-Gm-Message-State: AOJu0Yzqs1hXAaRrIdkgbeyQB1fnbEqrWRJckqtQ7mKIa7OGI5UGIcdd HSPEf5C2cegh+4RPaS8mkr7NLg== X-Received: by 2002:a0d:ca8f:0:b0:5a7:ba54:af02 with SMTP id m137-20020a0dca8f000000b005a7ba54af02mr5340230ywd.38.1699814652746; Sun, 12 Nov 2023 10:44:12 -0800 (PST) Received: from krzk-bin.. ([12.161.6.170]) by smtp.gmail.com with ESMTPSA id u63-20020a0deb42000000b005b3f6c1b5edsm1308938ywe.80.2023.11.12.10.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 10:44:12 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Inki Dae <inki.dae@samsung.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Date: Sun, 12 Nov 2023 19:44:01 +0100 Message-Id: <20231112184403.3449-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231112184403.3449-1-krzysztof.kozlowski@linaro.org> References: <20231112184403.3449-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 12 Nov 2023 10:44:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782384862274315867 X-GMAIL-MSGID: 1782384862274315867 |
Series |
[1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
|
|
Commit Message
Krzysztof Kozlowski
Nov. 12, 2023, 6:44 p.m. UTC
When number of clock varies between variants, the Devicetree bindings
coding convention expects to have widest constraints in top-level
definition of the properties and narrow them in allOf:if:then block.
This is more readable and sometimes allows to spot some errors in the
bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/gpu/samsung-g2d.yaml | 10 ++++++++--
.../devicetree/bindings/gpu/samsung-scaler.yaml | 10 ++++++++--
2 files changed, 16 insertions(+), 4 deletions(-)
Comments
On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: > When number of clock varies between variants, the Devicetree bindings > coding convention expects to have widest constraints in top-level > definition of the properties and narrow them in allOf:if:then block. > > This is more readable and sometimes allows to spot some errors in the > bindings. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote: > On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: > > When number of clock varies between variants, the Devicetree bindings > > coding convention expects to have widest constraints in top-level > > definition of the properties and narrow them in allOf:if:then block. > > > > This is more readable and sometimes allows to spot some errors in the > > bindings. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Åcked-by: Conor Dooley <conor.dooley@microchip.com> ^ Not an 'A'. I only caught this because I go thru everything Acked/Reviewed-by first and this one was missed. Rob
On 16/11/2023 17:28, Rob Herring wrote: > On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote: >> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: >>> When number of clock varies between variants, the Devicetree bindings >>> coding convention expects to have widest constraints in top-level >>> definition of the properties and narrow them in allOf:if:then block. >>> >>> This is more readable and sometimes allows to spot some errors in the >>> bindings. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> >> Åcked-by: Conor Dooley <conor.dooley@microchip.com> > > ^ > > Not an 'A'. I only caught this because I go thru everything > Acked/Reviewed-by first and this one was missed. And in Norwegian it is pronounced as "o", so this would be ocked-by :) Best regards, Krzysztof
On Thu, Nov 16, 2023 at 06:17:31PM +0100, Krzysztof Kozlowski wrote: > On 16/11/2023 17:28, Rob Herring wrote: > > On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote: > >> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: > >>> When number of clock varies between variants, the Devicetree bindings > >>> coding convention expects to have widest constraints in top-level > >>> definition of the properties and narrow them in allOf:if:then block. > >>> > >>> This is more readable and sometimes allows to spot some errors in the > >>> bindings. > >>> > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> > >> Åcked-by: Conor Dooley <conor.dooley@microchip.com> > > > > ^ > > > > Not an 'A'. I only caught this because I go thru everything > > Acked/Reviewed-by first and this one was missed. > > And in Norwegian it is pronounced as "o", so this would be ocked-by :) What on earth! The fedora install on this macbook I've been travelling with does some odd things (clearly there's some setting I need to disable) if I type something incorrectly and hit a backspace, but I use a vim keybind to "type" my acks etc, so I am not sure that could have been affected. FWIW, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml index b6951acc7643..f368966cf83a 100644 --- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml @@ -22,8 +22,14 @@ properties: interrupts: maxItems: 1 - clocks: {} - clock-names: {} + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + maxItems: 2 + iommus: {} power-domains: {} diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml index 97d86a002a90..e08fc1e4115f 100644 --- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml +++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml @@ -21,8 +21,14 @@ properties: interrupts: maxItems: 1 - clocks: {} - clock-names: {} + clocks: + minItems: 1 + maxItems: 3 + + clock-names: + minItems: 1 + maxItems: 3 + iommus: {} power-domains: {}