From patchwork Sat Nov 11 20:26:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 164161 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp407230vqg; Sat, 11 Nov 2023 12:27:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWqr0WlUjyU6ILa53WLYOhcdYg76SOpYC0SY5vAC/5oSRWd6qGQWc6x30L/exh7x0bp6uf X-Received: by 2002:a17:903:124b:b0:1cc:3f10:4175 with SMTP id u11-20020a170903124b00b001cc3f104175mr3523535plh.28.1699734455668; Sat, 11 Nov 2023 12:27:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699734455; cv=none; d=google.com; s=arc-20160816; b=Czn9LCpEM0Iey2pG7kDmkxCEgovCCAWIdqN1mHEl1JdpwVJFOjuhklhVRBEufhXtKj xrHMHJWSX/SaajVa820VsjhzxPVDfKSJhAhgR33zeLab+sC8qVm39t3/HzDyJAM4uRNa 3N/kfaBd9Q1ddO6CYVwe/DEESu58W4hXNM2FmXKURoYSD7tnw4ZJuCXUzqlGmufpl6Ae Ww9SJ+1d/qnPOGPMsu80yq35G//BQVm3UULWD4o/H/CoeIJMy3IxUO+IaTAGTfbPaZRG TjN8cq5l5DkRMsOKXoYvZEAjRfF2A1n+NhL0HM6aHq8OI8DpHxcjnY2Z/5QJiz3zCtUX DBBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bDn777LjiyZ8GAUT5k/ZqELGvfKeffJjqAcHYCvV4Gc=; fh=nTepoPtcKamJv0X8EfPzJS3A3XR2I8SRt63+B7V0fcs=; b=pFjeWQbzXYzz/TJu7gQAC+JPnhlka8T7ClyAiRiMwkLV8vub+YaAIH8XFHXPYLCS2v jZ5EOKSxj+HuX+KwCxWVpd0ijqMNJUsMlRRiXbKVHFpTdUGJAInGE7BU582LKb56Eb/0 gYeB5yWMrGmhgcQT9nlOjxsIWlNfZNjQKWxf592h27Hs8238iNwgSM0krYJqt0ZX5ciE cAqkcsjfaqAHBl1PKhCL6RXGBUIxCwIz5yeXJ/2KmB1LF3TfCRWVHu5nG5jMoyIMIw8x RKczmrkWyx3OLP2SJaFhRgSgzIKnsYm1Y+qHqp0iwgFaDNEURXmErU5P66ZGhOCDjnSZ VQuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YHyxIWmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id m14-20020a170902f64e00b001c62161b18esi2523993plg.580.2023.11.11.12.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 12:27:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YHyxIWmw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9181F809C168; Sat, 11 Nov 2023 12:27:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbjKKU1F (ORCPT + 29 others); Sat, 11 Nov 2023 15:27:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjKKU1D (ORCPT ); Sat, 11 Nov 2023 15:27:03 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57FFDD72; Sat, 11 Nov 2023 12:27:00 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-32ddfb38c02so1877483f8f.3; Sat, 11 Nov 2023 12:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699734418; x=1700339218; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bDn777LjiyZ8GAUT5k/ZqELGvfKeffJjqAcHYCvV4Gc=; b=YHyxIWmw8PYe7Ujeoa9H8C5qs6LdLveQiYmoFNA5dYMU8GmWEuCoh6TqDY20ndqQE1 vDKNwvOr2y4fCYaEu2u7Gy/nfJnjRjLmzb1yr5gQeEUF3oaxIe7mWP7nfINtyCVTTg5j n4ANESgvWgAzdy+pPAU6vtmrPVvi4kJMciAy7LhG+N4Z58uYwOyX07uQwLAlCkJzhw4t eaGUiCIartZYxp/fjVOzjjGRXBeUpR2m8dQx4VFcXSuC+iFo2eV/Ez2Oh64ff4yyjLzb 0n6/rndJbZ2DFPZgMImEobUtgP+VJ/8MEFf40fKH3KRuxyTtDiQfhlGmxwC5lI6JbE0L Kf3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699734418; x=1700339218; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bDn777LjiyZ8GAUT5k/ZqELGvfKeffJjqAcHYCvV4Gc=; b=Eu5FdYHlwUgQcET6DV+reHQmBXWn6wg4Wys7veQ8ObOylaPt4AsYXPSrcK60XbXAqp 1b0fxs3DpXNx6d95vaBBcYnMij5aTu8Pfcpc9dsUOZVYby2CbWnmlhdPtsmjqnDg0d7B UT94YWTV+5W2jAI4kc65hHiZCvl6W+omN1Pea33U7I14pEtNsna7JJoYN3/YFH9rd2ID /4/XY3YaDK66P665w0BsMjOhplXFf7V8mC80MUD8+TZ39dWhoMNSOiNFilg2zfu5QG6O wMaRDjuFd7/r+N3g60PhU0fmOUSS5HCCA2Ijj4VlDPfqhYd2X+2ap7NqbraIkye+hy6/ +Fsg== X-Gm-Message-State: AOJu0YzHN8EhhzT+/Q8DmTjibLUjVWyJ7+7HseH91abFXttwK0SRuDRq phxOKPQql5J16jijf8xHPjc= X-Received: by 2002:a05:6000:118c:b0:32d:ad44:cec1 with SMTP id g12-20020a056000118c00b0032dad44cec1mr2062106wrx.3.1699734418205; Sat, 11 Nov 2023 12:26:58 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id h9-20020adffd49000000b0032d8eecf901sm2111432wrs.3.2023.11.11.12.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 12:26:57 -0800 (PST) From: Colin Ian King To: Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] USB: misc: iowarrior: remove redundant assignment to variable io_res Date: Sat, 11 Nov 2023 20:26:56 +0000 Message-Id: <20231111202656.339103-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 11 Nov 2023 12:27:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782300756629318718 X-GMAIL-MSGID: 1782300756629318718 The variable io_res is being assigned a value that is never read, it is either being re-assigned a new value that is read later or it's not used depending on the cases in the following switch statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/usb/misc/iowarrior.c:504:2: warning: Value stored to 'io_res' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/usb/misc/iowarrior.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 1e3df27bab58..6d28467ce352 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -501,7 +501,6 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, dev->minor, cmd, arg); retval = 0; - io_res = 0; switch (cmd) { case IOW_WRITE: if (dev->product_id == USB_DEVICE_ID_CODEMERCS_IOW24 ||