From patchwork Sat Nov 11 20:15:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 164160 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp404095vqg; Sat, 11 Nov 2023 12:17:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHiMBhJhnfIFxi0R9FrZd4I2LtdaOBVWGVzZ4Dnp3Yxw/xKKDMC5EYQfre8qQzWtwKCWVX X-Received: by 2002:a17:903:24e:b0:1ca:86db:1d39 with SMTP id j14-20020a170903024e00b001ca86db1d39mr2661496plh.30.1699733836499; Sat, 11 Nov 2023 12:17:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699733836; cv=none; d=google.com; s=arc-20160816; b=bkC2QGJakCrOo0wRlfQyGk8EAkkdD8Ys4fKtmXVxd779bMS6xSD7k5b0fL3mQ9MLcP M03Ax/fjwKDd/6KgjdMLe+mc47BIHs20T0rNjpO7y8dY4Ckpc1tuAGqN+kxhI9BD/Yi0 ZePPtZ22Zu/KPFXrdNG+TwzTP3lBjPS6zNQQHUFZQhKjdu43IY/nvtP9aSsPQazWkspA 7gQMoPvi8s9n3T38q56S36f7Z2B20YmMYjuhtNvCijKhn1F4iihwauv/jngdbhMBeCmC 3tMMoJiENl77qEBvu4pnlNv8TE/aehG4dkYeW5w2DDZ8R6wl5R0RHsjSU8m79wR8CxzN YSPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lTOgoglzH1EfgfbAUkYEAdJDDyQ75EjhLpLWQWUsyKw=; fh=r4mr2LSAbSsehZLbBkdKc0lNcM2MGcvJqPpBvy26h3M=; b=rqiL9OttWTk4pkQCofdL1JLyjchQaAcRFgUHwu9p+B8Wt4AVWJKn6UT5+CxYBca/SQ Ry+a4V0w3fQ7yr+p5Esn4rH0kL2vuQiTVo8aquUIGwjItSyLnGjFRmpWLOJkio2XvsOC i2Qa+Okc9uy2TcjhgpLHLn/ha71NckyeZqxIsK0eSkm6ooFL6R2j5g2pVziBvnGjSkAo rft5Df3V6SzqigupffknP+dzEZru8CQA/cb7/jRLFObzqrRcjtDB40oomOCMkOkxYY4c N6rlFMjc1J4ZbqlEgJR/FEFYEiMH3zVe3p/6K+44mWaMXrkkoze0YzPYyQ0ooeSjjDhi 6Iwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OPq1mZjM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id o12-20020a170902bccc00b001b84335fb90si2200483pls.286.2023.11.11.12.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 12:17:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OPq1mZjM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id AC6F2808FBED; Sat, 11 Nov 2023 12:16:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbjKKUPv (ORCPT + 29 others); Sat, 11 Nov 2023 15:15:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKKUPu (ORCPT ); Sat, 11 Nov 2023 15:15:50 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A691D72; Sat, 11 Nov 2023 12:15:47 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32d849cc152so2083476f8f.1; Sat, 11 Nov 2023 12:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699733745; x=1700338545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lTOgoglzH1EfgfbAUkYEAdJDDyQ75EjhLpLWQWUsyKw=; b=OPq1mZjMwX7fzEr3asVl5HeYCbTv3mir9KdSj4ZL8exwwwaA0Yc9tUnW/Fw973fiKj lO4eHs0W4rbElQ+5Gs2jrjdnFtzf2KXaImUxFms+8aD2det7xPkcqlAenwH4OJeanCuq NVzImi80cWraJQEiHh+Gzt6VRY+qkdsWFRP60y4hHVPvWZStprfyPiCzKFB4UdxC6DRY dL0owwXXRfNLBewIuUBQpBY831aafGJFbehQjHjLwn/OS5/YtIdRrdNgqPObiasssUFl Myf1IcdnArpH+LpmSPw/QPYaoTZD9kuIXVfV8NCOcqpa+3O7A0DgnZIuRXWILf1qgqPl 6X+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699733745; x=1700338545; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lTOgoglzH1EfgfbAUkYEAdJDDyQ75EjhLpLWQWUsyKw=; b=t/1Vuj7QCGv2utB95FYstD8glToyiwLLrIiZQ86qjVfuJscCwHgpBAw9ZXGKB3PkpU K0okqJgBr9yFDgeejROP4Yls8IKfgPGbBdJvfHooNs3XVZMUwZCoBobgVUw8s/uRdbcB /ct+J9gRfpFx0a16+zQ5IU22NI5wpZyJNvQEIr3tbeDrfM38yWjvGAnFBr7nqg+Qi5+u Rsz0UuSeLQAkm3I68htlwpxLw/hHx/hp/ZN8jTUkj/gI7xAxvoizM1kPVR+HRzWzit93 nNrjz0oI9ijVNrxBPMdjXn1ypuEDZP9wH9lqQgl4vH1g8l2F9Tpxb4wq/RVBLwpRba7U lFAw== X-Gm-Message-State: AOJu0YwcUdMmTkA0EkiB2+S9mQOWZ1rUAkwLe/AiNmR3cQmlg2tZK2V9 KyyUZSXUpZgF9keisoR/HTRd+XfKRChnWQ== X-Received: by 2002:adf:eb10:0:b0:32f:7cea:2ea2 with SMTP id s16-20020adfeb10000000b0032f7cea2ea2mr1806062wrn.17.1699733745417; Sat, 11 Nov 2023 12:15:45 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id j30-20020adfb31e000000b003197869bcd7sm2105431wrd.13.2023.11.11.12.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 12:15:44 -0800 (PST) From: Colin Ian King To: Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] thunderbolt: remove duplicated re-assignment of pointer 'out' Date: Sat, 11 Nov 2023 20:15:43 +0000 Message-Id: <20231111201543.338893-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 11 Nov 2023 12:16:18 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782300107594763326 X-GMAIL-MSGID: 1782300107594763326 The pointer 'out' is initialized and then a few statments later being re-assigned the same value. The second re-assignment is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/thunderbolt/tunnel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thunderbolt/tunnel.c b/drivers/thunderbolt/tunnel.c index 7534cd3a81f4..8d45cb4f04ab 100644 --- a/drivers/thunderbolt/tunnel.c +++ b/drivers/thunderbolt/tunnel.c @@ -1313,8 +1313,6 @@ static void tb_dp_dump(struct tb_tunnel *tunnel) "DP IN maximum supported bandwidth %u Mb/s x%u = %u Mb/s\n", rate, lanes, tb_dp_bandwidth(rate, lanes)); - out = tunnel->dst_port; - if (tb_port_read(out, &dp_cap, TB_CFG_PORT, out->cap_adap + DP_LOCAL_CAP, 1)) return;