Message ID | 20231111164229.63803-3-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp320489vqg; Sat, 11 Nov 2023 08:43:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IESR+cUxaNH6oYKmV0kqumPuHzt56x5IjQeUO8nRUJx6DjcHPjpzS/CNfUPQrEypqwc0Jtv X-Received: by 2002:a05:6e02:1aa7:b0:357:a180:6b74 with SMTP id l7-20020a056e021aa700b00357a1806b74mr3702699ilv.27.1699721000984; Sat, 11 Nov 2023 08:43:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699721000; cv=none; d=google.com; s=arc-20160816; b=olv1+2QYMibJi9zfZ0kkxE70ebsSqJSzDj+A98RlVSH4keP5th3QTqpLoC+w7tCCfi RryE78bhaBoc3sxZ2FFmgcHM+ntNVlpvYiLDDMHqCfngbN8+6IpOTMZYGTww067KLJMn CsrckH3TblGQ4WOybQ7LXdtfZk6PcPl+eA/b9xos10x2hpXTHtk2w1fPqqHMqig2NXHN C3vnkNLa7H3SQ6+DJdqiXZ0oRvuVRjxVRHL46LMQ+xz3mHRQh3OQjE0hRTDaajcKccn2 8SIgrBL05pfKoxP/RhORW6PKscge14MeMGAp3ul6J6llyOurcVeSFBjLT5GIbOJfnijU zsrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ArNDVIi+I4WcQ+l8h9DJ1wx6t4xBoPH7FgGqFbtahBs=; fh=v1lwT2l/jVFCCowwT16E18rgIv0CDQo4TohtFL5maCY=; b=MSjgZ5408y0RqnWbyxTCEG0p7DFPkoACJXysm/tu3uXxqb1teEgu4EDwzY8bEtR3x8 D9Ue1d90Apwj6tshvM0oeOOGVUKz/qNLKbOqP6K6vDUp6LEfvygAg8pOU4KET2cgx682 W1FJbT5XG41Tn34g4Ev2A85o19YLyDnx/7rwpPjvNW7CygSfaBOHR58y6rJS8OV0ixUs Qf9smeFFHYhW/ZNspbxr9lPExMFgMJAo6z6lIByxp+hxGoMo5UZzD/VJfQq3oNnG+an3 JQT7uOH20mVo8045W5dLtKrp3AqCNkeC/z2D8tO3dYiwFg9K/fAwt/Yc5YD8ejtmAAmx YbUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EqOSH7uA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h7-20020a056a00170700b006c499ddd617si2164419pfc.91.2023.11.11.08.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 08:43:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EqOSH7uA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 663A18039F70; Sat, 11 Nov 2023 08:43:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231348AbjKKQmn (ORCPT <rfc822;heyuhang3455@gmail.com> + 29 others); Sat, 11 Nov 2023 11:42:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbjKKQml (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 11 Nov 2023 11:42:41 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E0072590 for <linux-kernel@vger.kernel.org>; Sat, 11 Nov 2023 08:42:38 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c7369df9d6so41735681fa.1 for <linux-kernel@vger.kernel.org>; Sat, 11 Nov 2023 08:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699720956; x=1700325756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ArNDVIi+I4WcQ+l8h9DJ1wx6t4xBoPH7FgGqFbtahBs=; b=EqOSH7uAB+hLrc6VdJ7wgp+6CCavpxYjWRrNCvJG8LMFXcHWVi8uAdO2QFoTerj3ed WUnYOxMMPUzNnkfaeLsedq2lrnJyavHsvKAD8Ww3c02gxHBK98Q8THYez5v7WUe6IDxl wUyBk2F78jJF9a7t/j72o1jmJFjGDEmmk0ZW1SAdSxhNbmt9bcQjfA4vc36oVMMkJDhJ ZQnlrQkgpKJv6AXAhrCQQG2Jx5saxEIv4OjLrK4JkQeLOwVZrsZsXPhg4kwHI67ZZmEA Gpy3AUNDY4xHE+S/ujcpWtWSksv6JT6v3tK9XVOTPWbX+2FMAIG8mo1I7ypT4reGFH3r TAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699720956; x=1700325756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ArNDVIi+I4WcQ+l8h9DJ1wx6t4xBoPH7FgGqFbtahBs=; b=WDWgvwNG/cffynsfH7/Vt8V7jZJDRtkPdN0/TqgaGuAD9eTVeUHSDWEzUbXhklod1w IfGjBR1VsrIQ6UB+16Gk40ud2PUbqm5Q214DZlP7KSFhy/dnndfZ+jn/0Jl/THbY4R2L /dKOYXCtNNq7CdES+oQ49/+ywnlW2+mNEcTDreFsYdzX8Wb0Bb+GTnQd+0gZY8Ewlnxt MJAMgeQUDZPOxjzQDMfkZTSum3hQHt398mPwrCVY8l51B3GJGmfL42v3wfjyu044eyDg e8DZzU4lyaucwBvW+6KteFleRVSmDxzfYc7wQMpURAK6Az1vBH2GhGImcjXKeH91W4uT 5MXA== X-Gm-Message-State: AOJu0YwvwuIqE3piMGovBuB2bPIJYpgZREfLaT0PfSqSEz4g+NGRWQm9 2EEyQAryvqDJ5Q+zXzmdIIbXLg== X-Received: by 2002:a05:6512:3ca5:b0:509:8a47:3672 with SMTP id h37-20020a0565123ca500b005098a473672mr1394287lfv.34.1699720956174; Sat, 11 Nov 2023 08:42:36 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id k25-20020aa7c059000000b0053dd8898f75sm1161917edo.81.2023.11.11.08.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 08:42:35 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 3/6] arm64: dts: qcom: sm8150: use 'gpios' suffix for PCI GPIOs Date: Sat, 11 Nov 2023 17:42:26 +0100 Message-Id: <20231111164229.63803-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231111164229.63803-1-krzysztof.kozlowski@linaro.org> References: <20231111164229.63803-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 11 Nov 2023 08:43:17 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782286647980827284 X-GMAIL-MSGID: 1782286647980827284 |
Series |
[1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs
|
|
Commit Message
Krzysztof Kozlowski
Nov. 11, 2023, 4:42 p.m. UTC
Linux handles both versions, but bindings expect GPIO properties to
have 'gpios' suffix instead of 'gpio':
sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 11.11.2023 17:42, Krzysztof Kozlowski wrote: > Linux handles both versions, but bindings expect GPIO properties to > have 'gpios' suffix instead of 'gpio': > > sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- What about the 'enable-gpio' right below it? Konrad
On 13/11/2023 13:00, Konrad Dybcio wrote: > On 11.11.2023 17:42, Krzysztof Kozlowski wrote: >> Linux handles both versions, but bindings expect GPIO properties to >> have 'gpios' suffix instead of 'gpio': >> >> sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected) >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > What about the 'enable-gpio' right below it? It needs to be documented first. enable-gpio/s seems to be missing from the bindings and I did not have enough of time to investigate whether this is correct in the first place. That's why I thought about fixing only already accepted perst-gpios. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index e39de6596a1e..9bcdc485c73a 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1878,7 +1878,7 @@ pcie0: pci@1c00000 { phys = <&pcie0_phy>; phy-names = "pciephy"; - perst-gpio = <&tlmm 35 GPIO_ACTIVE_HIGH>; + perst-gpios = <&tlmm 35 GPIO_ACTIVE_HIGH>; enable-gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; @@ -1972,7 +1972,7 @@ pcie1: pci@1c08000 { phys = <&pcie1_phy>; phy-names = "pciephy"; - perst-gpio = <&tlmm 102 GPIO_ACTIVE_HIGH>; + perst-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>; enable-gpio = <&tlmm 104 GPIO_ACTIVE_HIGH>; pinctrl-names = "default";