From patchwork Sat Nov 11 10:41:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 164113 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp158560vqg; Sat, 11 Nov 2023 02:43:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDYa1LGXKFTCfn6hf92Cjp2YlxE4J9EXY34sD0OCELg03DHx3QZE3Mg03Iit6b10UrurYo X-Received: by 2002:a05:6808:2391:b0:3b2:bc91:cbca with SMTP id bp17-20020a056808239100b003b2bc91cbcamr2534730oib.20.1699699399167; Sat, 11 Nov 2023 02:43:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699699399; cv=none; d=google.com; s=arc-20160816; b=xtsRaD/Om8oy3YUS1EBdIXSwWyMfozVUnzKwLOOBW4ZVBdoviqAZIGgDhVZR0YwSr9 xvDCrYqoAjoTH9u8gM5PcMG4AZkbGeGvIcXneO58AaAf9kI5be+o1tOCgLjsfcBewXum epBEQBrJh0jquBM5axiSYGfKS0aUSbHu9xhvtuqxQxIZh8nNvVBrRCqgOlauyqtyfzas Cw0Wr3A7kQzo2gCVC4xk88T7kuCk7oshR9ssbaWt0emBOMj16lPzLLJbWktentnfD3XJ yUXP3PzBu40Smw8NYLgpEOSvhX/v+DWYKUH1hZdj5FwheMJMq137RZOIpNXSF/wUFkIf Rf6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZuBW6agG70lIoCkGnVCWEFfcl6uwNB9B1+pa2Yxc8Go=; fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=; b=c9J68++pR16CYGHfmJscOtxVhHL4EA9qBafsm8ER3+ZlXo8xfhnKoivG6xPQjYbEE8 ijYuqCGDs0GsCl0g75b7r+s+2goLi8dOAGYEftNegC2iDoZtXgpQ210OWIyBW5DTGCIe N881OHBWLLQ4fQAsK0acbOEclAFvxIjdKeMV85erLwVfrZ8Jbs63yH7wTIWgdZYc5lNM RK1eE87wsuQS+4eWZua+pjjnCCkd8g8pLs4C+LvM7DBcmAY6vv+F+TGNbkTKE3hZ7ggl ZjrMqV4h3lplIijxl5Gvf7d7CtgOd84U0ZF0XTFWGmSih0Ysp/VBVoze5RJIQ1VbWkSx p7zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="j9/uP+Xd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t20-20020a056a0021d400b0068e3efffe2csi1563865pfj.243.2023.11.11.02.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 02:43:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="j9/uP+Xd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 43297802C7DB; Sat, 11 Nov 2023 02:43:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230492AbjKKKnB (ORCPT + 29 others); Sat, 11 Nov 2023 05:43:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230390AbjKKKmt (ORCPT ); Sat, 11 Nov 2023 05:42:49 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F8CE9F for ; Sat, 11 Nov 2023 02:42:46 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9e5dd91b0acso267640666b.1 for ; Sat, 11 Nov 2023 02:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1699699361; x=1700304161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZuBW6agG70lIoCkGnVCWEFfcl6uwNB9B1+pa2Yxc8Go=; b=j9/uP+Xdw1Pq1sOD1h6jzT5RhRDbh7QbdYHMsw0DFpoZJwoJziQuHef1h0jrjFE5O1 WjTyTx93aPwRDuSOGHMq/qIRSEQUQOSX0FT8FN7o3TEEwNMqp+hVKAuUdAMbRJL2g5LJ qWjxsbHnyCLi610M+A9iCZdBac+AZ/WG/hXQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699699361; x=1700304161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZuBW6agG70lIoCkGnVCWEFfcl6uwNB9B1+pa2Yxc8Go=; b=dRPtwYiDkn+22ccF2fKDOfpy8En5QQFW1BuoAt6N+3Z2K48XewC6GCzLayXRIHuIP/ pse2X5eVp9h5zkToPpsNOIqNM5VsCkJnn1CXnIXgZmP/vt+8pjVjJPrBXNLt4wer6P69 KIqEhZ7LnghxD5ZFHJvXK3icOQ9UrOKmPU4kzko6qGuhWpxYY9yX5Oaa1CJJibR2BT+V OIqn5thBqesw8SbKNpyObP5boSJY6WN7DvN6/BI2XfcdZDApF3bPKA1aBXdAxWdqvbd0 MhaBUWG1bJz/WQATYCJGDbixMiVxGgqabbQnw8VNWayS0ezZc1rVvvSg2GQ0Cr4UtM9n dJFQ== X-Gm-Message-State: AOJu0Yw/wTZr/YOmj2GsZzcKP5zHoweJCLxWogoE+xbddu5BQ7R9dPv2 4tU43MhhpPbArmyqVJjWAyi5ygkhtbJl26of23cScQ== X-Received: by 2002:a17:906:3c9:b0:9e6:59d5:7a86 with SMTP id c9-20020a17090603c900b009e659d57a86mr915376eja.57.1699699361285; Sat, 11 Nov 2023 02:42:41 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182]) by smtp.gmail.com with ESMTPSA id ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 02:42:41 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Fabio Estevam , Helge Deller , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: [PATCH 04/10] fbdev: imxfb: replace some magic numbers with constants Date: Sat, 11 Nov 2023 11:41:53 +0100 Message-ID: <20231111104225.136512-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 11 Nov 2023 02:43:17 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782263997004901817 X-GMAIL-MSGID: 1782263997004901817 The patch gets rid of magic numbers replacing them with appropriate macros. Signed-off-by: Dario Binacchi --- drivers/video/fbdev/imxfb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index b7ef43a7930a..485e57fa9389 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -89,6 +89,7 @@ struct imx_fb_videomode { #define PCR_BPIX_12 4 #define PCR_BPIX_16 5 #define PCR_BPIX_18 6 +#define PCR_PCD_MASK GENMASK(5, 0) #define LCDC_HCR 0x1C #define HCR_H_WIDTH_MASK GENMASK(31, 26) @@ -414,8 +415,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) pcr = (unsigned int)tmp; - if (--pcr > 0x3F) { - pcr = 0x3F; + if (--pcr > PCR_PCD_MASK) { + pcr = PCR_PCD_MASK; printk(KERN_WARNING "Must limit pixel clock to %luHz\n", lcd_clk / pcr); } @@ -444,7 +445,7 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) } /* add sync polarities */ - pcr |= imxfb_mode->pcr & ~(0x3f | (7 << 25)); + pcr |= imxfb_mode->pcr & ~(PCR_PCD_MASK | PCR_BPIX_MASK); fbi->pcr = pcr; /*