From patchwork Sat Nov 11 10:41:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 164111 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp158534vqg; Sat, 11 Nov 2023 02:43:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgNDTiwnmPCznkyMUlVF0IuD7iXRLm51j+2YGQCcKXcNiG3Q7muvxj+XXhcSv02+deMBEb X-Received: by 2002:a17:90b:33cb:b0:280:1df1:cbc7 with SMTP id lk11-20020a17090b33cb00b002801df1cbc7mr1035572pjb.19.1699699394498; Sat, 11 Nov 2023 02:43:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699699394; cv=none; d=google.com; s=arc-20160816; b=uhjQ1kAU/p/jjjr1krngnMYxP7Ap8NnZasaaf5EJR50ohQAFqLIlYbWFkUCnf4W0Kb MYxMDGXqRBmjWD4NUotEFV5iCYIF2TU1X4F4/pjgMIkcSy0wbX2DHmORbgZ1r+aUXhrz Dfu88u+C7vs9qcvXabAOc/WlerPYM74CSfm0vuNe9uPJua9geWI6L/Nh9hDOOO+Gq/2g /x6rbb2jhrKcSFE+PHBH+EZ5r/j+kYSITMKdUWbnE0xTdj/zMqWlXTw23kG9o0l5gk61 jkwFP69OPRvUAGineEr9xSXf24KrkqFxu+xMyEG188N6rjSvz1ssqAthKqWjNLd4/QpM JXFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eutcu8nha5gIvSO1Nw/orY10THf/Z0yjX5SxOR1EIyg=; fh=GXyCuaO7mljfRZuDSHr1xseCHKUjkPQV0dF3zOsFIac=; b=G4NQ5gMyyrxmjvP6hh8HfTy9BA+wqEtBCTCy+k4126dOlH4WSeMJp/BgLBR7/Lgrho V8U/2P1UAcTTvW1MPcSPEDvQjuvySP4UNpc58INMinrgCja8BJlUvsGWXzdddnn/vFZ9 jvojyEhowrmSgr2ENIaDGXmal+C++BlSrNBHU+sKogBn0UGCV1iMdsrg6ZkqkcdVjCWz 4GGbHA5IWaBgsUQqdtAFw3OsD3KUCalmUEqpwyS/+tM1IJW7ku861s7fomoYqBgC0wZw qK7AtB1ZW//orjtlnMfi7cR9ozV90xs9VwYXJQkRWQ5s0DVy/2eTdk00jpXJDz7Efs0N n/nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ONatCP+N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id f30-20020a17090a702100b0028016799242si6374027pjk.80.2023.11.11.02.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 02:43:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ONatCP+N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 07206802C7CB; Sat, 11 Nov 2023 02:42:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbjKKKmu (ORCPT + 29 others); Sat, 11 Nov 2023 05:42:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbjKKKmo (ORCPT ); Sat, 11 Nov 2023 05:42:44 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6096A3C07 for ; Sat, 11 Nov 2023 02:42:40 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-9e1fb7faa9dso458237366b.2 for ; Sat, 11 Nov 2023 02:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1699699357; x=1700304157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eutcu8nha5gIvSO1Nw/orY10THf/Z0yjX5SxOR1EIyg=; b=ONatCP+NCjimx7glVaUqlVQ1ccgIpvANjCL1+dniTAcpHf0/dDPx1lvfu8g8QnQfus PglkSM7SxDlHi3rMtUarf7m0UJBvQ2lL3yJ6Hjr5Zzbp6pn6Qkm7eT1LCK+YiIm0IspF owGlYdVDDr+VxNWkxLBIPVFmpsgOCZ6WaYypw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699699357; x=1700304157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eutcu8nha5gIvSO1Nw/orY10THf/Z0yjX5SxOR1EIyg=; b=o2zb6eScYxhPLxYg77AGqCa6iDtarfmaK8v3YJw87UX4kI6nm9KlXUv2nN3yA6/YX9 idpE67JB+r8Jv1FA0SnwPqtGAjNZrq+teCIWQbz2ZCExxuJ6vz3M0Va8p9Y/gdcNkY5+ 900E0FALxAAxiTw+yH3ia7f6oQg0c0htUe5FMh/hDHipKv40pmLUqOjtd28jT+x43HfX F6E4RxWmcUMdLTFDSy4RWyZ4JlmjtUZjwlYAB+ylCOA2Ff3wJ0GvxXEhfPNP52MMaQKx Wo9CNsST9BvCA3bVnywcutf1fEdZvgHu857Qi6kfUbjDOaToEJAPCQKrmbQenMZ9jUNy 44NA== X-Gm-Message-State: AOJu0YywzVCYgOBxfHaVx6CvkpyJgMApXOfXR56Zv7H+K3aS/vTCyo4h acEtxnncSfAVSNs8Db3ZfhoddZ1FrMUXFu2a/sycBy1n X-Received: by 2002:a17:906:4742:b0:9bf:4915:22ca with SMTP id j2-20020a170906474200b009bf491522camr1072967ejs.45.1699699357215; Sat, 11 Nov 2023 02:42:37 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182]) by smtp.gmail.com with ESMTPSA id ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 02:42:36 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Fabio Estevam , Helge Deller , Martin Kaiser , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: [PATCH 01/10] fbdev: imxfb: fix left margin setting Date: Sat, 11 Nov 2023 11:41:50 +0100 Message-ID: <20231111104225.136512-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 11 Nov 2023 02:42:58 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782263992212892534 X-GMAIL-MSGID: 1782263992212892534 The previous setting did not take into account the CSTN mode. For the H_WAIT_2 bitfield (bits 0-7) of the LCDC Horizontal Configuration Register (LCDCR), the IMX25RM manual states that: In TFT mode, it specifies the number of SCLK periods between the end of HSYNC and the beginning of OE signal, and the total delay time equals (H_WAIT_2 + 3) of SCLK periods. In CSTN mode, it specifies the number of SCLK periods between the end of HSYNC and the first display data in each line, and the total delay time equals (H_WAIT_2 + 2) of SCLK periods. The patch handles both cases. Fixes: 4e47382fbca9 ("fbdev: imxfb: warn about invalid left/right margin") Fixes: 7e8549bcee00 ("imxfb: Fix margin settings") Signed-off-by: Dario Binacchi --- drivers/video/fbdev/imxfb.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 84201c9608d3..7042a43b81d8 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -42,6 +42,7 @@ #include