From patchwork Fri Nov 10 18:11:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 163918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1320406vqs; Fri, 10 Nov 2023 11:02:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+X06YG7mUlpEVKrj0rW87AX466kyPbr781+XZhQFiPOygu1CALQiJ5ft1TDUMICTMPWmn X-Received: by 2002:a05:6808:112:b0:3b2:e577:7339 with SMTP id b18-20020a056808011200b003b2e5777339mr167703oie.41.1699642937086; Fri, 10 Nov 2023 11:02:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699642937; cv=none; d=google.com; s=arc-20160816; b=Yp0htATPU5VJfU+Qi9dL25M6esYME5VQEniKUgKEjJX4fQUPQG3TPBeI2KT2BY/iIA D2qQz2FS8QlIZb85t7lKALKDiiJS6NbtbvX/OKho9891L8qVJbB4hx37IjOc22eROn7F ZO1e1H8QLjA1U/UDWQZmHO7RsXdWLtw7/LVtLN8fevBLufGnXxOPB9FqEiTZ08+JaauA aRu4NJ2cwi+uV7HrDapdOIej11oQt9Pfu+OTUwopqlWbA98FIEiIrh6MzItcP1+44RKW BQ2tvdyXh8guNJUmmIKWGDxteys+9ANi+1GuikTEuVtYQqI9lvtuhVVFDDE0ClEjy9eQ pO5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=90HpV4ytOMRYUHnHkG4j1gnMWxur4JKccA2qHlbvND0=; fh=oqZDtrV02dtzkTHSBiwo+TWR13WhTCI6t34Q5J0VV5o=; b=TgZ5s8Kkj5J3WcPOLSqlHLIzXaDjNsWxDE8t9pwpZy5qAIIjEjTp6bmBGuXDq2qLCw Tct0q7GDb5njRs3TXxKUMaW6Dpc5eMkfmKguJKFhFdVxp2GPLUR/VKbiJKPvAdA1eyHL Q532cqvVk9baGNLw2SdBQBkyY7kDaxaWQ2IlY6QFYpOFSbNUIp8QvRp5cqnpVlN8uZeK i3Cnu9/DwmD5SoSzodjM6gpUUJTRsdfKOVQ66Wss8vjrVXPMpd6vLIh0LuM+Uefeuov+ nSakcucsAoyghPOrq0gVnqTYXllceihpQGT1ZOt9MLBdw2p+7GrETOMj4xv/jbKAMXna 24rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=T93xu4PC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id bx29-20020a056a02051d00b005bdfd3a0d3esi26850pgb.185.2023.11.10.11.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 11:02:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=T93xu4PC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id DAF5B817C8BB; Fri, 10 Nov 2023 11:02:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344206AbjKJTCF (ORCPT + 29 others); Fri, 10 Nov 2023 14:02:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235303AbjKJTBr (ORCPT ); Fri, 10 Nov 2023 14:01:47 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 620DA1091B4; Fri, 10 Nov 2023 10:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699640673; x=1731176673; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eMPXpCWG6Cf4B8QclIybkFC1zjR2hPsfAHy93QLcORg=; b=T93xu4PCj0QBQbFzi9l9IC5xlLfBalfd8QVHM0P8Qr+6RA2/zeFIYM9d mzMKOkfTxWBWBFHpJMq6YMUpvc+cNZDkH/R1HN4pN8jME+5NWKbkCyPWV BOi+LQflGIMqfEbuqeBPURbWhLedXapo7izuF0ylHWc40IN+Rr/bVORFl 7QN1b4r2S/GgQFZJ2DW7Uo/4OVBr9CO1BJr2b+N47vzhpahzm1pFXl5P3 M91RFBF4c/VtyIl7oQ7dalsorHy8ms/hSR6gVG8MflyziE71ou1G47D9o Z33Zk8xAWArdiYq0+YRJZGPiD3n8yPsUSZS0bwkjPCOIcTSZHH/4/AAgV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="375251918" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="375251918" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 10:23:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="798663748" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="798663748" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 10 Nov 2023 10:23:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C0972823; Fri, 10 Nov 2023 20:23:07 +0200 (EET) From: Andy Shevchenko To: Jarkko Nikula , Mario Limonciello , Herbert Xu , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , Hans de Goede Subject: [PATCH v3 09/25] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Date: Fri, 10 Nov 2023 20:11:29 +0200 Message-ID: <20231110182304.3894319-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231110182304.3894319-1-andriy.shevchenko@linux.intel.com> References: <20231110182304.3894319-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 10 Nov 2023 11:02:14 -0800 (PST) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782204792178428676 X-GMAIL-MSGID: 1782204792178428676 As Krzysztof Kozlowski pointed out the better is to use MODULE_DEVICE_TABLE() as it will be consistent with the content of the real ID table of the platform devices. While at it, drop unneeded and unused module alias in PCI glue driver as PCI already has its own ID table and automatic loading should just work. Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko Reviewed-by: Mario Limonciello Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-pcidrv.c | 2 -- drivers/i2c/busses/i2c-designware-platdrv.c | 8 ++++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index d2ed4e77afb3..db642e0aa61f 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -417,8 +417,6 @@ static struct pci_driver dw_i2c_driver = { }; module_pci_driver(dw_i2c_driver); -/* Work with hotplug and coldplug */ -MODULE_ALIAS("i2c_designware-pci"); MODULE_AUTHOR("Baruch Siach "); MODULE_DESCRIPTION("Synopsys DesignWare PCI I2C bus adapter"); MODULE_LICENSE("GPL"); diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 4b5e58e1ce5b..5d8427ccc9b4 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -486,8 +486,11 @@ static const struct dev_pm_ops dw_i2c_dev_pm_ops = { RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, dw_i2c_plat_runtime_resume, NULL) }; -/* Work with hotplug and coldplug */ -MODULE_ALIAS("platform:i2c_designware"); +static const struct platform_device_id dw_i2c_platform_ids[] = { + { "i2c_designware" }, + {} +}; +MODULE_DEVICE_TABLE(platform, dw_i2c_platform_ids); static struct platform_driver dw_i2c_driver = { .probe = dw_i2c_plat_probe, @@ -498,6 +501,7 @@ static struct platform_driver dw_i2c_driver = { .acpi_match_table = ACPI_PTR(dw_i2c_acpi_match), .pm = pm_ptr(&dw_i2c_dev_pm_ops), }, + .id_table = dw_i2c_platform_ids, }; static int __init dw_i2c_init_driver(void)