From patchwork Fri Nov 10 15:55:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 163987 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1374089vqs; Fri, 10 Nov 2023 12:44:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IETkoSLyIGmtWYNLe7CqqwNuFHFsS25fBuwl6An0Ou1xd85pIbUxf9EF1viuyCzUcMiue95 X-Received: by 2002:a05:6a20:1602:b0:17b:129b:196f with SMTP id l2-20020a056a20160200b0017b129b196fmr307126pzj.11.1699649060936; Fri, 10 Nov 2023 12:44:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699649060; cv=none; d=google.com; s=arc-20160816; b=AumIh2oC6CokcJRYkDna3otY/D/TiQaPsiC4jMrma0K56W3vmaIn7p2IhTxy3p5s+f WVHJpgC0RKAnUruR/9d4nT0aMKsdwdYQA9GRwNWiLFxO5INqRq2aacNUMO6TNeC9r0US uzOiWmgdGLUqUHBtBlhk2DTsPkUVj4b1YXdgnpB9uzCNvQa3ZssASv6gvMnkqzxvlnzY kuZ4XRRv1UhjsFWKk/l4XeqOGfWmCA/pqwZCojGecTu91t9ASiVe6MezSAuJc+SXiTxc /Csl2S9k+Jfa+2A5fOgIAQzVz7BJAF3kTDeLcoP0ZTQMCQ3H7DYkt0YsMhvht5OJ2+cd jdAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PXwXN5tEaR5kdeL10MocxWEaauKlj7fnNpl4PFnuxYM=; fh=e0AtESRgQaw5m9+PMq7d2wNZ79m436y+bgTtI+aoNLQ=; b=WlGiZeS5qtno5Lwz05vJfQDKVCaECvsexgCr57vOkFAEQmk0Jjy2lMx4tBq67TqhKD ZLloAZPqo3XfhBI2u5Tp7o0f6HVDfmgtvaUIdChUlYPqE+FoeWp8L+BQ+egD9Mwx8vv8 UEBufe/eub1hF6cvy7zsU6Cv9i6OZSjvIxVSRtG0GWAluyRVM3BAX+nCmkSq0+86lFZI JgzIDOEh9lPW0033Fsv+0VJxWx0lW/d++wK74zttEgMbNiu5DzJV6AmI93dudtMiuETp TVbr2R7N4xRJWIx+rAZctorniH0Sc5Gd8513qQHEH5X4CvfvK7+JkFUeFsD6rp2EZjtv 5r6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=d1kbIHQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ca8-20020a056a02068800b005b93064798bsi226581pgb.191.2023.11.10.12.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:44:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=d1kbIHQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 31D8782E1EE4; Fri, 10 Nov 2023 12:44:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346651AbjKJUmS (ORCPT + 29 others); Fri, 10 Nov 2023 15:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346477AbjKJUls (ORCPT ); Fri, 10 Nov 2023 15:41:48 -0500 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F363B33C for ; Fri, 10 Nov 2023 07:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PXwXN5tEaR5kdeL10MocxWEaauKlj7fnNpl4PFnuxYM=; b=d1kbIHQgk3i7aNFylGG3Bb2XtI AmBsCJCFTGSWWS+JpsukzdbLm80G/eW43IctFGZ3y0SxuGQ8tCPMJRv7eX1YGTX41ouUDPVFXcAu3 1DFFveqrJUD4hJ3RvcPkZsDrS6AnufUvcRR3IVFkHsEkojSPGtHIaPxT71zkPHGz0BEufb3OTZdic avFBnBOGyB0mAucQCN1fyneCryJ0HF7BJCk5L8PMN6OUD69/VkrgFXtc+b9HMddus1BMbRPVCMFy3 2kJwmjzSf6zPgzzfVlsu1MqH9KtMlTDyVMcxMBSrusmxxHVnDLb2cmgdFVnbKzZPN9ZT46epEcgNY PZi+w30g==; Received: from pool-96-246-156-208.nycmny.fios.verizon.net ([96.246.156.208] helo=X1.myfiosgateway.com) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1r1TrU-001hA7-V0; Fri, 10 Nov 2023 16:56:01 +0100 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, ray.huang@amd.com, =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH] drm/amd: Document device reset methods Date: Fri, 10 Nov 2023 10:55:48 -0500 Message-ID: <20231110155548.20599-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.42.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 10 Nov 2023 12:44:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782199857493775869 X-GMAIL-MSGID: 1782211213941534489 Document what each amdgpu driver reset method does. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index a79d53bdbe13..500f86c79eb7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -504,6 +504,26 @@ struct amdgpu_allowed_register_entry { bool grbm_indexed; }; +/** + * enum amd_reset_method - Methods for resetting AMD GPU devices + * + * @AMD_RESET_METHOD_NONE: The device will not be reset. + * @AMD_RESET_LEGACY: Method reserved for SI/CIK asics. + * @AMD_RESET_MODE0: High level PCIe reset. + * @AMD_RESET_MODE1: Resets each IP block (SDMA, GFX, VCN, etc.) individually. + * Suitable only for some discrete GPUs. + * @AMD_RESET_MODE2: Resets only the GFX block. Useful for APUs, giving that + * the rest of IP blocks and SMU is shared with the CPU. + * @AMD_RESET_BACO: BACO (Bus Alive, Chip Off) method powers off and on the card + * but without powering off the PCI bus. Suitable only for + * discrete GPUs. + * @AMD_RESET_PCI: Does a full bus reset, including powering on and off the + * card. + * + * Methods available for AMD GPU driver for resetting the device. Not all + * methods are suitable for every device. User can overwrite the method using + * module parameter `reset_method`. + */ enum amd_reset_method { AMD_RESET_METHOD_NONE = -1, AMD_RESET_METHOD_LEGACY = 0,