From patchwork Fri Nov 10 07:25:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vignesh Raghavendra X-Patchwork-Id: 163812 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp1278197vqs; Fri, 10 Nov 2023 09:47:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+nO3HHjjiadgXkqhAJlK6BV5l9ToiEtnuY8ayEaPrG5jfz/c1518d25V/wKRnaAU/jc4o X-Received: by 2002:a05:6808:148e:b0:3b6:d665:4938 with SMTP id e14-20020a056808148e00b003b6d6654938mr629302oiw.43.1699638451483; Fri, 10 Nov 2023 09:47:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699638451; cv=none; d=google.com; s=arc-20160816; b=rZ7/jxGeD3ragyK3NLYHnLjyk58kUWLkJy7NTxqmRXLTvkJ3LZ0CcrbvnLggGpVdJ2 pMkN9Pg/A8GjZbVYv45sVeJJFcy5KI/Jw6IQk1ponfWHNAQtLmW+lrJNojk90ldbwAwQ tX+R7UVvg1JvzcQhFOSIE3Z4nMK2B4q8a4p5fhGFhBcCYwDpP7IcN7m5HZs35T5ZonbK BXUfWhmPx8wvXMl/9/x74D8D5CQz1T9d6CgZcmK00BSIOYq9jAJ2Lq2yjZLeS5uMGgJ4 ZuuwS6Mo6UsTPkOeRxFWeNHhib8BJWPhLsyObi7GeQu+xrbweqpvOkHzHAbaANQq+CIO P4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JCUS06QaMlEG1bwuFXka0dGKEOVlkAppxM8sVyRCbSE=; fh=02v72Hrsl6aoa9QrVmEcK4vo0/Lds2dUN5o/AE/uxn4=; b=k5O7fLyYgV4pnbQQoxnJPW7qAAsrPKkNeTiqH1Pkd3PZM1C7idKFVMP24UDWoFuYYR NrRTnQY8Jl7jKQC1JBT6TYGNf+W/7obpgBk+0HqF2SvaHgILoS1v2dy2LqkSf21UAdGo EiQttAfnReHDPwmEwCVfuMQNy5KcKVvkLghk+c5vjuhbuneC3vBeKxKHLiga5jvVMXM/ w599NAtKtTYJ06/Ph1u/dpHDmOE3IwmE5TrfdhAq85GraK4bSRnI1doZcjGg31sgve08 rVtNV1R7OQj41MI8y4ShkT79IX30ON+HBNWUBoOvdaR47Tpm8NwEC05UErSpvSyxp53K bWdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=dpJ6H80E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id v11-20020a63464b000000b005acb92781fbsi10620853pgk.415.2023.11.10.09.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 09:47:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=dpJ6H80E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2CDBB81DDB60; Fri, 10 Nov 2023 09:46:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344975AbjKJRpH (ORCPT + 30 others); Fri, 10 Nov 2023 12:45:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345921AbjKJRoH (ORCPT ); Fri, 10 Nov 2023 12:44:07 -0500 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ECF983FD; Thu, 9 Nov 2023 23:26:11 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3AA7Pnl0074187; Fri, 10 Nov 2023 01:25:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1699601149; bh=JCUS06QaMlEG1bwuFXka0dGKEOVlkAppxM8sVyRCbSE=; h=From:To:CC:Subject:Date; b=dpJ6H80EpkEOXn0KXbLIE/P2W3OGNc3pSc+sviA4hNdcWvLgurwVbFOoP5hZ6n+ml RS04ZvQiN8ZYN7z07mNS72f0uvYuKjVsr7YElcgHleeCBEu2rHPPyOyHuPKh0znhRj ays+63QQQXpGg7dg7Gm9XGkG1DvAgLSakkmtkCmw= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3AA7PnsX023724 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Nov 2023 01:25:49 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 10 Nov 2023 01:25:49 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 10 Nov 2023 01:25:49 -0600 Received: from uda0132425.dhcp.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3AA7PkSu102695; Fri, 10 Nov 2023 01:25:46 -0600 From: Vignesh Raghavendra To: Adrian Hunter , Ulf Hansson CC: , , Vignesh Raghavendra , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Subject: [PATCH] mmc: sdhci_am654: Drop lookup for deprecated ti,otap-del-sel Date: Fri, 10 Nov 2023 12:55:35 +0530 Message-ID: <20231110072535.2695134-1-vigneshr@ti.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 10 Nov 2023 09:46:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782200088976358157 X-GMAIL-MSGID: 1782200088976358157 ti,otap-del-sel has been deprecated since v5.7 and there are no users of this property and no documentation in the DT bindings either. Drop the fallback code looking for this property, this makes sdhci_am654_get_otap_delay() much easier to read as all the TAP values can be handled via a single iterator loop. Signed-off-by: Vignesh Raghavendra Acked-by: Adrian Hunter --- Based on discussions at [1] https://lore.kernel.org/linux-mmc/CAPDyKFrCSTW3G6H7qS89d+UQ6RJcAYcKSPULVT8J7XKsUDpHdw@mail.gmail.com/ CC'ing DT maintainers to see if there any objection to remove undocumented and deprecated property. drivers/mmc/host/sdhci_am654.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 967bd2dfcda1..402fba0fa418 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -577,32 +577,15 @@ static int sdhci_am654_get_otap_delay(struct sdhci_host *host, int i; int ret; - ret = device_property_read_u32(dev, td[MMC_TIMING_LEGACY].otap_binding, - &sdhci_am654->otap_del_sel[MMC_TIMING_LEGACY]); - if (ret) { - /* - * ti,otap-del-sel-legacy is mandatory, look for old binding - * if not found. - */ - ret = device_property_read_u32(dev, "ti,otap-del-sel", - &sdhci_am654->otap_del_sel[0]); - if (ret) { - dev_err(dev, "Couldn't find otap-del-sel\n"); - - return ret; - } - - dev_info(dev, "Using legacy binding ti,otap-del-sel\n"); - sdhci_am654->legacy_otapdly = true; - - return 0; - } - for (i = MMC_TIMING_LEGACY; i <= MMC_TIMING_MMC_HS400; i++) { ret = device_property_read_u32(dev, td[i].otap_binding, &sdhci_am654->otap_del_sel[i]); if (ret) { + if (i == MMC_TIMING_LEGACY) { + dev_err(dev, "Couldn't find mandatory ti,otap-del-sel-legacy\n"); + return ret; + } dev_dbg(dev, "Couldn't find %s\n", td[i].otap_binding); /*