From patchwork Thu Nov 9 23:54:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 163635 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp783857vqs; Thu, 9 Nov 2023 15:57:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0SsOfsVZPsn3SjnaDeXHdGIHoz/6WiOyZMJKxtnjbi/axCePhU28131i2a7CKFEE8fHIJ X-Received: by 2002:a17:903:484:b0:1cc:ee07:1659 with SMTP id jj4-20020a170903048400b001ccee071659mr6181985plb.46.1699574258839; Thu, 09 Nov 2023 15:57:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699574258; cv=none; d=google.com; s=arc-20160816; b=wT0LU0/FShZFD3ArD49IRAHcqEGQ4/8hMjN0F85y1j6/A5gydDJfjR1luNHjLf9Czw u5j/tOUvf9vgfxiiObNITlvYdeCSdvNCPo01cTQped7WASb8hAuhVBT925rD1wftG65O rmcWLaJPTssNa3zBbQ3k0N6Rhrb3xW356MO/C5j9pRRsdoMlKe3xqDlhwVyWHcl3PsWB H3V4dAiaSYKiZhVCmkMmE0WZPyyEVqWYVa+46qR6cj0ixQcIV5WaDd0/l44JQMdE4Q3B v+jqE31UGYe7tgKhiealFIuTkOCYfKYrxrYQcWBsh8XpCgJuWWkxL9U16hGXAYyJfU3Z WsTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KOGnrwGuPglkUh0+Fj19u8kSBzGFAbbmPxBOgbMVl8k=; fh=I9VjUIfL8bb9/78sWIEVVBrkhXYAbiOhCV7Ppyxila0=; b=LAaJzc3Iakq7DM/6EiiU1RFU09+eDg65GEzo0yJy/lRVfq6YDx5+YitUovTafRM2V8 8g3bOyLC3sJoCaXlKFOLgh30o9RK8Rmbr43cRJsnk/rT6ld4sTwse2vyLzFpWlRLNlNk /ZeRZ3zeuEes6OjzPIsELqRujBsX4t/AIoVkFDytW6IGId5a2F2rRezlLRv1qwqEJpF0 6vV7/WuiDQ+J3pCX3iVA2E8lBF3qMe++n5gABIbFgDST+RsvDkwCD2Br6t6A6CRgpOTM VhEUihGyoHGo6IJu849aJTfnZ4JDlZ/vKguVbaC6irk2Sv0MruK7ToZw5OMOk6lCA0ML el6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marek.ca header.s=google header.b=J0p519Rt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id j6-20020a170902c3c600b001c9ad8ca211si5842410plj.18.2023.11.09.15.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 15:57:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@marek.ca header.s=google header.b=J0p519Rt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4A2BD83C38E9; Thu, 9 Nov 2023 15:57:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345363AbjKIX4z (ORCPT + 30 others); Thu, 9 Nov 2023 18:56:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjKIX4x (ORCPT ); Thu, 9 Nov 2023 18:56:53 -0500 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9BED44A4 for ; Thu, 9 Nov 2023 15:56:50 -0800 (PST) Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-77a453eb01cso91604785a.0 for ; Thu, 09 Nov 2023 15:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1699574210; x=1700179010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KOGnrwGuPglkUh0+Fj19u8kSBzGFAbbmPxBOgbMVl8k=; b=J0p519Rt8Ua3wXuRjkUln7egoTJqPVxUaP5G0UQL3yCZQWHi7PYrWPIiafvqqzmjLJ tl8PrcOsxMmKPZbrtNIiqyr9LTn8urLLpyld/AAQ5XxauiA8IB8IOqpSlnBYZd8371na KCYemOqnh4NugGZTtwN1WzckYoY6XeMXOUVQ3Rucu+F8sURvar7t+Zr0CMZquFf4Tm6k 5Mnc2IlL+xubCps0iXc5osf8unoCs8geVlIgmIr4J/h9oS3LwDeOJ4AVRuYv7VIhBe14 tp0zlz520slZNj5fLn0KTXKwB+oJ09EIxkm6AfL2q/BYTIQysCwaBW+D1mYg7hqGYbDu cFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699574210; x=1700179010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KOGnrwGuPglkUh0+Fj19u8kSBzGFAbbmPxBOgbMVl8k=; b=OTZ8pLcAlXB5x0gaL4qu5BbISIj78mcA0QLuQsM/mFxfqKQClIDwCkb7svwStXYeVJ vx42YicdV2v4tM4yNwn130yUMiVV+KktMyWqeunDPgJURU1XOVNQ8eXGJDN2OPtF4PC0 zwJf/Z1MjQmkeVnpWbHquW7+q7YwioccxV8GtqT8SwlFlZ0CNrE8UMC0SaPOm22zPPWQ oWm7wdyypecxvxEy4LT8z/MGuSPjj5USvriGjQ8w2ECJe2VYplyDIMlxYaXztTsCVuvv BCnSjpY0/dT1PWI68QhEAgUyCh0/fHPGIsXoY+G4Hik1/cPv2TqbLVPmYsTvt/Dw30L7 r+Iw== X-Gm-Message-State: AOJu0YxDaEisxvHkeUqRgC6wPOxVBcYC3LqxUA+ZL1i1SqUimu/MQeU8 YaSLE4nHbK4+ye/Yvxl6oI5yjg== X-Received: by 2002:a05:620a:29c9:b0:778:91f0:e541 with SMTP id s9-20020a05620a29c900b0077891f0e541mr7487802qkp.23.1699574210077; Thu, 09 Nov 2023 15:56:50 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id bl1-20020a05620a1a8100b00777063b89casm299211qkb.5.2023.11.09.15.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 15:56:49 -0800 (PST) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Konrad Dybcio , Robert Foss , Vinod Koul , Neil Armstrong , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy Date: Thu, 9 Nov 2023 18:54:10 -0500 Message-Id: <20231109235412.29343-1-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 09 Nov 2023 15:57:36 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782132778311927228 X-GMAIL-MSGID: 1782132778311927228 Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly. Fixes: 93f0ca6fd61c ("drm/msm/dsi: fix VREG_CTRL_1 value for 4nm cphy") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index 3b1ed02f644d..89a6344bc865 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy, if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) { if (phy->cphy_mode) { vreg_ctrl_0 = 0x45; - vreg_ctrl_1 = 0x45; + vreg_ctrl_1 = 0x41; glbl_rescode_top_ctrl = 0x00; glbl_rescode_bot_ctrl = 0x00; } else {