From patchwork Thu Nov 9 20:28:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 163575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp689274vqs; Thu, 9 Nov 2023 12:29:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEKV82wIMwZpr8VKz+ufkXjfojGN1wTCIydqnC0xzt2pMVrAgVYx5EdAP4HhISIxlE4BpH X-Received: by 2002:a17:902:b610:b0:1cc:17e6:5da8 with SMTP id b16-20020a170902b61000b001cc17e65da8mr5473350pls.10.1699561774761; Thu, 09 Nov 2023 12:29:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699561774; cv=none; d=google.com; s=arc-20160816; b=bOBFtWih0eebhrnZ8p/Vh2pvNT+DCgok1fHn/oqTgR0jsAGi6hWH5qzMRn2zHaWO4H gRKDs1qOg9h3boxc1Nq1dJ4BYi/RzJHUg9H2WJ1rTDspbS7cN/isizqtOJBefdtbVrY8 wkL0OsyWf6CIcwurlZbKcgroOX2+1H1t3xcfO/YGX8NVL+nnqRBudzG3xafJVUbeqRQI MOsgjmEHVnXnlUglVqO/M3OVpGQf2OxyNX57Wz4SSRJqDf1uNjIkXk6TrFnt06aYdaIT JtYVGkqdKPTgmMY/7/wzwI1mC11YuOE1ZdduVNX2iDA4Ez6RW5TSUqHGW5XqRCSLhj+y OvJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=X8m+C09y0ow1FO1wCogH6/s51Bwkf3IobHer8dRzRr0=; fh=ytgHdCNAvgugi5rZu1708fP+HXGP+6in4VXKPuQ8Iek=; b=h9BtnwGvQe1Ba7z+tnzqSZ5roIL9441SltoZ2bs96nvZFA0omUWv5i5aAmpqD/+I8t Z1VjoDjtEE0apKw4zQPQe2Fvg0VR02mY/+4OSN9JyjTlQnntxHDVDspHpakJXg4hCcmq CCTAd7RgH/CY6S6iOgwCYFDCs7y9VszrWe/CSXMQSuAtXJv3IWze78mEncs2Em/uHXMz Uf6NGRi6AqVdSIgsDjA84VJnevDdvu0RaMPE4c6evQ4T1cIv5WhF9c8/u4/HtzJ7h4AA JGzOxWQg0S24cbtKEQbgtKEqPLlNhwnzz7iFd4zdGbZx9OtKqBjcopZeoXD+lSjpUSKC /AYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ku4-20020a170903288400b001b89551a392si5366336plb.113.2023.11.09.12.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 12:29:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6F3878391127; Thu, 9 Nov 2023 12:29:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345257AbjKIU3b (ORCPT + 30 others); Thu, 9 Nov 2023 15:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345220AbjKIU3V (ORCPT ); Thu, 9 Nov 2023 15:29:21 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A92468F for ; Thu, 9 Nov 2023 12:29:15 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeD-0002zf-W9; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWd-8G; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeC-00GGtX-VE; Thu, 09 Nov 2023 21:29:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Rob Herring , Jernej Skrabec , Laurentiu Tudor , Arnd Bergmann , Tony Lindgren , "Sicelo A. Mhlongo" Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 03/12] bus: omap_l3_smx: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:33 +0100 Message-ID: <20231109202830.4124591-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1746; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zgJm1dlc/UlSS9zetmH5GbvsuMr4qHT3lQphrWzkAzU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUDyw8liF78LWnyhFZLru8PNsGZ1t5BmeLGyf 0BHYx1oYjSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A8gAKCRCPgPtYfRL+ TtsSB/4lgGCQ+t/mONA1F+XnD+DFwmTvwvTCbxyBHsoJ9uUpV+auNZ5K0B0WlzVfMqqDDQWazys Oewf+G4tvcZn3Cr/r7I65OEGZpM/A2wwR6DOr0Vxk49ASXpiik5DaTqrK0sBvMGD4Cpq5B2dFdC 9GTXCisMJb2Ocbbj7ssV5uKEl21yMzv+10pPDCwTLMmLXUk9s5aUB6nL/6o8knNMuPZEDLcmok8 RSuR67bbgUapNxOYgWFwZ9qu6Ra3XHKQlOiCLXQwroe4VqIEG/QCSm+7pGl1fkvC3rZKywWMKq9 185Eh8d+I+slva1fnPV5DRZvTdkYBaIESmhNSzh4SMNuOBs+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 12:29:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782119687387044547 X-GMAIL-MSGID: 1782119687387044547 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Tony Lindgren --- drivers/bus/omap_l3_smx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c index 31774648be9d..ee6d29925e4d 100644 --- a/drivers/bus/omap_l3_smx.c +++ b/drivers/bus/omap_l3_smx.c @@ -261,7 +261,7 @@ static int omap3_l3_probe(struct platform_device *pdev) return ret; } -static int omap3_l3_remove(struct platform_device *pdev) +static void omap3_l3_remove(struct platform_device *pdev) { struct omap3_l3 *l3 = platform_get_drvdata(pdev); @@ -269,13 +269,11 @@ static int omap3_l3_remove(struct platform_device *pdev) free_irq(l3->debug_irq, l3); iounmap(l3->rt); kfree(l3); - - return 0; } static struct platform_driver omap3_l3_driver = { .probe = omap3_l3_probe, - .remove = omap3_l3_remove, + .remove_new = omap3_l3_remove, .driver = { .name = "omap_l3_smx", .of_match_table = of_match_ptr(omap3_l3_match),