From patchwork Thu Nov 9 20:28:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 163573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp689126vqs; Thu, 9 Nov 2023 12:29:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFjbZs+lubzJioIWy6dLhW9BBWpciX26IsaIdWrKYDPGUce0kzt/9WetB+IhncfmcjqrKc X-Received: by 2002:a05:6a00:2d99:b0:690:c75e:25c8 with SMTP id fb25-20020a056a002d9900b00690c75e25c8mr6212298pfb.7.1699561759275; Thu, 09 Nov 2023 12:29:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699561759; cv=none; d=google.com; s=arc-20160816; b=AQcgTa6/1ZWxhJdj6UYChPtal0mwQU9VGXkAKSOPO86MsP18mII8lEuZMYkKDYCl4f 7irsLwIXqPAqlXhOruJffaaLmR1Mn07VfaGrqjSwvHyYQRLWVAjQ1tzjNM0VjQTbK4e4 hLpLuvBqmYRdAuZ16DKNjPzjffvQPyNDE1FnbtmJpCFBxaf0PZ/Tne6DjE82kUZ2UMWh lWN+tMvnT6jjs8JroJB3EoNTf9rDecnHg5eqk0Ad4BCjseQmz9RG4E2yuBDmODGOFlH6 UaVOrSDiVLx7h+U0DocZkzeQSFhxmdvtMrhTnVj91ePLDmfz2DN9qv0CZy9e1/WYsOHX PFUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6GZI4CZ5vDp1gvhvoVhfjrjwii8NUZTkbenlS272rZk=; fh=28WnUnavaj7JpcKzgn3hu8/ru1TjTcdDAX6hP01XWrU=; b=vKILUFRhmNxO+y7FkZZabZKd+qgfVN+A2+78vxBHOTw/NCYoIkAI0k75QEaiW5Oupo 2hce74XMCt0eDuNZlwjQ+As5SB3FsoPP/epbS5CTUKyx+02oskL0c8A/AEVqjdNpxOC4 XmlFcKmhvNYsDib5KPUPgYahQHTcSwlGP4ePBmJMTxDC4c3AhHgnYCV7SjHmQBIQDAU1 F34+MMGGUfthuO6V1jf1lWuvDWssqoJ4UCsrnaE8XZiAovkuseNFwQt8pH3q8iIrdHOa jHznTBTju4zossppapdQm/vLNZIuA5MiH+PZL0N+Wa9i16K02Q51ViMuV9FbqK+PZ+dr Yndg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x37-20020a056a0018a500b006935df301a3si16877408pfh.8.2023.11.09.12.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 12:29:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 402668391F86; Thu, 9 Nov 2023 12:29:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345172AbjKIU3P (ORCPT + 30 others); Thu, 9 Nov 2023 15:29:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345176AbjKIU3N (ORCPT ); Thu, 9 Nov 2023 15:29:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD42844BB for ; Thu, 9 Nov 2023 12:29:10 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeE-0002zX-SK; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeC-007rWX-Qx; Thu, 09 Nov 2023 21:29:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeC-00GGtP-Ht; Thu, 09 Nov 2023 21:29:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jay Fang , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 01/12] bus: hisi_lpc: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:31 +0100 Message-ID: <20231109202830.4124591-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1825; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5AZNdjzJwHWz0slz9MDShONzNbivb6y7QJLchsJRFkk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUDvHN/cjdII1SSU5qZzP2524CDEuqVPHLnD/ Y6lU3Vv1juJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A7wAKCRCPgPtYfRL+ Tm9GB/4mE4RwhXz/CyJzR+mFdS6oldaSkbL0ziI1WpRhyQ6mwKF/uE6Qo6k1XGeUkLiNB2RpB5y Sf4DUeGKHwECLJ/rQ3kKPhpGO2oQN/vtmSOdpc65EpFHWKyEAXFkZ7oKUcbfB+rPptiXo3wQNQo hXzMJwssCkrtmN9NC43lra1MU+qoiD2glFkZi1E7gZLqEWXE+Qntxj4PSN++zWE3NaQiz0xl64B CxD6XrIOhPPWRvpQeUQcP7lkBVBifyr0b4HiSsg2zBfXQawRh7RAn2Tsj1BPxFyi9VihJq9yawf hpGsLG6K24/LN1y1bAgmcOefWFkl7kjiaD+FFduSWidFV7Pg X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 12:29:18 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782119671727897433 X-GMAIL-MSGID: 1782119671727897433 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/bus/hisi_lpc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c index cdc4e38c113e..09340adbacc2 100644 --- a/drivers/bus/hisi_lpc.c +++ b/drivers/bus/hisi_lpc.c @@ -657,7 +657,7 @@ static int hisi_lpc_probe(struct platform_device *pdev) return ret; } -static int hisi_lpc_remove(struct platform_device *pdev) +static void hisi_lpc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct hisi_lpc_dev *lpcdev = dev_get_drvdata(dev); @@ -669,8 +669,6 @@ static int hisi_lpc_remove(struct platform_device *pdev) of_platform_depopulate(dev); logic_pio_unregister_range(range); - - return 0; } static const struct of_device_id hisi_lpc_of_match[] = { @@ -691,6 +689,6 @@ static struct platform_driver hisi_lpc_driver = { .acpi_match_table = hisi_lpc_acpi_match, }, .probe = hisi_lpc_probe, - .remove = hisi_lpc_remove, + .remove_new = hisi_lpc_remove, }; builtin_platform_driver(hisi_lpc_driver);