Message ID | 20231109202830.4124591-10-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp689499vqs; Thu, 9 Nov 2023 12:30:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPYd9KJZLo4jiYgqsWdEUu23tVfMMezM0Nms6t4SeX35A2XwD6smKFbRIcfVsRn+cuGOt3 X-Received: by 2002:a05:6808:151e:b0:3b2:e3d0:863f with SMTP id u30-20020a056808151e00b003b2e3d0863fmr3206626oiw.13.1699561803159; Thu, 09 Nov 2023 12:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699561803; cv=none; d=google.com; s=arc-20160816; b=0EQyOpdCP3anwsbw8aaFWLW/tQkXYUJ860S8dZtjIF90/z61h9SAvVz3dFFZvaWU0j l1weLGkwOOhg12dV91faMynuFpzYiiddvmt+ahSSSu+p6XkeUcm4gTrLonZeICsP2Edh mgOb3r8XXM0vh8uJW1s/Sg015e/Kaf6JzrQNiHSbhQnEOrSxYOPH3v1wixpS58iEQ652 iCcirZzm+KbgX4Bdakc49wj0LbjNwHCQCyjHqiTBUIcomZIOpN9sjUhPuiaCaKsgq66r Ci68IUTrm6qXPODv0vsCJBj3iArlSHbzJL7HSrHjeZE1/DS29E0puK14pAbprY0vXBty Kfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=U6aY4DhqmPR5q1q5RwViTtrlssy3yUCEF25H7/PjiCA=; fh=bDLAJ+56j77yFU0DPQwHv9mNBorHGFxdCrU3vBMS5sg=; b=DHOiTzpM4imgCaGLmlIzfag1qP8bFf4/HiFC+qJBnPFODYaqiN+gW2jYpFpf3hnrVq aA4KUonfjLk6375Iz/ThT+tU1gCxg/Dv0b0B7cvOeY0T3s806N8HqU7MR2bMpvDLnygr aHOOdnxp0S8mUb/fECrL11kBuJueZiIzfJVGo20oDsi4Nr66cfZ8FQCn9BxORu2EhnG/ XliIC6lK52emCAt1hvMrDbFhLUCunGa4r9AACf71Njgjl0nHcDHeOaWG4yAotUlKG/65 9OGGRgxTpGOEhZopUYUa3HMywRoLs3g4atuiNzdeMEkK05Bk2W4RaGVOGmqjFP7TNbzk sR/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id v10-20020a63610a000000b0058a4883e6casi8048226pgb.225.2023.11.09.12.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 12:30:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B810F829B3DF; Thu, 9 Nov 2023 12:29:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345208AbjKIU3g (ORCPT <rfc822;lhua1029@gmail.com> + 30 others); Thu, 9 Nov 2023 15:29:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345200AbjKIU31 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Nov 2023 15:29:27 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8431A46AF for <linux-kernel@vger.kernel.org>; Thu, 9 Nov 2023 12:29:17 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1r1BeF-00030T-FL; Thu, 09 Nov 2023 21:29:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r1BeE-007rWz-Mj; Thu, 09 Nov 2023 21:29:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r1BeE-00GGtv-DS; Thu, 09 Nov 2023 21:29:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Arnd Bergmann <arnd@arndb.de>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Rob Herring <robh@kernel.org>, Yangtao Li <frank.li@vivo.com> Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 09/12] bus: tegra-gmi: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:39 +0100 Message-ID: <20231109202830.4124591-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1763; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VjQlvlUP0hSc0i1I5jF7v3psby2JMvMAnYEOoHbOgDg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD5GJFFr2+w/ToJXtwZlVXQtzp7LkRrRw5f5 SCYzSLnqbyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A+QAKCRCPgPtYfRL+ TmaCCACk8lIKtzEjK+HIAmy1UCWEfkh0YtAjwGTgmHGLU/63Bzs7O4EfTlGSgI6CU/WpQd2Z/oT /r/xL1aY6REcPoenUxW+BVtSQcGtBqYiXndadbyVwVDaMqIILZ+56hBkVqu2hoJG/KHagY79d/r 0LldtrxEaP8JmC7P2WQTqBYgkzbRrSesWHx9Sj7SfuXNVDlNLQXsJCnhyu5AUn/1jiSgr6KrdlI XoMbVVk2TDz+BGcFcgVKGaiUM9ZPVDPNtY79OZ9Wmj4VVlEF5x9w2//Qe+beNHlNYEHSCX4sawO pLN2cuvrxwAWCgJJtmEa8vRbXy30siMExPdKvvHYZQdMUr7W X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 09 Nov 2023 12:29:54 -0800 (PST) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782119717136777286 X-GMAIL-MSGID: 1782119717136777286 |
Series |
bus: Convert to platform remove callback returning void
|
|
Commit Message
Uwe Kleine-König
Nov. 9, 2023, 8:28 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/bus/tegra-gmi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c index 59919e99f7cc..f5d6414df9f2 100644 --- a/drivers/bus/tegra-gmi.c +++ b/drivers/bus/tegra-gmi.c @@ -258,14 +258,12 @@ static int tegra_gmi_probe(struct platform_device *pdev) return 0; } -static int tegra_gmi_remove(struct platform_device *pdev) +static void tegra_gmi_remove(struct platform_device *pdev) { struct tegra_gmi *gmi = platform_get_drvdata(pdev); of_platform_depopulate(gmi->dev); tegra_gmi_disable(gmi); - - return 0; } static int __maybe_unused tegra_gmi_runtime_resume(struct device *dev) @@ -305,7 +303,7 @@ MODULE_DEVICE_TABLE(of, tegra_gmi_id_table); static struct platform_driver tegra_gmi_driver = { .probe = tegra_gmi_probe, - .remove = tegra_gmi_remove, + .remove_new = tegra_gmi_remove, .driver = { .name = "tegra-gmi", .of_match_table = tegra_gmi_id_table,