From patchwork Thu Nov 9 18:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 163545 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp625631vqs; Thu, 9 Nov 2023 10:29:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjfiev/25VkRJ75/UNlJXouX2lUAOETTjqUFefjew82cKCI1nGq3VXwwLDfIyvanFKUTIN X-Received: by 2002:a17:90b:350b:b0:27d:20ca:1156 with SMTP id ls11-20020a17090b350b00b0027d20ca1156mr2487759pjb.34.1699554579749; Thu, 09 Nov 2023 10:29:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699554579; cv=none; d=google.com; s=arc-20160816; b=OMdmS7Qd2VFQyvTQqwmnE7O0GEQa+wMj1Mrl+/rXpwDAyEVzmarhUs2/p0Og4yQiXy 1YAffV/xCxQnuGE9JKnAiu+HhE46sRvyNazGxi1H1Vcvsw2cRq92XYybDH1suJODFcSt JYQ+BA5umqXmTph1ygqtY+64/o3DXbnIG6WFwbCJZWyg6HxtcZutrgJrCxxntQmkgTwm c8PgqNRfHFHONz4bdVy3PlMkqu7rmI2i5WWWK1bZjXzug3Ycaz/tfgY6ZwH0ro1OyjMH rHnIb5+ZwCANN96uKWSYFHnOrIwb0pxEQj5OtUcGmeN7x6mQfMGo/DM2bHHMNIvC80Xb BQ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BDtUIFYHtmTf5FeB16kQ+SpPx5UyjdUJCE3RpzWou68=; fh=mq6/FMGJdqTI0UuZRoAMccy9L/KbJAT6TPJFW+BrH4Y=; b=pI2/rXVDMB+uuY5pnEluQGO8/hipWq2iXkZunOswPu4um0I+ZrQ6ekkdSqvAA3k7wI xjr8YxNINDoqKcR84QY8dKllYTqPbEjwaDaC4td3f8tI8rJC1fHuvMbR8ExLFtYn3et8 +gKlQFxDFt4h+hyDIiKMW37HIbNxCs2DmtzV1e/ODp6pwap6OFllt54YwldWFYcowwrI G8zaBb4WC62vD6ZCnmqXfmJtS/vv2zpbAtJU7nGy60m9FhwlJ8XHCUTSvxHoRSgzW90R n7uzzQI/25OQlQW2ld/jGMS0c447fTUiNZFJSiCXOoUdmBnGJNshz8DkfRJwssCQtZRw fbEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UR0fdGAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id x21-20020a17090a8a9500b00280979dbb7asi2208601pjn.103.2023.11.09.10.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 10:29:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UR0fdGAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B783E81C778D; Thu, 9 Nov 2023 10:29:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345036AbjKIS2q (ORCPT + 31 others); Thu, 9 Nov 2023 13:28:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344987AbjKIS2j (ORCPT ); Thu, 9 Nov 2023 13:28:39 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D0533C04; Thu, 9 Nov 2023 10:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699554517; x=1731090517; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FNPib3amku2OveJFmG0UkpnYVRBDCdjSLX+9Rx4QUOQ=; b=UR0fdGArXXzlJXCCo2QGoWTMyMmbs5lH/eN9zPduIxFLylEq6wwG2KxY AO27OR5ExEsWORt1afx317bmEKSqFZ1CjkfCpvXKqy969jaShrAXm3jqu LuQocEQvJ1bw7il9IBMz+w0Br6+Lc991N8Pec/ItOBvIPhwt+ImakTHda TYpaIwLj8KxzUlwM1k9Qd7Vk/WJUNP2IcSCVd34amiUg7DOWR8FX0PnIe apajsKUciZByFiO+myunKMASGp4cIS9/21zvaTX/cLMe6Jl+18i7hWonI NXfi8e9nvrykBPyq5vinTsq1oc+ufCnLagwfpoBhN+aZzNeAH1BEb05pJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="375088668" X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="375088668" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 10:28:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="767086814" X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="767086814" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 09 Nov 2023 10:28:33 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6B07876D; Thu, 9 Nov 2023 20:28:32 +0200 (EET) From: Andy Shevchenko To: Jarkko Nikula , Herbert Xu , Mario Limonciello , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Hans de Goede Subject: [PATCH v2 03/12] i2c: designware: Drop return value from i2c_dw_acpi_configure() Date: Thu, 9 Nov 2023 20:19:13 +0200 Message-ID: <20231109182823.3531846-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1996.gbec44491f096 In-Reply-To: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> References: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 09 Nov 2023 10:29:25 -0800 (PST) X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782112143034640507 X-GMAIL-MSGID: 1782112143034640507 i2c_dw_acpi_configure() is called without checking of the returned value, hence just drop it by converting to void. Signed-off-by: Andy Shevchenko Reviewed-by: Andi Shyti --- drivers/i2c/busses/i2c-designware-common.c | 4 +--- drivers/i2c/busses/i2c-designware-core.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index affcfb243f0f..8d2223d164e3 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -255,7 +255,7 @@ static void i2c_dw_acpi_params(struct device *device, char method[], kfree(buf.pointer); } -int i2c_dw_acpi_configure(struct device *device) +void i2c_dw_acpi_configure(struct device *device) { struct dw_i2c_dev *dev = dev_get_drvdata(device); struct i2c_timings *t = &dev->timings; @@ -285,8 +285,6 @@ int i2c_dw_acpi_configure(struct device *device) dev->sda_hold_time = fs_ht; break; } - - return 0; } EXPORT_SYMBOL_GPL(i2c_dw_acpi_configure); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index a7f6f3eafad7..f4dc08139624 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -397,7 +397,7 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev); void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev); #if IS_ENABLED(CONFIG_ACPI) -int i2c_dw_acpi_configure(struct device *device); +void i2c_dw_acpi_configure(struct device *device); #else -static inline int i2c_dw_acpi_configure(struct device *device) { return -ENODEV; } +static inline void i2c_dw_acpi_configure(struct device *device) { } #endif