From patchwork Thu Nov 9 18:19:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 163544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp625577vqs; Thu, 9 Nov 2023 10:29:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8/dRx0ORK2keaz7E0e5lcYMMRBC5Af70b9Ih6IVLU306ye6QfMrEJTKLg8JESyD8MN6tk X-Received: by 2002:a05:6a00:311e:b0:68f:dcc1:4bef with SMTP id bi30-20020a056a00311e00b0068fdcc14befmr4216639pfb.7.1699554572376; Thu, 09 Nov 2023 10:29:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699554572; cv=none; d=google.com; s=arc-20160816; b=EGQGs946txttAuay4pEfOMaVtbCsLNcbT4YDrWLbPbdseVztS10v+/MgLFOuTPjOAG RHbN9mG5H2/761+EFZaphl0CzIRw6/C2oSMKaWzYUQ66WbzWElqKZzlww1EUr8/y3bV7 mSl2cWg8mJw5Gy50d9H64EShcXfqkhsDwUrsUtRFJA1oDpDaB3mcWYPRfJuBSGHGhECR Xp3K6WhBtiovwsGhepCkmeNKyK/ivhhV1W5Pgw9tf5PSoO6Bjqdyv36R4osmamGGb4fq gsCIGqwL4EfdD3vC63xuFnNgLEMdVSe9dmc1VJ3YPqeT+cPrK9z9Z4FqXOk2ezvsR6X4 xDQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9OkbwBDrZ4bSEVpJYTfFrjxGYkj35NxRlvyu6gv9oL4=; fh=mq6/FMGJdqTI0UuZRoAMccy9L/KbJAT6TPJFW+BrH4Y=; b=MsUuw59G2o/WS14Zk9ZhZGVDOydOnPiecvn3nP5+YAtXVxIxV9FBu/OhkdMfXRbf61 Yukpz4FUZFTBi9yoIntK7BQWGmHhtCrq0JhBoLGePsRIlNtnz/fgicC9UvszlCM0ziZf oY03HPKKAfoU7O6qPjLgqP8M3aGdjpsK0R7dAHQ8u1txycwRv2xSLwSFR6GZgTJPoUb/ IsIYA/nKsl6Qz1rKys6nVfuJ1VPCo+RY5jAUDklgcfgDEeH176Hh9w0Xp43d8cEdccN/ 94mmKXEUKbFkMhA3f6sNz0Lkti2ExK/aDCgo6ZecWSSXFzp1vexbEF/qm4H7aFFGtyWu KHrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=A5nk8Q5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y184-20020a638ac1000000b005bd052042f4si7989431pgd.69.2023.11.09.10.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 10:29:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=A5nk8Q5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C6AAE83C1E21; Thu, 9 Nov 2023 10:29:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345091AbjKIS3E (ORCPT + 31 others); Thu, 9 Nov 2023 13:29:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345021AbjKIS2n (ORCPT ); Thu, 9 Nov 2023 13:28:43 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D2E3C0E; Thu, 9 Nov 2023 10:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699554521; x=1731090521; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0y0h7BkktYSsLfLGZrjiG6Eoa1Wm0LmcKR98LPxa7Tg=; b=A5nk8Q5DqC9i3hMzuE8S6Lk2i9DbqOO9CIFDZfAkVSNWnyrAgdYcttOW GDB3VlnK6EuSiK1cxVZz3jW0HNvfuORYybO+6KpZbbS8temtFZGCXXS+4 Slo2f2BBfeyyxdzKYXOrF3M6v97bqo5RYHA5HT9gV14gyXW3XTHls6y26 S4htxSrFTrq3PwIo3LPPy9FC9FbtDoeOzQkdnq+L1qrXY5X1SaIubiEpQ I8viSmVq+AND7L17yzOGq/HwUmiqOZj+k9eUEQFH5ZiFp2Z0TQvZDgKL6 cYxBeukRxoeNzuIXtX6E59eDL1pz57RKvikb2mrEFjm4IXFiF46Qgo6u8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="389853931" X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="389853931" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 10:28:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="936938989" X-IronPort-AV: E=Sophos;i="6.03,290,1694761200"; d="scan'208";a="936938989" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 09 Nov 2023 10:28:37 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C9F2B81E; Thu, 9 Nov 2023 20:28:32 +0200 (EET) From: Andy Shevchenko To: Jarkko Nikula , Herbert Xu , Mario Limonciello , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Hans de Goede Subject: [PATCH v2 09/12] i2c: designware: Get rid of redundant 'else' Date: Thu, 9 Nov 2023 20:19:19 +0200 Message-ID: <20231109182823.3531846-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1996.gbec44491f096 In-Reply-To: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> References: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 10:29:14 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782112135463114544 X-GMAIL-MSGID: 1782112135463114544 In the snippets like the following if (...) return / goto / break / continue ...; else ... the 'else' is redundant. Get rid of it. Reviewed-by: Andi Shyti Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 50cf4cbfeff3..4d7dc346e619 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -638,10 +638,10 @@ int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev) if (abort_source & DW_IC_TX_ARB_LOST) return -EAGAIN; - else if (abort_source & DW_IC_TX_ABRT_GCALL_READ) + if (abort_source & DW_IC_TX_ABRT_GCALL_READ) return -EINVAL; /* wrong msgs[] data */ - else - return -EIO; + + return -EIO; } int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev)