From patchwork Thu Nov 9 15:39:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 163420 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp521418vqs; Thu, 9 Nov 2023 07:42:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFluB2nibHMHxdNP2XSpnFmy21qOqMedsP4yqlcUh/YIe5Ag08dYnFTfgc5nNCiqLP6McnL X-Received: by 2002:a05:6808:3986:b0:3b5:655b:2f62 with SMTP id gq6-20020a056808398600b003b5655b2f62mr2506568oib.31.1699544566401; Thu, 09 Nov 2023 07:42:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699544566; cv=none; d=google.com; s=arc-20160816; b=slJYWKzObLPf55ih3F7lSpXPenpQgUnY3AZ9Yz6ColUHpzwfajVvdVAUIuzH7YOo7c gqogoGEmjfbexFV3Hvpoj8upDIDdDKgmZu5ya1nBpoQZL/Z00SC/j7QGpnZHKVHWTWhW 1N8cbgmDfC1srK11+dcBU1zy+tO8sVh+MgDlA7CtHnO1z3naVjgCO5kzircYS3IJiVu4 aVwfUQum6RY0CxsWNokptg0BINR5Q11wMCs5H3HT3bcYfvGGk+xwjGRgOTlPwZjV1td2 bl7RNp0Ko5w60OzjAEnEg4rie/jp/tE4p1Yg4/lzV+7RzIzBBN1lGWKIPlxRinYrK6M8 SHHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oMEUTzsR6BWL2Y8gGq9CLutkwHjDQQmXKxyipnAz9es=; fh=x3EdO5jBXneObQGNjbPw0Ma+NPqF9mIEGlVG/oRzsAU=; b=hM4C+/HD+Zla8F5VRjfZPdPKOH0klvr/LMRPbcj46MtCKu2nEmqQBas2TNJKSQkgd0 hhPIDWf8+MBiIZPgo1zxBL8QqmhhBswwqGoqKM1vPaxC9wG2AfgOgocRkTniolkKWJn8 4UmJWnSYDHuH7LawkWv6Mqe5H3lRVKtCZRIHyBVx8je9XHvQQYr8zrWa8EMy3SYoarev PppM+Jz4bTTC14gzDYOSE8JaQ3EeyxPG4Zh9aijK2BeaeSJ4Iz1nuj3126KNPsYe+A7a 1tbYcr3vPsRiJYSHTjdj5VwYFymF5nyq+h316xclpMsumd85PftSnPrxi13lHmTp/KSJ p2gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ikpFh3NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bz14-20020a056a02060e00b005b92b048254si446506pgb.201.2023.11.09.07.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 07:42:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ikpFh3NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5242B80ADF0B; Thu, 9 Nov 2023 07:41:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343598AbjKIPlP (ORCPT + 31 others); Thu, 9 Nov 2023 10:41:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232294AbjKIPlJ (ORCPT ); Thu, 9 Nov 2023 10:41:09 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0ED35A8 for ; Thu, 9 Nov 2023 07:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699544422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMEUTzsR6BWL2Y8gGq9CLutkwHjDQQmXKxyipnAz9es=; b=ikpFh3NPAyVyegZYJHd/HbXNVE6yE0yP38mUZ6neIHl1CRCD3qhDxeQBN7ZR+WVZ7Gf8FU yOi0OOaoVH3250z+B1RK8Mb8RGx292FbbMikfzGyVjH+SmcpiyXRsQYA59NbnODgx8jmdx k+WQzs3ZYQ3h2E6A1EtRjnG6WHU78F0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-iUdFDdAyMq-SDIbnL3to1w-1; Thu, 09 Nov 2023 10:40:18 -0500 X-MC-Unique: iUdFDdAyMq-SDIbnL3to1w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26E91185A781; Thu, 9 Nov 2023 15:40:18 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44CE5492BFA; Thu, 9 Nov 2023 15:40:17 +0000 (UTC) From: David Howells To: Marc Dionne Cc: David Howells , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Suvanto Subject: [PATCH 05/41] afs: Make error on cell lookup failure consistent with OpenAFS Date: Thu, 9 Nov 2023 15:39:28 +0000 Message-ID: <20231109154004.3317227-6-dhowells@redhat.com> In-Reply-To: <20231109154004.3317227-1-dhowells@redhat.com> References: <20231109154004.3317227-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 07:41:22 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782101643285745052 X-GMAIL-MSGID: 1782101643285745052 When kafs tries to look up a cell in the DNS or the local config, it will translate a lookup failure into EDESTADDRREQ whereas OpenAFS translates it into ENOENT. Applications such as West expect the latter behaviour and fail if they see the former. This can be seen by trying to mount an unknown cell: # mount -t afs %example.com:cell.root /mnt mount: /mnt: mount(2) system call failed: Destination address required. Reported-by: Markus Suvanto Link: https://bugzilla.kernel.org/show_bug.cgi?id=216637 Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- fs/afs/dynroot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index 95bcbd7654d1..8081d68004d0 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -132,8 +132,8 @@ static int afs_probe_cell_name(struct dentry *dentry) ret = dns_query(net->net, "afsdb", name, len, "srv=1", NULL, NULL, false); - if (ret == -ENODATA) - ret = -EDESTADDRREQ; + if (ret == -ENODATA || ret == -ENOKEY) + ret = -ENOENT; return ret; }