From patchwork Thu Nov 9 15:39:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 163423 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp521497vqs; Thu, 9 Nov 2023 07:42:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5Plgmw40WXOU7HfJwJbJjki2DROfnbJ01qSOISw2MfayLKLRaWVguVbw/2xUGvKrowepH X-Received: by 2002:a05:6a21:18d:b0:181:1d71:7e27 with SMTP id le13-20020a056a21018d00b001811d717e27mr6386855pzb.43.1699544573603; Thu, 09 Nov 2023 07:42:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699544573; cv=none; d=google.com; s=arc-20160816; b=e7upsUF1yGQeF/TZT+b0S1olID9EA2MmRA33umI7eq75jyQfiOt58QYwViw7ZonLpi YWc+KItR5+XrIZktzrCZHupqKOHS2Lo3+YF8TTkN4J/DueGCM/0WNPFg2Gw0c1iVX+Gl h0uRIa+gIqNwOjh0JHeDzFTnmRlX+HXDOyy75b1iZPqB/iD1TgsoJQB7V95lri7ZML9h 9Pgl8VbBadzhyCccBHRNORiwL3Qftmao/vO1gldQeeaQ+Y15Zo2vFxd4VpFlCl2YrGUR lSGtbhOBw/AiBUeWWtLEWPCfSaiADgIxPxdgLDCkmRIaYL89VxaD4Dl2jfskBVo9GTSi vK0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X7Bf0ubKs0gVlk4Wk6PRRBohRtCmGnBr4pYSMKODaaM=; fh=9hT4l0EMR1D2zdgUoRXiqFwsybSJyrmM/FC/blQlPsI=; b=mmxqAHttahcFt9snZUBB7N3lH7lm9rZWf+PuV+/h4OOOC9U9dzcYlNiKh8sIYFdRQ9 ThTmS4aPL/6oGyFN1eguDgyLQ2kbubtY99ccYAsnFmIIX8v2KWyqYRLXKBMjPaJ3+hfZ Xv5LJtFLT+XFmetTOY1/TrMJ2sGhZHuyc37hku15X0fieuEtIP9xFujgSVgoaGfheApe ysqhNV6ksT0jrknAeScUq12qHvSH3Yn8OYOjGWHlAm8FzuEN3ySw5DAxKJBrQt0mAS/w qgdb3qD4JRux+jaMXwJkd3TIdJp62n7twig94p1KUfZMdkHeCa9LwjGKPkuvDTUBFoZZ Ys/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ex6YDh9t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j2-20020a056a00130200b0069100d1fc37si16017901pfu.49.2023.11.09.07.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 07:42:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ex6YDh9t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 71CC6836F172; Thu, 9 Nov 2023 07:41:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343688AbjKIPlz (ORCPT + 31 others); Thu, 9 Nov 2023 10:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234513AbjKIPlu (ORCPT ); Thu, 9 Nov 2023 10:41:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB2835AB for ; Thu, 9 Nov 2023 07:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699544421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X7Bf0ubKs0gVlk4Wk6PRRBohRtCmGnBr4pYSMKODaaM=; b=Ex6YDh9tl4+0UBcXDPZTtK2Mz+DMx4u3TpREai3QkAdllSsRott5KH42FkXbeNA8LxIPOD 7qcEj5JseRHPQQLrVe7Az9iguyVJ6Xup7svb6T3RzhgkB55zldxvWltUzNuV+zmW6De89x FsXQMtEopZW6UV1JkASlMxCp7aUmLlw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-AJOEPHdYNbKFuKRn6m8Zpg-1; Thu, 09 Nov 2023 10:40:18 -0500 X-MC-Unique: AJOEPHdYNbKFuKRn6m8Zpg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C635811E7D; Thu, 9 Nov 2023 15:40:16 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6C812026D68; Thu, 9 Nov 2023 15:40:15 +0000 (UTC) From: David Howells To: Marc Dionne Cc: David Howells , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/41] afs: Fix afs_server_list to be cleaned up with RCU Date: Thu, 9 Nov 2023 15:39:27 +0000 Message-ID: <20231109154004.3317227-5-dhowells@redhat.com> In-Reply-To: <20231109154004.3317227-1-dhowells@redhat.com> References: <20231109154004.3317227-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 07:41:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782101650969221025 X-GMAIL-MSGID: 1782101650969221025 afs_server_list is accessed with the rcu_read_lock() held from volume->servers, so it needs to be cleaned up correctly. Fix this by using kfree_rcu() instead of kfree(). Fixes: 8a070a964877 ("afs: Detect cell aliases 1 - Cells with root volumes") Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- fs/afs/internal.h | 1 + fs/afs/server_list.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/afs/internal.h b/fs/afs/internal.h index da73b97e19a9..5041eae64423 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h @@ -553,6 +553,7 @@ struct afs_server_entry { }; struct afs_server_list { + struct rcu_head rcu; afs_volid_t vids[AFS_MAXTYPES]; /* Volume IDs */ refcount_t usage; unsigned char nr_servers; diff --git a/fs/afs/server_list.c b/fs/afs/server_list.c index ed9056703505..b59896b1de0a 100644 --- a/fs/afs/server_list.c +++ b/fs/afs/server_list.c @@ -17,7 +17,7 @@ void afs_put_serverlist(struct afs_net *net, struct afs_server_list *slist) for (i = 0; i < slist->nr_servers; i++) afs_unuse_server(net, slist->servers[i].server, afs_server_trace_put_slist); - kfree(slist); + kfree_rcu(slist, rcu); } }