Message ID | 20231109154004.3317227-14-dhowells@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp522043vqs; Thu, 9 Nov 2023 07:43:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTmZBFIB8w7ftlcCcOBemKsqiSJSZhKZL7AViMRTABeG7JXOwQY4I1JW1mJ9RFwdG8rl6n X-Received: by 2002:a17:903:11cd:b0:1ca:362b:166c with SMTP id q13-20020a17090311cd00b001ca362b166cmr5921097plh.61.1699544631593; Thu, 09 Nov 2023 07:43:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699544631; cv=none; d=google.com; s=arc-20160816; b=mZFaei8VjD6Bq897GsW27p6fbJ+i/dhEHBUwil3HjMestuxvOgFcU9llyuB0xE0fjf /YqpU0ZsJFAT6iq++hj8S8BJeJmzj5QvOeEardXamgh1MYBl0BxFHShw+IqZonSGaxDm gX7zZHe1jaCWEdz/+NBnSR5ViShNRaiUAxBezbZbHn1WvymrYW2hgfZUSYmf2UMNOdFL niw0Ui5VvayRy7r0vdzygOCdVUehD01GYOocDR5hVprzWjc4S9ooYKPKjcBfBfsfsrPZ VVOwy4qTnsY7TtL3qLpUvaaW/KE7Uq2ydai1cBwZCj9UHEqV/u/ZadDOy80t+m4fVNuR +uww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nWgdpB1RBpu2oN1tZdpNZiyez3R7RR3/B1JgO269mJA=; fh=9hT4l0EMR1D2zdgUoRXiqFwsybSJyrmM/FC/blQlPsI=; b=F1gqZJB2dudvbKGEoUdGQ0Y7Bv2ghQxizoqxfGSzCeyTi4YtjySj7c3UUUG1sj/HYf 9RV+aIdCoPXvGO6zS7R0oKf3hK/hrwyqbZ/0TDc91LKW+zYvWe8tsEiXfQeRpVz/FYK4 TfTfeJuycZtpFutoxwt/gPlsFR4j4NYRGVoWvujXAi1hQCwQogsDJFmFy5SmSosSnS8O pvEv3Gt9zPXK5lX5SZrohcf2ytOaPAwxbsDKJSyT+x1sZPVtSDaqY5bN3Itr3tzpRxVq 5//SOp48qodC99fL+h8OHHQFeTnd5qJpB/DpcGzxf6CIDoaJh7VKBE623pW/QrWdUDRS Dxhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AwgipVyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u18-20020a170902e5d200b001ccbfb42dc2si5478415plf.480.2023.11.09.07.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 07:43:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AwgipVyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 995958311A05; Thu, 9 Nov 2023 07:43:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343796AbjKIPmL (ORCPT <rfc822;lhua1029@gmail.com> + 31 others); Thu, 9 Nov 2023 10:42:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343826AbjKIPmB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Nov 2023 10:42:01 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBC7135B6 for <linux-kernel@vger.kernel.org>; Thu, 9 Nov 2023 07:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699544443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nWgdpB1RBpu2oN1tZdpNZiyez3R7RR3/B1JgO269mJA=; b=AwgipVyHy4R3B9HkQP7PVK8fSFDBbMdrC5Atzb3ojKtiIbu4cVEuaOuuD/BI8SIU3Bit5y Ck+5ElbritTe9kLl06tzIKUKrtPUYdEn9uvkOunF4D2o0A3hHIT9tMV6uhfUA8wco7xdiw Z3kjxlrcrv0EoXJV5PxEcB/+2Te9zl4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-wr3d_UkmOfmwBt5SEoVuIQ-1; Thu, 09 Nov 2023 10:40:37 -0500 X-MC-Unique: wr3d_UkmOfmwBt5SEoVuIQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75D3290F943; Thu, 9 Nov 2023 15:40:35 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB5ADC0FE05; Thu, 9 Nov 2023 15:40:34 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Marc Dionne <marc.dionne@auristor.com> Cc: David Howells <dhowells@redhat.com>, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/41] afs: Handle the VIO abort explicitly Date: Thu, 9 Nov 2023 15:39:36 +0000 Message-ID: <20231109154004.3317227-14-dhowells@redhat.com> In-Reply-To: <20231109154004.3317227-1-dhowells@redhat.com> References: <20231109154004.3317227-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 09 Nov 2023 07:43:36 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782101711548243962 X-GMAIL-MSGID: 1782101711548243962 |
Series |
afs: Fix probe handling, server rotation and RO volume callback handling
|
|
Commit Message
David Howells
Nov. 9, 2023, 3:39 p.m. UTC
When processing the result of a call, handle the VIO abort specifically
rather than leaving it to a default case. Rather than erroring out
unconditionally, see if there's another server if the volume has more than
one server available, otherwise return -EREMOTEIO.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
fs/afs/rotate.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On 11/9/2023 10:39 AM, David Howells wrote: > When processing the result of a call, handle the VIO abort specifically > rather than leaving it to a default case. Rather than erroring out > unconditionally, see if there's another server if the volume has more than > one server available, otherwise return -EREMOTEIO. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Marc Dionne <marc.dionne@auristor.com> > cc: linux-afs@lists.infradead.org > --- > fs/afs/rotate.c | 6 ++++++ > 1 file changed, 6 insertions(+) OpenAFS fileservers can return VIO (112) either during an attempt to load a vnode or to store a vnode. However, most IBM AFS derived cache managers do not explicitly handle VIO errors and pass them to the vfs to be interpreted as a local operating system error. For Linux that means EHOSTDOWN. Therefore, AuriStorFS fileservers return UAEIO instead. Please modify this patch to handle UAEIO the same as VIO. Thank you. Jeffrey Altman
diff --git a/fs/afs/rotate.c b/fs/afs/rotate.c index 0f59f2a81f23..342afc951fe4 100644 --- a/fs/afs/rotate.c +++ b/fs/afs/rotate.c @@ -329,6 +329,12 @@ bool afs_select_fileserver(struct afs_operation *op) goto restart_from_beginning; + case VIO: + op->error = -EREMOTEIO; + if (op->volume->type != AFSVL_RWVOL) + goto next_server; + goto failed; + case VDISKFULL: case UAENOSPC: /* The partition is full. Only applies to RWVOLs.