Message ID | 20231109154004.3317227-12-dhowells@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp521723vqs; Thu, 9 Nov 2023 07:43:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHK3DxO5WaAmyfwohOr/W6eQyIW2Ds0fsEXKOy3kDkBgSvmq5byYezp5oW0Oxts2xzGQSK/ X-Received: by 2002:a05:6808:1414:b0:3b5:65c2:fede with SMTP id w20-20020a056808141400b003b565c2fedemr2300766oiv.16.1699544601413; Thu, 09 Nov 2023 07:43:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699544601; cv=none; d=google.com; s=arc-20160816; b=pt6vek9fiNI5rlbeSQpS5g30jaWYDA0UEYWpZxPylMTrC72Ds0LPbdeus12Yqx7bBk 8eER/5Qp+/2PUq2lzpcXBlqGWrv6HV40x4mQ3kaowTFbzRKLe7PBqDSvIAF8qlQ+Wjnd HkQpbWhAuW31qPsi7I9KrT5GzVTe5msyAWpkz2dJiAHRNjc3TiZ5TKfmCwPmh+U9gGDO 9d2ldbE37hLGTqqBdpVWBmM/SGLkYeBHJjlPav54FXyVr1Sgbar2LyzyYjOZTAr8Xbm1 VJ4B2YEMc4bBDkzL2TVTwaaemz+chJce/KNJ/+UgF5hbdxqoKffgxdL9tCjMeFq//chw IvaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vmvyNEq0mjAiqaSKGBoHUs1cA03yuKyhB0WO0XE/N4w=; fh=9hT4l0EMR1D2zdgUoRXiqFwsybSJyrmM/FC/blQlPsI=; b=zZ6ySnKXFa9BQdy4Y5vn/7K7aoT7tPy5AuI31KnPt4qe9PBPNXQpLRuQaaC71rfBiV yVx58Rm/oYq6A6yzuWrjVPWxtqgu8WNlr+M3841cgF0KSgE8fQOOdf4dn5+/2k8y3RkL 1gMuyFdQTvhdppedjisbRfpSq6hD8bmjaxvF0CRtSnfcDg6VXNTvXJcFG1iCMIJt+B4p Rb72oZa3FuL2GyTQjuAdiu/pPVg3/KA6OYjhe30FcsElQp5uU1Nn3F3LjvFJVjVYj3se nh3uktXjluw+CAXG2NFoZ6iR5ZuFYvnGwW/q4l7OrZhTg3FfCx5W4u7NAecxU1lro4a9 5JXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ViBIagmY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z69-20020a633348000000b0057795cb4f16si6789140pgz.684.2023.11.09.07.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 07:43:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ViBIagmY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 83F438374C8E; Thu, 9 Nov 2023 07:42:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343942AbjKIPmZ (ORCPT <rfc822;lhua1029@gmail.com> + 31 others); Thu, 9 Nov 2023 10:42:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343757AbjKIPmE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Nov 2023 10:42:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A3435AF for <linux-kernel@vger.kernel.org>; Thu, 9 Nov 2023 07:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699544442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmvyNEq0mjAiqaSKGBoHUs1cA03yuKyhB0WO0XE/N4w=; b=ViBIagmYmXmfvStrH7cQgu2AOoTiCizVQP59/ClsC4VSyea9hCKc7w/H5f5aMh6Mevao8x uswOfwpia0lIjSrVWNbIAs+38GY3JLIxo8uxZQFMphWJIhErDbOeCMLvwuKQqaGFvs/bsO TxsLU4MzcEIxPMlk9Wp2eZKN7Vxexf0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-4nh_J7PWP_WADuUUKjtDNA-1; Thu, 09 Nov 2023 10:40:32 -0500 X-MC-Unique: 4nh_J7PWP_WADuUUKjtDNA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C04C101B049; Thu, 9 Nov 2023 15:40:27 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 969C62026D68; Thu, 9 Nov 2023 15:40:26 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Marc Dionne <marc.dionne@auristor.com> Cc: David Howells <dhowells@redhat.com>, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/41] afs: Don't skip server addresses for which we didn't get an RTT reading Date: Thu, 9 Nov 2023 15:39:34 +0000 Message-ID: <20231109154004.3317227-12-dhowells@redhat.com> In-Reply-To: <20231109154004.3317227-1-dhowells@redhat.com> References: <20231109154004.3317227-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 09 Nov 2023 07:42:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782101679881002729 X-GMAIL-MSGID: 1782101679881002729 |
Series |
afs: Fix probe handling, server rotation and RO volume callback handling
|
|
Commit Message
David Howells
Nov. 9, 2023, 3:39 p.m. UTC
In the rotation algorithms for iterating over volume location servers and
file servers, don't skip servers from which we got a valid response to a
probe (either a reply DATA packet or an ABORT) even if we didn't manage to
get an RTT reading.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
fs/afs/rotate.c | 2 +-
fs/afs/vl_rotate.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/rotate.c b/fs/afs/rotate.c index 1c8f26a7f128..689acb0ad64b 100644 --- a/fs/afs/rotate.c +++ b/fs/afs/rotate.c @@ -426,7 +426,7 @@ bool afs_select_fileserver(struct afs_operation *op) if (!test_bit(i, &op->untried) || !test_bit(AFS_SERVER_FL_RESPONDING, &s->flags)) continue; - if (s->probe.rtt < rtt) { + if (s->probe.rtt <= rtt) { op->index = i; rtt = s->probe.rtt; } diff --git a/fs/afs/vl_rotate.c b/fs/afs/vl_rotate.c index af445e7d3a12..6e29272ffa8e 100644 --- a/fs/afs/vl_rotate.c +++ b/fs/afs/vl_rotate.c @@ -195,7 +195,7 @@ bool afs_select_vlserver(struct afs_vl_cursor *vc) if (!test_bit(i, &vc->untried) || !test_bit(AFS_VLSERVER_FL_RESPONDING, &s->flags)) continue; - if (s->probe.rtt < rtt) { + if (s->probe.rtt <= rtt) { vc->index = i; rtt = s->probe.rtt; }