From patchwork Thu Nov 9 10:25:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 163336 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp340057vqs; Thu, 9 Nov 2023 02:26:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYNbogHIo3sSftTsr5s4X50SWf4qXbADuaSe2tx7zQ3LruDR63HyCzINpLLL83BEj/pEw9 X-Received: by 2002:a05:6808:1886:b0:3ae:2024:837b with SMTP id bi6-20020a056808188600b003ae2024837bmr1383347oib.34.1699525596507; Thu, 09 Nov 2023 02:26:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699525596; cv=none; d=google.com; s=arc-20160816; b=y8dZu3T5bkO/+/lhlo1PSE9GC0Cd+yn64zNhRiguYEpr+dagdQXo+2TdOOGHmaUyXQ aRbbxfrZND2UbVT1Cz04+HDsZnlN/HysAeOmj8ozhnNBGY0xEEZ0lXxtT6nc1sa6r6p3 2bBL1v8bBToVpTn5Yrp72sDDHiRQ5W0MXqDYoCoWQ9n233WDPeX1aHJipcdmiUCQ95Y1 1k9RGI4ewKtHgoR8gZkdtrt8ArCgdsjC/BIY55NqrEGwzq3fDRKgWiBWU2cc31TI138s 7h8mtinJCPTOcs8Nye1Mj77HM1EbjAz/TSFgRudwRU0SnCemp7xwgQsDLUknkhUCBVmK 6UkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tcrowBGYuAH+MQ/nn0cyiOjIreHrxLa1GpoFeAYTrpk=; fh=tAWvjMAEmVD3R8FzmIRYzQIb+yW9J+gWZJ2R8deHkVw=; b=TQvCfUyBZp2MNC2GG3j9gQJaWlm9aLxT3IVUOiVXDQCgCmrjAAJXQMoFLcJ7jePy/4 AeiA7a6w7njH3lopEvRGUi5n0x6JtFbo16G6i8CYxjsnyUC9KXU4v8PPqrZ6zJCDE8oP yn7D2RiKh0ZWvng9UZHkJ4YOwT7VzUpjfuc8mTQKPnoCCgSTqrqKzwhjbnUlJ0qSRDTl cCL6ZA+evOvsB4Mr0Bz0b47tYCBoSSEp/bg8gtTxKm/vS8XQAZT13XcfX8WieT7zjyMN OokTvl+1bWKPqkCQRoIQfaYBE5w9VDK20/tTpDenkBWJhDN803ZGa5uIthWLDwvXri6X rGxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kqsJ6nVo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id z65-20020a633344000000b005bddee56e49si3156082pgz.72.2023.11.09.02.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 02:26:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kqsJ6nVo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2D14B819CC04; Thu, 9 Nov 2023 02:26:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233317AbjKIK0N (ORCPT + 32 others); Thu, 9 Nov 2023 05:26:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233395AbjKIKZ6 (ORCPT ); Thu, 9 Nov 2023 05:25:58 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860BE2D6A for ; Thu, 9 Nov 2023 02:25:55 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6B60E6607691; Thu, 9 Nov 2023 10:25:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1699525554; bh=mDPKNF83uvk33KrukPYl2Hf3G8HMp0A70irMrDutJLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqsJ6nVoRmEFtUhcnVFDAjprHsWTYSDkz4ZXgM6GLZv3eMK70VxWuCQshbrnZYB2X bFPG+HuoXHQJraSZV26yrDXBHO+J3ANGvYawbFDqEwKxW/wAkOPZEbBx4vNs5vHLfu Pq9IgeN89QL9Vow0QkgqF5rMZOnIIfJmclvlVSvGJLJfLtOoZdWVzaYEyzOGXFjEQ/ nk0BhqGKD7dux/fTnvhHOFSHBcVMpquJ9OUHFFix/MhGk2zkNKP6GnEapX1lG3lHu0 iJPrQDzGtCh9MHPTU6RQxbpoNI6GFbWmdlR+rhwzbpOs+rLjnTTMx4JtxPi95mnLW8 +9ZzLvLKCVXLQ== From: AngeloGioacchino Del Regno To: boris.brezillon@collabora.com Cc: robh@kernel.org, steven.price@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, wenst@chromium.org, AngeloGioacchino Del Regno , kernel@collabora.com Subject: [PATCH v3 5/6] drm/panfrost: Implement ability to turn on/off regulators in suspend Date: Thu, 9 Nov 2023 11:25:42 +0100 Message-ID: <20231109102543.42971-6-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231109102543.42971-1-angelogioacchino.delregno@collabora.com> References: <20231109102543.42971-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 09 Nov 2023 02:26:34 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782081751898794713 X-GMAIL-MSGID: 1782081751898794713 Some platforms/SoCs can power off the GPU entirely by completely cutting off power, greatly enhancing battery time during system suspend: add a new pm_feature GPU_PM_VREG_OFF to allow turning off the GPU regulators during full suspend only on selected platforms. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_device.c | 19 ++++++++++++++++++- drivers/gpu/drm/panfrost/panfrost_device.h | 2 ++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index b4ddbc3b8069..c90ad5ee34e7 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -431,10 +431,21 @@ static int panfrost_device_resume(struct device *dev) struct panfrost_device *pfdev = dev_get_drvdata(dev); int ret; + if (pfdev->comp->pm_features & BIT(GPU_PM_VREG_OFF)) { + unsigned long freq = pfdev->pfdevfreq.fast_rate; + struct dev_pm_opp *opp; + + opp = dev_pm_opp_find_freq_ceil(dev, &freq); + if (IS_ERR(opp)) + return PTR_ERR(opp); + dev_pm_opp_set_opp(dev, opp); + dev_pm_opp_put(opp); + } + if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { ret = clk_enable(pfdev->clock); if (ret) - return ret; + goto err_clk; if (pfdev->bus_clock) { ret = clk_enable(pfdev->bus_clock); @@ -455,6 +466,9 @@ static int panfrost_device_resume(struct device *dev) err_bus_clk: if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) clk_disable(pfdev->clock); +err_clk: + if (pfdev->comp->pm_features & BIT(GPU_PM_VREG_OFF)) + dev_pm_opp_set_opp(dev, NULL); return ret; } @@ -474,6 +488,9 @@ static int panfrost_device_suspend(struct device *dev) clk_disable(pfdev->clock); } + if (pfdev->comp->pm_features & BIT(GPU_PM_VREG_OFF)) + dev_pm_opp_set_opp(dev, NULL); + return 0; } diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index d7f179eb8ea3..0fc558db6bfd 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -28,9 +28,11 @@ struct panfrost_perfcnt; /** * enum panfrost_gpu_pm - Supported kernel power management features * @GPU_PM_CLK_DIS: Allow disabling clocks during system suspend + * @GPU_PM_VREG_OFF: Allow turning off regulators during system suspend */ enum panfrost_gpu_pm { GPU_PM_CLK_DIS, + GPU_PM_VREG_OFF, }; struct panfrost_features {