From patchwork Wed Nov 8 11:34:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Luo X-Patchwork-Id: 162992 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp849852vqo; Wed, 8 Nov 2023 03:36:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtBQ5IXmypo3iW0d7nHSt00EEY4pS16L99IArje5oYw2GCC1A6VUTWntsASv1O2sZB370t X-Received: by 2002:a17:90b:390d:b0:27d:4b71:ed17 with SMTP id ob13-20020a17090b390d00b0027d4b71ed17mr1322199pjb.29.1699443387033; Wed, 08 Nov 2023 03:36:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699443387; cv=none; d=google.com; s=arc-20160816; b=YLLKfN7hfkBGeR6TXyadl4/DJPeJKaZ+dfubkmzJLJqq7yyDgfFyqtRDgG20OaGGHO Vt5uuda4MdJGpfP63rnuVRgjHNQEIQjtWJBuiQjZyvCquzSYkxT5yt4VsA+FSek5MP5Q L2f6qFMB4hGHJfyiA8m6ErsrBDXXrK23/LkgXt6utVFMcKfZ9D/pEWX+0h1zHW3KzUYv NbnbYM42tdHvzGp029iLfX7awQ+fIw2/NzQhqNDl24JMHhIDPVBPkiw50zR7gHQLFbOY lLAonvfl3cUfYuLMl1mfWxvCc9LRON0eplvBeayr6ZYB9/T6XS/OXQCZqbM0Zrbbi/2j kAMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Hkwju9EcLBdYO8vsxdmT7ILikUmnGUjApf76XNlufe8=; fh=SRY8/p+PzzHTptcO7IUDl/XG/bg89PEmkgToMpWxWh0=; b=mQJyh7xBfcc0QvaAoDZmqpCVtyGcWoY6E/9UnpC4CQLbwQpqWJkAsclkD8cxvGzVzV VsrPiY3EeYpm/pR4elTs7lJxDP4WHyZWgWarvJeN7n6sax80SWf4kmwxyQJnt3OxhoqB 7gV0DJecKg7q18aSJtanOOEwUvdXJASQrFgJmPAnVEby4xPJ8vR6w1D+4sndyl1RCJRf 9lHu59jZMXWTqg9GUCjZx+BEqFEhH+WPb0ospmWwSiLuvM4lHORTMWZYy1KnwP9rcjon /DrylLRNUGHJ8GdZwIJNKhSrXbMRdjSouKb9T/Nhw2YrtfM1K+5ot7aorACeiIQoClQv aqtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=exO10LX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s10-20020a17090a6e4a00b0027763b64ea1si2135435pjm.44.2023.11.08.03.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 03:36:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=exO10LX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4EABC8090E9B; Wed, 8 Nov 2023 03:35:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344193AbjKHLfV (ORCPT + 32 others); Wed, 8 Nov 2023 06:35:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbjKHLfU (ORCPT ); Wed, 8 Nov 2023 06:35:20 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB40125; Wed, 8 Nov 2023 03:35:18 -0800 (PST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A8ADVdD021577; Wed, 8 Nov 2023 11:35:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=Hkwju9EcLBdYO8vsxdmT7ILikUmnGUjApf76XNlufe8=; b=exO10LX51AjqAGf4nh9xl0h9QcMCUQOpTTjsNq+xWwk5Wh2Xhd7QqlyO6IAOpYN3Snq6 m8kdM+01eUUWe56SxCTgy5SQNkVwjlhUdEY4f6qeGFf462IkKTePIE+PkpJFJtVYlkLC hOZNnkrq3h0jhkSO+9tt/EL2QqVjL8vkZpJSZxaAXm03pM6OWuRmE0jtnVbetmwWkC70 5WEDsHFsyNF135tLLyFTtHN6/n0JpWsHXJujIcnovR1XSVvABhRsbILCBSTXQ2RSOr23 FVopRR/+ew7HxpoaUDxDX3gzGbXmIUgEwyDSRe6/Cm5ZiqfBIK94BaabBD0gruY9ybjw Wg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u7wvshct5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 11:35:08 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A8BZ7xN000523 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Nov 2023 11:35:07 GMT Received: from akronite-sh-dev02.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 8 Nov 2023 03:35:05 -0800 From: Luo Jie To: , , , , , , CC: , Subject: [PATCH v2 2/3] net: phy: at803x: Add qca8084_config_init function Date: Wed, 8 Nov 2023 19:34:44 +0800 Message-ID: <20231108113445.24825-3-quic_luoj@quicinc.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231108113445.24825-1-quic_luoj@quicinc.com> References: <20231108113445.24825-1-quic_luoj@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fvOzj9TMZvlQ-kSYs1a4LdvOUxBGDe7w X-Proofpoint-GUID: fvOzj9TMZvlQ-kSYs1a4LdvOUxBGDe7w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-08_01,2023-11-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311080097 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 03:35:44 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781995549322078810 X-GMAIL-MSGID: 1781995549322078810 Configure MSE detect threshold and ADC clock edge invert. Signed-off-by: Luo Jie --- drivers/net/phy/at803x.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index f2a0d1688159..6bea6e31caaa 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -280,6 +280,15 @@ #define QCA8081_PHY_SERDES_MMD1_FIFO_CTRL 0x9072 #define QCA8081_PHY_FIFO_RSTN BIT(11) +/* QCA8084 ADC clock edge */ +#define QCA8084_ADC_CLK_SEL 0x8b80 +#define QCA8084_ADC_CLK_SEL_ACLK GENMASK(7, 4) +#define QCA8084_ADC_CLK_SEL_ACLK_FALL 0xf +#define QCA8084_ADC_CLK_SEL_ACLK_RISE 0x0 + +#define QCA8084_MSE_THRESHOLD 0x800a +#define QCA8084_MSE_THRESHOLD_2P5G_VAL 0x51c6 + MODULE_DESCRIPTION("Qualcomm Atheros AR803x and QCA808X PHY driver"); MODULE_AUTHOR("Matus Ujhelyi"); MODULE_LICENSE("GPL"); @@ -2077,6 +2086,23 @@ static void qca808x_link_change_notify(struct phy_device *phydev) QCA8081_PHY_FIFO_RSTN, phydev->link ? QCA8081_PHY_FIFO_RSTN : 0); } +static int qca8084_config_init(struct phy_device *phydev) +{ + int ret; + + /* Invert ADC clock edge */ + ret = at803x_debug_reg_mask(phydev, QCA8084_ADC_CLK_SEL, + QCA8084_ADC_CLK_SEL_ACLK, + FIELD_PREP(QCA8084_ADC_CLK_SEL_ACLK, + QCA8084_ADC_CLK_SEL_ACLK_FALL)); + if (ret < 0) + return ret; + + /* Adjust MSE threshold value to avoid link issue with some link partner */ + return phy_write_mmd(phydev, MDIO_MMD_PMAPMD, + QCA8084_MSE_THRESHOLD, QCA8084_MSE_THRESHOLD_2P5G_VAL); +} + static struct phy_driver at803x_driver[] = { { /* Qualcomm Atheros AR8035 */ @@ -2274,6 +2300,7 @@ static struct phy_driver at803x_driver[] = { .soft_reset = qca808x_soft_reset, .cable_test_start = qca808x_cable_test_start, .cable_test_get_status = qca808x_cable_test_get_status, + .config_init = qca8084_config_init, }, }; module_phy_driver(at803x_driver);