From patchwork Wed Nov 8 10:43:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp824686vqo; Wed, 8 Nov 2023 02:44:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHs7DO12j0IB68vShrVAuTi3vsKwLjtPVYnTVe2zuDKUk0hlxob20patKflbHLyXN1gvH/P X-Received: by 2002:a9d:7c97:0:b0:6d3:2920:a5bf with SMTP id q23-20020a9d7c97000000b006d32920a5bfmr1666704otn.17.1699440261184; Wed, 08 Nov 2023 02:44:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440261; cv=none; d=google.com; s=arc-20160816; b=iKA0ebeoOGX/7X1RjH+cF0Tj/Cz8XinNEdJml7E0iHn8mz4ZyY6Ucv6tM3BssamGKG 2+nn0vBBRnzgQCQNYXfZdBT1Yv+iRG7juZaX/MdaJpxo69+LPOuI3GbH+1qkq9qtvIAG S4MaUkDYstBx0N55yuV+N+VqrqnL8DnVsSAFgM3Nni5nuXbWGMklWZOQLSYbnExFz19r g5tq82QO+TveT7w5xl+VgoJMhFoRAh+3wrY5VoLRvg90gp7nSNec38xx7E5P/ftDCdg2 OY/S+++xzzmNcODAy4n2lOebxVWGd6blnNlrd+cvno+sqg9xHkT3wKJKuLVDwXdubhP0 YRtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=glm+7wRQeNf0tFw6QiglaBDz6GEp++9HOuAC4cAKdfAJGEVVF9TzicZS0ysNHC8qGy +n5nGxZGNheYOajzicN3LFHQYmDpoxNPqi90hIl0HH2eeTP83tAhE9Wx342J+S7fli0H WFg63FyEO60pTbi2vlUTx51DdUKs6cCLL+Jq8oUMjBrrQTAB9GZSh1dzQSNAF89SVhPn JvbjW41Wdc6inXE4SAfWAKY2BfZg1bwN0lccFaXi0xk3tjF8wAqhCzr+Es6nT3uAbItr sz4rak/nJ7bqZxcLwZwKqU4//Nn3BPzC9FrWcAIMw7Ui6dZjY6WPN7GqxHYy/b07SUoi 4dhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gzxIIeQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m17-20020a656a11000000b005bcfc4fffe4si4712997pgu.187.2023.11.08.02.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gzxIIeQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 67C27832828A; Wed, 8 Nov 2023 02:44:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344412AbjKHKoR (ORCPT + 32 others); Wed, 8 Nov 2023 05:44:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344409AbjKHKoL (ORCPT ); Wed, 8 Nov 2023 05:44:11 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC111BEE for ; Wed, 8 Nov 2023 02:44:04 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40806e4106dso3791745e9.1 for ; Wed, 08 Nov 2023 02:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440243; x=1700045043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; b=gzxIIeQg7kmIq+J/1qyYsd7C2Y0mjzTiwTc/iUmljKVSG3mAPxaI0vNNugUzZ1UmNR spAQTZFsp8gAF4B73ad/DFwPjF1XcrSS1cNEz20ht5Wu1+mN4OCsYmJfoyPQXJxA1i3n IypCSAisty5f78tqwBTFKrM9tMUneNSo1ekX4TckvN0Tff2+CvxvFGsRKF21vmXkhneg xCltLXBvdQ5mLSHjPgKRq/czJaUAMvfqb/XkYQ5WVGdIv8RH/7T0obJ+LquApKptyTSF l7IQ5pKKaP5FQzbXO9+76ZKtknu/Zu425iLODdffCCXqdZxnefTofVazXpsYz7P27MV6 HOaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440243; x=1700045043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1RgzV0IV23WRll6q2E++ToH69k3tzXfaVshdvzq8RwE=; b=gbrON4n3zcbWQdMtj5z8PHRmXEkrbOK9Xxyf4VoUcJeCCtrCRIXLBxtL/V/llhTyGd duXEmk06wJzqR6jjIbd+Hd0HOO98b0dFB2GItUhWIcWW0QujD1B/pJNK1kdB6Y3q1zZh yhBo9voYfGJU8hcHQ6xKORNtQ31vXVIwpBtkW/WjOapqc+Vxn1IMFR+NJHL1+OBxXzv/ tO+6v32Mwv29QwIpStQQaPnZhqFpzsQ5/qo19zDAoPKdjmnZyjULtLBqnARjpBNXe2Ob ZGC0eaFbevlPV4rv46jiA4FJ5KRolX86aEmLtL+vyW25qWWmz3FLQoCmVyC6M9XFZ+NS MI5A== X-Gm-Message-State: AOJu0Yxk5kZlQMGtECeuTPrX0iDVqr6oAvaWpP+TCIlKM3o3qktKuxq3 F0HEvfQCDTAGmq39UJQxLLtneA== X-Received: by 2002:a05:600c:474a:b0:405:3924:3cad with SMTP id w10-20020a05600c474a00b0040539243cadmr1830807wmo.15.1699440242620; Wed, 08 Nov 2023 02:44:02 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:02 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:28 +0100 Message-Id: <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:44:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992271740693554 X-GMAIL-MSGID: 1781992271740693554 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Wolfram Sang Acked-by: Rob Herring --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++- .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml index 3e52a0db6c41..c1f5d2cb7709 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml @@ -25,7 +25,15 @@ properties: - samsung,exynos5250-hsi2c # Exynos5250 and Exynos5420 - samsung,exynos5260-hsi2c # Exynos5260 - samsung,exynos7-hsi2c # Exynos7 - - samsung,exynosautov9-hsi2c # ExynosAutoV9 and Exynos850 + - samsung,exynosautov9-hsi2c + - items: + - enum: + - samsung,exynos5433-hsi2c + - const: samsung,exynos7-hsi2c + - items: + - enum: + - samsung,exynos850-hsi2c + - const: samsung,exynosautov9-hsi2c - const: samsung,exynos5-hsi2c # Exynos5250 and Exynos5420 deprecated: true diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml index a6836904a4f8..5b7ab69546c4 100644 --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml @@ -155,7 +155,7 @@ examples: }; hsi2c_0: i2c@13820000 { - compatible = "samsung,exynosautov9-hsi2c"; + compatible = "samsung,exynos850-hsi2c", "samsung,exynosautov9-hsi2c"; reg = <0x13820000 0xc0>; interrupts = ; #address-cells = <1>;