From patchwork Wed Nov 8 10:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162941 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp826484vqo; Wed, 8 Nov 2023 02:48:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7IxMQXjNx+t2IsHzamEyBINoOpYyxw1BSEIP8BOVSpaNWxpjmwGfb8Z89ppbIDDsCIbbE X-Received: by 2002:a05:6871:8d8e:b0:1d7:fe1:e294 with SMTP id tv14-20020a0568718d8e00b001d70fe1e294mr1122222oab.34.1699440513863; Wed, 08 Nov 2023 02:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440513; cv=none; d=google.com; s=arc-20160816; b=VR0mDlf6HkN+Rz6nlWPASpRG+hnra48pBQMlUyDWBSd9TCNm1MPUgeNjv0rCrzvNmh feA9k2jkLOr90zsNfxVYNG2MRPekIQbA9upGzrJPOyVdqGFP7bomC1Ch2m5kV6ZChyYl h9dt0mTwrNgYAGKy5Ej9tb0s3tr7w+ve6WRKVS8yV/yk5hw1dijAlJCqTloQnBMM/Vxg IsQxbub7Yhuw+L0zlMk2KJHXANDGgk6Kwk4UGLkzaEijgtS5I0bqeRrW46u1A2reucJc C8L6XvlsMtwIi2B1VPJC99+XQlTs5HXR/ihBzfF+xR5/dy8bZHrdKlUGHLShTYSOT2sy TU4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=KKtEoyRmQpMr9WtYUnwfhTYFK/oqXQG80MtyVyHWL48kk+YVfomnlDvzT5Vgo99mDZ GKhH8BVXo397EvFSovZA7+KXi6MMOzDdVbAcfMTP1ZFUHi+JkZefasruDybPKjtReFMh 9FWiau0+HhGMZCucbkaCnYVJ/ysibBXP7TbV71OV8xEihtzF2bFyBscH+nTnmD/PYpu3 g6LDPVQu9YAUKl0tP8yBCLKzL+YkjvDv7TG+oRrGhecaGfEGyds9YDRPaiUz5Z7P1NXn 0fDpUnPFZR9j2Zt85n3y7Noebx0wnbfYF3LPIl10bdSkz+Ep+LD7JDUcZgPyDEuYPBk8 uv3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W2x3r7qu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bg26-20020a056a02011a00b005b96cbfacdesi4276329pgb.196.2023.11.08.02.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W2x3r7qu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6463F8024B3A; Wed, 8 Nov 2023 02:48:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344402AbjKHKsI (ORCPT + 32 others); Wed, 8 Nov 2023 05:48:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344655AbjKHKrD (ORCPT ); Wed, 8 Nov 2023 05:47:03 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 517A830EE for ; Wed, 8 Nov 2023 02:45:00 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-408002b5b9fso49506255e9.3 for ; Wed, 08 Nov 2023 02:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440299; x=1700045099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=W2x3r7qu6kvAoa6YNUPIxT0E6KPjTAYklsVnKTofKbvAg98XR3knJImbMSgo8hvKwD 8LPnlco7wqZc3KdQicPsuekNV4vgonbicgUT/H53JS0/P/QvrNlvG1eSi2OePM7I5hBi K0CXhuHss8MvHXmw+sfOkMh3fetSIT7KhOE1xg10HLX1eKVCxy5o01+PWijCDAsNkCCh t9awT+KNIKzM6znauX5Pccw990RIB6oZWUMb4DZb1vFwumRUWWCM0QtHALYoYeI0gZBZ e3Z0tjmeqCngooyJFnIvo8IW24JaVkqJVRV34uVnhTkFDRByRlLirP6uwwJcpumE/8k1 ydQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440299; x=1700045099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQ+G5s8RPHyPJsrBFGNZYZXOAO3f3klrHmjNTSjaK6I=; b=FUAc6Rd0fX/CE91hyki5Gd1LYbXkegE53jn3leP50dVJgVjOtvgxtzbDsRg+K2uCvO 9aZPVcx8MTzz6TYEKvSF/19eJ53JIdCS6VHOiCoBE9lV1q9IZssbmplQJA9H0yO+2Of/ qmSjOsCeDUcaZ678PIGcvlH5JAwVbSwC358Cg7QdggSkwz+/MXV6wZZ81gZX4ZG2LKff KPc6QuOtWPuBJltjiqVGYXSUUAPq+Coifa5/15dcTc9vqBIbn6nKTZZ8TMd5N5J532cj dblhiWblk9NsuYkn/nsQ50zKzEQVhT0XeafaM+/azRHjexT6siK+ASQ8g0m5LB54CphR r81g== X-Gm-Message-State: AOJu0YxzA+dudl7uG0KgbaJ1pQsToTpIftRN65i6C3o+X2fD+nCW7XjG kyA0HL8MlbYrdbz1UaBxOijuaw== X-Received: by 2002:a05:600c:3b15:b0:405:95ae:4a94 with SMTP id m21-20020a05600c3b1500b0040595ae4a94mr1341542wms.5.1699440298865; Wed, 08 Nov 2023 02:44:58 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:58 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 17/17] arm64: dts: exynosautov9: add specific compatibles to several blocks Date: Wed, 8 Nov 2023 11:43:43 +0100 Message-Id: <20231108104343.24192-18-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:48:30 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992535932655436 X-GMAIL-MSGID: 1781992535932655436 ExynosAutov9 reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to ExynosAutov9 in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index b228cd7e351e..417aa56a81f6 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -166,7 +166,8 @@ soc: soc@0 { ranges = <0x0 0x0 0x0 0x20000000>; chipid@10000000 { - compatible = "samsung,exynos850-chipid"; + compatible = "samsung,exynosautov9-chipid", + "samsung,exynos850-chipid"; reg = <0x10000000 0x24>; }; @@ -349,7 +350,8 @@ pinctrl_peric1: pinctrl@10830000 { }; pmu_system_controller: system-controller@10460000 { - compatible = "samsung,exynos7-pmu", "syscon"; + compatible = "samsung,exynosautov9-pmu", + "samsung,exynos7-pmu", "syscon"; reg = <0x10460000 0x10000>; reboot: syscon-reboot {