From patchwork Wed Nov 8 10:43:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 162938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825922vqo; Wed, 8 Nov 2023 02:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDbFhlBKD27jdQeih1pvRFYSC/fYGb5No1ypw43fZ+aDjr3N1+du8BjOdbRhxxK8HW1M+N X-Received: by 2002:a17:90b:4a0a:b0:280:2935:af23 with SMTP id kk10-20020a17090b4a0a00b002802935af23mr1398744pjb.5.1699440450355; Wed, 08 Nov 2023 02:47:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440450; cv=none; d=google.com; s=arc-20160816; b=xVLXVcVIswfwiFRCFjr8QLuNL4Y7xrvWdnN37KoykHzds7UkalUEKeEZUZCHpAlare M0cR6JWDVTmYhBs4NYvlNYVHd5wZMOH4Vl5I5DPDfald0uIW1BIUluWzGfzpSw9Z4yEo +p3eiL1/9DGTS9BYMKy08mD4Fsv3gtm/2muyS7Jr4CjUqWBUr4EZ68lncBO3VCtFrqLp rtUn7oI196xRutG0pwGI2wkOozbgUEED9AKdmsjqUB39oZmVVMTCs7djll+6c5gHYw4C FZ0GXhTIN8qmsWkzxNia5yZ4RD79YQuKs19mVYNWsjKCTouC891eSJa9iZg4aBdNdqAv XUiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=BpV1lG1kwXXnxSJe0s6Pi9v2QhQgJfSNnMwcjO6Ihsmc1MUJkesK8ZNNr0LW026zt4 qkv1/kYYYPtg3wJG1N47scChqHIIm8DbIrgpy2WOcswVaeU8TKlPILuKUnwh+wPP36s7 IeyLvQ8tenz+QpEgSsXbkGN63T5Fd6MSbgn+O0iEZ1qyh3ythGWJAK7YHNNYQDA8NUXM nOTz+f8wBD9kiyuh6qvAXKGoqi418M2ElllRg88sujGgQQmUWdTLkVRcCWbQTyS8HsvT jFuzMCB4iaKqKPfSv7Kfw+lBcq8ZQuTdnOdRe8mpb/epa1cdu0/EbVyIMRj3ckrgrtav zdzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Psapt02Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id o12-20020a17090ac70c00b0027d4f7298e2si1913048pjt.65.2023.11.08.02.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Psapt02Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id BC5308246E1D; Wed, 8 Nov 2023 02:46:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344707AbjKHKqU (ORCPT + 32 others); Wed, 8 Nov 2023 05:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344410AbjKHKpg (ORCPT ); Wed, 8 Nov 2023 05:45:36 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0722269D for ; Wed, 8 Nov 2023 02:44:37 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32da4ffd7e5so380772f8f.0 for ; Wed, 08 Nov 2023 02:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440276; x=1700045076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; b=Psapt02ZaVLYsotjjTD3flBAqRFY0KEBdrfcegaOovtOOXrzFO+KY8ERw1j9pOotqA FiqBSylaG1c3YrVAhmtRcDO/jNV3aDi8brvU053zkAUutA6JjFmXbNKOLhmJZdNHF0hp a0uzHxZjXSywAjad6U0RSLJIvuI4FXbiN5OYGVrfnkXGyqTvfOhEhUKZPcUhDxCor82q Vq9L+XnHYKeZwAZeTBnM9oI3wqfLhn/ER/0Cias06jSUMDSJcsdvDWOwJeuRMgr80wDh WH3QP2IkbtlJhcjB8sxFZVSfJbIt2vIcPkPWjtelwWizbj7igEJgYCAxAYKEMgS5ZuKy cXvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440276; x=1700045076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=; b=Vajzc3yeZpeN+99Hdqui1J4AKiihcIeImImD6ATQdvfgWkjNt5Oe1Qsh6MEp/qiDfX mV7fBaGV05dcDmNR26DT/nv0qrw2Wvgo2TjdpNwIVQNX4vdbTKl5u3+Gkvm+4MYnKgu0 ijtR+tYPyoI6qdRA7aCxWbr67euqixjH9caxHp6yJRu9xZ7GZfzqmhTClgGjvdPmIgco d/WNtKGPF2cgqeg4meZADEserQx21lajxc63S2QGEq7n4/URrpX6zzDO2pJTfYP6ewGP 7pazhS47U+GPzwU3v0WOMIJhNylNPKdowLohSlOZQ50xc9RgAeZs8z2nHMwU1E6Ivcid 09AQ== X-Gm-Message-State: AOJu0YzB2xvOp4x1UfWbhQlq6Nl/LPVNFET0G7PHrymV3UxbGWl5ItC4 DOTEbzEdZNDDPnyEs+DDUF5RKQ== X-Received: by 2002:adf:fd09:0:b0:32f:7beb:d009 with SMTP id e9-20020adffd09000000b0032f7bebd009mr1610826wrr.17.1699440276267; Wed, 08 Nov 2023 02:44:36 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:35 -0800 (PST) From: Krzysztof Kozlowski To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Lee Jones , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:37 +0100 Message-Id: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:51 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992469419320777 X-GMAIL-MSGID: 1781992469419320777 Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Signed-off-by: Krzysztof Kozlowski Acked-by: Mark Brown Acked-by: Lee Jones Acked-by: Rob Herring Reviewed-by: Alim Akhtar --- I propose to take the patch through Samsung SoC (me). See cover letter for explanation. --- .../mfd/samsung,exynos5433-lpass.yaml | 2 +- .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml index b97b06848729..f154103f32cc 100644 --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml @@ -85,7 +85,7 @@ examples: }; i2s@11440000 { - compatible = "samsung,exynos7-i2s"; + compatible = "samsung,exynos5433-i2s", "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0>, <&adma 2>; dma-names = "tx", "rx"; diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml index 30b3b6e9824b..f45f73b5056d 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml @@ -44,13 +44,18 @@ properties: frequencies supported by Exynos7 I2S and 7.1 channel TDM support for playback and capture TDM (Time division multiplexing) to allow transfer of multiple channel audio data on single data line. - enum: - - samsung,s3c6410-i2s - - samsung,s5pv210-i2s - - samsung,exynos5420-i2s - - samsung,exynos7-i2s - - samsung,exynos7-i2s1 - - tesla,fsd-i2s + oneOf: + - enum: + - samsung,s3c6410-i2s + - samsung,s5pv210-i2s + - samsung,exynos5420-i2s + - samsung,exynos7-i2s + - samsung,exynos7-i2s1 + - tesla,fsd-i2s + - items: + - enum: + - samsung,exynos5433-i2s + - const: samsung,exynos7-i2s '#address-cells': const: 1