[10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC
Message ID | 20231108104343.24192-11-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp825895vqo; Wed, 8 Nov 2023 02:47:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IER6eK4vgqvvO7xYS6mkCMYQeZx47jaY6h42quYKnFo0m7Q7TqtSdkYVF6vMfKwexrZiMxz X-Received: by 2002:a05:6808:124c:b0:3b2:e2d1:34d2 with SMTP id o12-20020a056808124c00b003b2e2d134d2mr1897875oiv.47.1699440446866; Wed, 08 Nov 2023 02:47:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699440446; cv=none; d=google.com; s=arc-20160816; b=gh5+jLfJ2GRbkyB4hbQiH+0NyVJICh3nIwvDkM4VV7AmK3I1iurmd85v6sJe5BKeux 9F5fS6LXRpB2AaqhPHHykXOKDn/ICHTQlRpplhgMHbHb6nxz6grmvG5wqowY7XYXveSD gjFsgJHmMM51xPHB4zBbVD2oMzKYotKptvaXinUo/hhZCFpQw1ZkpgC0WYi/TBVZudB1 5ZXkY//nmMJj8JBXSPQtBuRSvkR3yzOUS9XFsy2fKT7vuBID8vu6mhqfcGNDlqo2IKWs xfV6O+V1r/x2vQ2uGINRq0nxZgT2C3HN77E+CoTeLFWxYJcr9BMru5mwfXp3rK/Fdj60 +S5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; fh=gdU7Z4ZWYludxHm8+epPFfgR0XIskw9B6LehcIOQ+iM=; b=ZynBhUQ8hUJucTLWoFk3ig4meLEZe8O6wsE/gKKZ68Zv3DC2q+Iz6CNKhucEixeGG4 DFY1OamOCE8x1zvBpGZMU4uBmT2alJAmieGOub+gH3usg/qef1roLBXKuCbq+JusL62e J9rUEc9t1j4GrqCUMcPmSWEHbBm5bvg9v7T8xNg75+oPJ/YNeQD58M1sF1CUC1zwFvao yTIYCYC3Rskj13gchEMCDotoFvEZxUT11TLmveDL0Z+7ZQCbxdlXG+/ZRMkhdV0q1RKt 7eifsSyWS5yT1DMldE9hXjvktybkjWu1kSGmrJR6sA811HdZSgZSWuhnKJCT1TcA7PRo nzVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmtpJmVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bo10-20020a056a02038a00b005b9022ddeaasi4693226pgb.516.2023.11.08.02.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:47:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CmtpJmVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 53914817C3DB; Wed, 8 Nov 2023 02:46:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344679AbjKHKqB (ORCPT <rfc822;jaysivo@gmail.com> + 32 others); Wed, 8 Nov 2023 05:46:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235664AbjKHKpV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Nov 2023 05:45:21 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FBB25BA for <linux-kernel@vger.kernel.org>; Wed, 8 Nov 2023 02:44:34 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4079ed65582so49890135e9.1 for <linux-kernel@vger.kernel.org>; Wed, 08 Nov 2023 02:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699440273; x=1700045073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=CmtpJmVlCM4syMknWUpWHAKoK/hAaKOC7nKz1YdbPATq3QoV5ZniZtdasH9YXba1d3 Oidzw9HrSEldko3wgSnvsglDZmh/S1DyfTYwMI6nJvXs/63+iBbSI8rg3FvcOfqUeaZX JIf1rA84zGmA9G/OwOoboCT/BBFUKfxnqHt6fdux5mtz3yIzNyKcCzlTJZYqPCagBEeF ifRDedM4yOl20AUWk/bM1L28QOVVQMkpfyK+PvASkpWnKTClenEnkZhrwD2P5l7mUpPF QyzRxHYmIKmbwpQopmL1SHTzW84630oij9Enqbkhkb0HVzG+NANHwgLJ26/EkiCBSbMd BfxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699440273; x=1700045073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkEvXWcKUOWY7MDhsApmZqSz9A9BrLzom2ZllyUYJqs=; b=CrVD6y+pZMdzfxz8APBSj7nRmX362yxRSXmksIB+XFdYM9Vy50t9aTfr+LohN/peK0 jtJImlA/M7t8Ng1ruUXB5UmGUVltd3oqQhySkIqUPMnB7V0M0wvirw/UUeHx0aL5FZzK tID8T53UWvwOJLnk53nNQ7gfz8zMbH9/EQCG0rqV0L6vqkMLmcLiB6RuhZ5nIc14XpNe ATWj6AbQde+GsCRuGJh3KPX0mPZE0nTjnRrKjVxf5vF3hRZXZy+MiSLTWi24VH15alys CTg+BC8FJyi6cCetpNHopLyeu5jtA02JvlxB4J58N24J9WHEej3W+TImhOyBroxgMVQL yVvQ== X-Gm-Message-State: AOJu0Yw73DIo1mzp8utr4X3ovUD9HIL0f3aJAX6eBQKjVpTcUlAAxE/0 2tZmwOhIsIAk3Fwyufpjc8BAjA== X-Received: by 2002:a05:600c:4fcd:b0:407:8e85:89ad with SMTP id o13-20020a05600c4fcd00b004078e8589admr1286513wmq.14.1699440272758; Wed, 08 Nov 2023 02:44:32 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 02:44:32 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Andi Shyti <andi.shyti@kernel.org>, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Lee Jones <lee@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaehoon Chung <jh80.chung@samsung.com>, Sam Protsenko <semen.protsenko@linaro.org>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Date: Wed, 8 Nov 2023 11:43:36 +0100 Message-Id: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 08 Nov 2023 02:46:35 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781992465937271190 X-GMAIL-MSGID: 1781992465937271190 |
Series |
dt-bindings: samsung: add specific compatibles for existing SoC
|
|
Commit Message
Krzysztof Kozlowski
Nov. 8, 2023, 10:43 a.m. UTC
Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.
Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
I propose to take the patch through Samsung SoC (me). See cover letter
for explanation.
---
.../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++--------
1 file changed, 17 insertions(+), 12 deletions(-)
Comments
On Wed, 08 Nov 2023 11:43:36 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, November 8, 2023 4:14 PM > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine and > there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > > I propose to take the patch through Samsung SoC (me). See cover letter for > explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > (...)
On Wed, 8 Nov 2023 11:43:36 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 582d0a03b814..4e40f6bed5db 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -11,18 +11,23 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos-adc-v1 # Exynos5250 > - - samsung,exynos-adc-v2 > - - samsung,exynos3250-adc > - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - - samsung,exynos7-adc > - - samsung,s3c2410-adc > - - samsung,s3c2416-adc > - - samsung,s3c2440-adc > - - samsung,s3c2443-adc > - - samsung,s3c6410-adc > - - samsung,s5pv210-adc > + oneOf: > + - enum: > + - samsung,exynos-adc-v1 # Exynos5250 > + - samsung,exynos-adc-v2 > + - samsung,exynos3250-adc > + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > + - samsung,exynos7-adc > + - samsung,s3c2410-adc > + - samsung,s3c2416-adc > + - samsung,s3c2440-adc > + - samsung,s3c2443-adc > + - samsung,s3c6410-adc > + - samsung,s5pv210-adc > + - items: > + - enum: > + - samsung,exynos5433-adc > + - const: samsung,exynos7-adc > > reg: > maxItems: 1
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index 582d0a03b814..4e40f6bed5db 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -11,18 +11,23 @@ maintainers: properties: compatible: - enum: - - samsung,exynos-adc-v1 # Exynos5250 - - samsung,exynos-adc-v2 - - samsung,exynos3250-adc - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 - - samsung,exynos7-adc - - samsung,s3c2410-adc - - samsung,s3c2416-adc - - samsung,s3c2440-adc - - samsung,s3c2443-adc - - samsung,s3c6410-adc - - samsung,s5pv210-adc + oneOf: + - enum: + - samsung,exynos-adc-v1 # Exynos5250 + - samsung,exynos-adc-v2 + - samsung,exynos3250-adc + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 + - samsung,exynos7-adc + - samsung,s3c2410-adc + - samsung,s3c2416-adc + - samsung,s3c2440-adc + - samsung,s3c2443-adc + - samsung,s3c6410-adc + - samsung,s5pv210-adc + - items: + - enum: + - samsung,exynos5433-adc + - const: samsung,exynos7-adc reg: maxItems: 1