Message ID | 20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp720809vqo; Tue, 7 Nov 2023 22:05:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHh3aQF23gE8AJ9nL7+JUQ26Gv+vkGJal84JaaYqJocFpBPvlU7lHxtAOOrW93pPc+iQzau X-Received: by 2002:a05:6358:41a1:b0:168:eada:cf98 with SMTP id w33-20020a05635841a100b00168eadacf98mr780846rwc.29.1699423532110; Tue, 07 Nov 2023 22:05:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699423532; cv=none; d=google.com; s=arc-20160816; b=vj6rto80/PaZU7VA5POa7Pda9T4OGYxLi0gNKeISNcky73npzrq4/1+Qie6RkEah4F yPddqVgp1WTve4QxQuFKRounmqr3kI6ycv2v8hMRPiXsQMkpiQ1da6BLbbGJ6l2/Eck/ Jo1B8Z9VsSJ+UDEaXqQlgE6+n4ib2Bybz6SUzDBKJnwOU6QlXCrIljMsBj8BUclVoL/m x5F9gGRqlaWOHqLTYpOtoWxG3kpryOZwriYeOfpuhsqq6gaFk2RxY7+zeEflzO+2qrDg 7d5595zRouUkmTP4/bV0QStOKIwp8NlJlKbeQdO8WNuieyTuXkEyL2+r/kKCv8MZlkOs 0N8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:reply-to:cc:to:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=LnLtaMZyn0R5G6Mw6EWcFUCnT1kbje9JlTYOUoYTjQw=; fh=lxzaRY3mJIecZ0dH+kEQ0aeOi3B9KZj1ZgElScadOPw=; b=Hyj+kRSXqpivn/wZtEyh7SnN99iaJrPDJ7ARAGa68MKxhIKc8bxavDMlTyDkESOuxN sNPTLn/3snedp1yUeB0IexXGo9u+quIRt4/0EvET/0EFcLpVrS11W6BSI26mnlcGi8aM iEMw9Q6pMhJQDrSkcOBt6DSiTKB9uVJWvyy8TKlwesKkRevCswTTbD+VbPqNM9WIMxvI oEsqhQpNLZy+jJAZkA8sPiV+Ia/9hoeU3o+mlhP4ambh4I3yxXtZXT7WjW3sOXdSfV3H NOO3LEVZiDr9MzmFHC40NpwVBmKITGpiQVTK/KW49iEg+qWz42HOBpMLD+5WfmkF+XUz UAqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsUdkLgX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id m17-20020a656a11000000b005b9a149e61esi4062171pgu.649.2023.11.07.22.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 22:05:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsUdkLgX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 4B11D82BB557; Tue, 7 Nov 2023 22:05:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbjKHGFZ (ORCPT <rfc822;jaysivo@gmail.com> + 32 others); Wed, 8 Nov 2023 01:05:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbjKHGFW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Nov 2023 01:05:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7B51AE for <linux-kernel@vger.kernel.org>; Tue, 7 Nov 2023 22:05:20 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id AFA9EC433C7; Wed, 8 Nov 2023 06:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699423519; bh=jPf+EyCFsnTuZYFqVKcAr8GvhtDbrpKc2fnaZTnUvME=; h=From:Date:Subject:To:Cc:Reply-To:From; b=dsUdkLgXcLrmh02Wvi3sYoRj3QXSGKjbTy5O9sfKJu915lnSE64zSOMamWChmkJsJ V1M9C7f3DZCtiVDCGzlIkVoMEEViIrrN/tTHMwgbKSZhayjjHpaqXqk6wCbdTb9F/L PtrWFJwUHTkVhqT5AZVaj7AiORHK5AGQmOoqXg2LtaPL0op+KgmHEGi2wtOhvLJEZL kEv1fHnZhSqJAHuuVpep8R+UnMVkLMePZ+zflqLkwAqVUCl7ZnOt3aFxIDzesjHYXJ f5Yf80lJGO0dN8EdCTycDzo3OAMrIZ4QfaOq6fDqOX9WMJ1ZzFnV4abvo6YvmcGh6V 1y2RTtSCtX1qg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96238C4332F; Wed, 8 Nov 2023 06:05:19 +0000 (UTC) From: Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> Date: Wed, 08 Nov 2023 14:05:12 +0800 Subject: [PATCH] ARM: dts: qcom: Add LPG LED device description MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com> X-B4-Tracking: v=1; b=H4sIABklS2UC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2NDQwML3cLk/Nz4nNSUYt1k4ySDJHMDI0sDAwsloPqCotS0zAqwWdGxtbU AJTBULVsAAAA= To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_fenglinw@quicinc.com, quic_uchheda@quicinc.com, kamalw@qti.qualcomm.com, Hui Liu <quic_huliu@quicinc.com> X-Mailer: b4 0.13-dev-83828 X-Developer-Signature: v=1; a=ed25519-sha256; t=1699423518; l=1242; i=quic_huliu@quicinc.com; s=20230823; h=from:subject:message-id; bh=NDo+ug2xivotbN/xsmZgwuX6Kewv3ppT7LsFeWs76Jw=; b=RljxyHRNT45DJuHIAuZuGUdPAx1iNvdE50l+UdUDEOalLsuw49dIGrF8fUhBac0Cgpic77vmG QPJ6QM17/SDC1A5fMZ8TeAn2e9q1TxYc5bOQbl0TZutUnDGAKgrX2Hw X-Developer-Key: i=quic_huliu@quicinc.com; a=ed25519; pk=1z+A50UnTuKe/FdQv2c0W3ajDsJOYddwIHo2iivhTTA= X-Endpoint-Received: by B4 Relay for quic_huliu@quicinc.com/20230823 with auth_id=80 X-Original-From: Hui Liu <quic_huliu@quicinc.com> Reply-To: <quic_huliu@quicinc.com> Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 07 Nov 2023 22:05:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781974729892100400 X-GMAIL-MSGID: 1781974729892100400 |
Series |
ARM: dts: qcom: Add LPG LED device description
|
|
Commit Message
Hui Liu via B4 Relay
Nov. 8, 2023, 6:05 a.m. UTC
From: Hui Liu <quic_huliu@quicinc.com> Add LPG LED device description. Signed-off-by: Hui Liu <quic_huliu@quicinc.com> --- arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) --- base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5 change-id: 20231108-qcom_leds-c3b0b7029008 Best regards,
Comments
On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > > From: Hui Liu <quic_huliu@quicinc.com> > > Add LPG LED device description. No. You are not adding "LPG LED device description". You are adding definition for three LEDs. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > index f28e71487d5c..11b9f384d99c 100644 > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > @@ -4,6 +4,7 @@ > */ > > #include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/spmi/spmi.h> > > &spmi_bus { > @@ -34,6 +35,27 @@ pm8350c_pwm: pwm { > compatible = "qcom,pm8350c-pwm"; > #pwm-cells = <2>; > status = "disabled"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + label = "red"; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + label = "green"; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + label = "blue"; ... and these particular LEDs are board-specific. Please fill them in the board file instead. > + }; > }; > }; > }; > > --- > base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5 > change-id: 20231108-qcom_leds-c3b0b7029008 > > Best regards, > -- > Hui Liu <quic_huliu@quicinc.com> > >
On 11/8/23 07:59, Dmitry Baryshkov wrote: > On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add LPG LED device description. > > No. You are not adding "LPG LED device description". You are adding > definition for three LEDs. > >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- Aside from Dmitry's valid comments, the subject is wrong. ARM points to arch/arm/ (arm32) and you're missing the name of the file that you're modifying. Check the git log for that file to get a grasp of it. Konrad
On 11/8/2023 2:59 PM, Dmitry Baryshkov wrote: > On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add LPG LED device description. > > No. You are not adding "LPG LED device description". You are adding > definition for three LEDs. OK, I will update the commit in next patch. > >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> index f28e71487d5c..11b9f384d99c 100644 >> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> @@ -4,6 +4,7 @@ >> */ >> >> #include <dt-bindings/interrupt-controller/irq.h> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/spmi/spmi.h> >> >> &spmi_bus { >> @@ -34,6 +35,27 @@ pm8350c_pwm: pwm { >> compatible = "qcom,pm8350c-pwm"; >> #pwm-cells = <2>; >> status = "disabled"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + label = "red"; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + label = "green"; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + label = "blue"; > > ... and these particular LEDs are board-specific. Please fill them in > the board file instead. Sure, I will add these node in board file. > >> + }; >> }; >> }; >> }; >> >> --- >> base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5 >> change-id: 20231108-qcom_leds-c3b0b7029008 >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > >
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi index f28e71487d5c..11b9f384d99c 100644 --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi @@ -4,6 +4,7 @@ */ #include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/spmi/spmi.h> &spmi_bus { @@ -34,6 +35,27 @@ pm8350c_pwm: pwm { compatible = "qcom,pm8350c-pwm"; #pwm-cells = <2>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + label = "red"; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + label = "green"; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + label = "blue"; + }; }; }; };