From patchwork Wed Nov 8 14:33:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 163071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp954072vqo; Wed, 8 Nov 2023 06:35:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiKmdVeSRtXsMeONGldkqRKJCS3+yKVpdvuIls7WlHWzDPYqE8JDMrZVcMLEcCOFsVukqa X-Received: by 2002:a05:6a20:431e:b0:17d:d272:7954 with SMTP id h30-20020a056a20431e00b0017dd2727954mr8013860pzk.9.1699454100692; Wed, 08 Nov 2023 06:35:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699454100; cv=none; d=google.com; s=arc-20160816; b=j9d9b6mMwtEK644a+JGp/pGTRCYPVfsUXpUXhCCsuwTNTRSdSjQnTol0/HxFLTEW9Z OUnfvJtWMeytQXDNIAKJtTKKskAPt/C+4kmpaOc18rIJdDOA5e/9O7X+G19neAdPOIo3 YAh18gazpZrIGGscqUcaScMjvPbc2h6ImCmi4AhzgKAPXQpKfGcfokSAggkOpHJD4oSl XRr1/4xxXRcZJAyYZnn0bnjRXCv/tuSYc6/qaS+L7qQDDSRokMvDX8ZCcYJwHy1HYRX5 gE47qqVkZCh4xGtmosDZBEyLBJ84EUPFqS05Anw59P6ZURXfcvPrkJW5FjzNYcWMjD10 NemA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=XORLfLOVJ2jQDbg32nclaixgD4oigISmdEZzRfl6mkQ=; fh=CFgYY1T12wuhk1cZvmrf/aNXOn5iMyIiDDTIBKwmNsI=; b=TG5SeOaW+Yunw84wCpEc87rqK0jc/xX2PhSBB+6VdeukY3pqtB63nKo7kHmeYFMkbA wCd2eud0Jbcs4+uc36a9KlYlgsMH4nOCdvt82JY8BWPfEq8XcTB4agy6/6EYjTgM8h6C wFtysqPYJ1k4bigoaKJsyVw4LrVIWxaPBBNUczfXtlvcjstLQf51x/S15OTe1RjbA9u6 Jz4AEOtivwZGnR0CIs9LNvoHSHZz/db2cAphp0ODpa74M/91hkauzkN3sHOa8kol8fXW JHJ5fGkbvYqJT1k00dX597y50r4rBgOgQb2X6cI96tlK6rYwmowoljPihnxTHXOOMzWM +B9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IcaMB8Ij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id 143-20020a630195000000b005660335e26fsi4555302pgb.485.2023.11.08.06.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 06:35:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IcaMB8Ij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9EF27819D1DC; Wed, 8 Nov 2023 06:34:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344077AbjKHOeN (ORCPT + 32 others); Wed, 8 Nov 2023 09:34:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233325AbjKHOeG (ORCPT ); Wed, 8 Nov 2023 09:34:06 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77C261FC4 for ; Wed, 8 Nov 2023 06:34:03 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507bd19eac8so9120054e87.0 for ; Wed, 08 Nov 2023 06:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699454042; x=1700058842; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XORLfLOVJ2jQDbg32nclaixgD4oigISmdEZzRfl6mkQ=; b=IcaMB8IjImBULJ/qiQBgUKoRwl9C5u0thSNnUZreqIZHkgh7jVZVDZb+1Fa6d/emvL 2NlHpyTFR4sohIegZsOqulu/CtRmI9S6zC72DtjXW8ij3nI8IVxn3a7Z4tUFpPhCTWQb 4+E0EItUkG8CxY1NHXWrpwhB/f+J0UTZNTvxxtsk/WRW1xfQTmQZwGsywg9QDwyPKrDx Z9W+IimFtSzqXeQHqe3ZS4NERbdc/b+iK/AlvZOOgCllMzXukhd9cxPwf/C0CG3R9FdP I6hLd9YMI3vR5aoflBvFYnSjhT8xLC3NGioJnwpyInDVNpG9+bW+lAU1cItBz4ao6155 3hWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699454042; x=1700058842; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XORLfLOVJ2jQDbg32nclaixgD4oigISmdEZzRfl6mkQ=; b=WSJ/6AZyOgcQ0bGuZv8IafhWaOquFSa5Ucr8ePsHJH7uMDLr5mDpzn6Xt9nl8pK8DX PmMBqO+h3L77dyZcHs01S/ggfXFQaSLJFObsgVnkm44g1oN6nZAZznrr3ti0iXKY/Blc cavHYFxy37DvRWUFfsclBTSQMIUF+OOEEb9nm0SmXMMN5NkbIhM/pL2M79OrRyV9KKY6 YjRx5tsTxChBQ/tBw3MPrxkn4ednHEFa+lS9IfczNj/3DiEkeCy2oi7qIqmiLekLVn9s NnyzVYT5R9PrBzeEJsT/0VPKoMr8+bOnk7+DiNPHXuWBIubrDM0+qDpwrO4nzvFFC9TR O3Wg== X-Gm-Message-State: AOJu0YwRtr1rj6UZA+IU0NsZ9BzM2ne7Kz5CRVZWAp6iAaAOTsEUAEEB ONhynvgs0Ra6TXYbLnXijB3U6g== X-Received: by 2002:ac2:5d2b:0:b0:500:7685:83d with SMTP id i11-20020ac25d2b000000b005007685083dmr1266850lfb.48.1699454041779; Wed, 08 Nov 2023 06:34:01 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q10-20020ac24a6a000000b00507a3b8b007sm686773lfp.110.2023.11.08.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 06:34:01 -0800 (PST) From: Linus Walleij Date: Wed, 08 Nov 2023 15:33:51 +0100 Subject: [PATCH 3/6] MIPS: NI 169445: Fix NAND GPIOs MIME-Version: 1.0 Message-Id: <20231108-fix-mips-nand-v1-3-5fc5586d04de@linaro.org> References: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> In-Reply-To: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> To: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Ben Dooks Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 08 Nov 2023 06:34:49 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782006782984965171 X-GMAIL-MSGID: 1782006782984965171 This changes the GPIOs defined in the device tree to recommended practice, which is also what the Linux NAND GPIO driver is actually using. In the process, fix up the CE and WP lines to be active low, as is required for proper hardware description. Signed-off-by: Linus Walleij --- arch/mips/boot/dts/ni/169445.dts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/mips/boot/dts/ni/169445.dts b/arch/mips/boot/dts/ni/169445.dts index 5389ef46c480..3e7b46d5072c 100644 --- a/arch/mips/boot/dts/ni/169445.dts +++ b/arch/mips/boot/dts/ni/169445.dts @@ -1,4 +1,5 @@ /dts-v1/; +#include / { #address-cells = <1>; @@ -57,18 +58,18 @@ gpio2: gpio@14 { no-output; }; - nand@0 { + nand-controller@0 { compatible = "gpio-control-nand"; nand-on-flash-bbt; nand-ecc-mode = "soft_bch"; nand-ecc-step-size = <512>; nand-ecc-strength = <4>; reg = <0x0 4>; - gpios = <&gpio2 0 0>, /* rdy */ - <&gpio1 1 0>, /* nce */ - <&gpio1 2 0>, /* ale */ - <&gpio1 3 0>, /* cle */ - <&gpio1 4 0>; /* nwp */ + rdy-gpios = <&gpio2 0 GPIO_ACTIVE_HIGH>; + ce-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + ale-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; + cle-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; + wp-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; }; serial@80000 {