From patchwork Tue Nov 7 11:24:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Shumilin X-Patchwork-Id: 162432 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp168578vqo; Tue, 7 Nov 2023 03:31:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFA70xl8n0/nIUsw3oAedbLeOZXeKecMBsMx6LQ8Auzs5lUUvcyannW7Ms2MtlwXZyeFlBn X-Received: by 2002:a05:6808:238e:b0:3ad:f86a:877b with SMTP id bp14-20020a056808238e00b003adf86a877bmr40087980oib.23.1699356667454; Tue, 07 Nov 2023 03:31:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699356667; cv=none; d=google.com; s=arc-20160816; b=IgOEZTCcFKHoRegisgFxDOtBYjTVmS+aHI1E5GFASIuDh0IwP5RsJ2iPv5Zn3W2o8n lGsJZUh9loacjwHAiQaoTM5/U+RN0f3W9o63lCZa9+UX+MtIV4TaYT//BOz5+uITaZQN 8KMWMXmyn/nOTn+NSr+g11WAnqJ6KDnwzudV+yjP1YvW9dpOGvvSWU53tU0gOC2ZBgay Hm5BQ+3GMn5JZODGtfXutkneeMl8XrrMfVrHz+SNyHVJzyp/uoS4aNwakbD1OtxwhgWD N1Lx8HU7khY0cCbid8BDrvXBFrtSnNYFBVlCbZk115QTAwUO9xenNAE/PUSN9r1Fmtcc Ndxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5LR+olzTYHKfq9BfttUj+zVd0qL6Duzi/F6K0yHzoT4=; fh=tCwwtvHZWD21swngRdU0RTycr/AnamA0da1gKCLVsVg=; b=dBM9YHyI+axhDgwjURmT6lrFAmnTyvYBSc8ZuFOHoTPwHhPvUwcRAoENmQqOPghVvc rOBsKwqfHWAJDeAvRUNJ0ux+XAWxPOOPc+BfQbJx49Ew+E9LiEzYc+ihoXl4M28i97Uv HJj47Sh3Y3Kf0zODgGMDdxwIirqW40FmaWTEgvSF6qB8gkSmQ3XVAHwMVMIMojDHij0b wQcpr9nKQeiSH6G1/DsQ8+G77AiEBYcy8IvkupgrVB97S1PKTslFH1Kddhq7S6pwDomc jojfmkSXFCIm/MOgWdl6AskZCcn/9KLZXYMlXd20sPLHuhj7lKUHkLhI+wAPxioxPU/X dbJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b="Y9HccfJ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id fc41-20020a056a002e2900b006c34028e37dsi10534272pfb.219.2023.11.07.03.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 03:31:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@nppct.ru header.s=dkim header.b="Y9HccfJ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 869D08020C0C; Tue, 7 Nov 2023 03:30:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233938AbjKGLat (ORCPT + 32 others); Tue, 7 Nov 2023 06:30:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbjKGLas (ORCPT ); Tue, 7 Nov 2023 06:30:48 -0500 X-Greylist: delayed 368 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 07 Nov 2023 03:30:42 PST Received: from mail.nppct.ru (mail.nppct.ru [195.133.245.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DFAFEA for ; Tue, 7 Nov 2023 03:30:41 -0800 (PST) Received: from mail.nppct.ru (localhost [127.0.0.1]) by mail.nppct.ru (Postfix) with ESMTP id A787B1C0E46 for ; Tue, 7 Nov 2023 14:24:29 +0300 (MSK) Authentication-Results: mail.nppct.ru (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nppct.ru DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nppct.ru; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:to:from:from; s=dkim; t=1699356268; x= 1700220269; bh=x6jysyZ5oZimszC/+KWYqfqt9dmO+sPqmSEiLu28WpI=; b=Y 9HccfJ/7sU3HQK+uVCl8IXpS3ZanMy63ECDpLEvA/dqgZMsRs0bH97cssrgnz1o0 Ql6ckNs26oy+zX/aUL8XT8YQ7ivs+BX8E11aKqGYsAofST2cFeuqcH/s6Cu3/YQS VuKcfZguqtGs8sL8c2WrgCagRMsvHZk3fbfnU4P8Qk= X-Virus-Scanned: Debian amavisd-new at mail.nppct.ru Received: from mail.nppct.ru ([127.0.0.1]) by mail.nppct.ru (mail.nppct.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id d1B-XwSv2WzY for ; Tue, 7 Nov 2023 14:24:28 +0300 (MSK) Received: from localhost.localdomain (mail.dev-ai-melanoma.ru [185.130.227.204]) by mail.nppct.ru (Postfix) with ESMTPSA id C3F401C0859; Tue, 7 Nov 2023 14:24:27 +0300 (MSK) From: Andrey Shumilin To: 3chas3@gmail.com Cc: Andrey Shumilin , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] iphase: Adding a null pointer check Date: Tue, 7 Nov 2023 14:24:19 +0300 Message-Id: <20231107112419.14404-1-shum.sdl@nppct.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 07 Nov 2023 03:30:58 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781904617361027679 X-GMAIL-MSGID: 1781904617361027679 The pointer desc_tbl[i].iavcc> is dereferenced on line 195. Further in the code, it is checked for null on line 204. It is proposed to add a check before dereferencing the pointer. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Shumilin --- drivers/atm/iphase.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 324148686953..596422fbfacc 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c @@ -192,6 +192,11 @@ static u16 get_desc (IADEV *dev, struct ia_vcc *iavcc) { i++; continue; } + if (!(iavcc_r = dev->desc_tbl[i].iavcc)) { + printk("Fatal err, desc table vcc or skb is NULL\n"); + i++; + continue; + } ltimeout = dev->desc_tbl[i].iavcc->ltimeout; delta = jiffies - dev->desc_tbl[i].timestamp; if (delta >= ltimeout) {