Message ID | 20231107101610.13728-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp134502vqo; Tue, 7 Nov 2023 02:16:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHd/ij8Hi9yRuhGWVmIGo2EjeWYY8d/cC2cYCmPJCPG8qubwmF9MZVbs1YqsGMv/vebAL9v X-Received: by 2002:a17:90b:1e53:b0:280:fcba:bedd with SMTP id pi19-20020a17090b1e5300b00280fcbabeddmr3838095pjb.48.1699352198514; Tue, 07 Nov 2023 02:16:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699352198; cv=none; d=google.com; s=arc-20160816; b=CpdMYyAu/E2DhLOpjpKQrE7fhJcw6Av2vOwDftGEJFGNa92liGWziFYJq82X6/gIVu dQxaFZ2zj0YXOFGB30d+z/g/rr7LzNkrcmJThLteo8ru0QsviLMjIHwKQEHvXaaiA5Sv ppcULDmXRArCV5BSkOYj7lFTTqkgiVPwE209XnchRV22Eurxupy8DAxC1w+a5Uv7dbZ5 /nwQlxzHMkc9BfMHaG+6IL54v4mnfR7bhYfYeDby3Bcjxnk97EVP2T8EAF2MOLjB8koy qApekmQAzzjtB+DZ6fdvoTWE+dWI0cygs3FpmS/W5ZDY5SubLSvXCrs47rPl8WwuVFHl W5DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=95vD72c+bC2P8X8C/IdsTMXs0cKxT+IRop924lJhGj8=; fh=OpW6FRjYjjWE4h6Svcv4j5il5t2e0MG29g4ue4mxa8U=; b=KVYh4UNDa7sRnRBdX+59fvcOvT4o1ycOyIbQNEdhD50oUjDwYSIF/y4u9te4OOW2oF 26+HtiBZAlpciBzL8Z0GiKpxJ/yWCNzrc6uT/m5GAwVT0PbILrLg+HaL0N88RLdPDQgn lDDhXEszpXjhgVkZREDEynnU6eUFPsJmKUm+wJGgpVcM/sOAAaN4ZrwapodnITMQ/WWE 2MrS2atJCBmgVup1p3u76+q6SQQMyliQLHny8RGH0FhHwf0hHC8g3PZ2CGUTK8vTOvCp B2lAvvmvmsp3FkkiatDt5PcJqJib4OqbJ4pxBLwaED0LZwkBKWYeCQwh0Bk7aeOVreqi NfvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hm/XMT7S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id mv17-20020a17090b199100b0027d7eebd4c0si9727936pjb.109.2023.11.07.02.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 02:16:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hm/XMT7S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 4772D8096450; Tue, 7 Nov 2023 02:16:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233769AbjKGKQW (ORCPT <rfc822;lhua1029@gmail.com> + 33 others); Tue, 7 Nov 2023 05:16:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233508AbjKGKQV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Nov 2023 05:16:21 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51967116 for <linux-kernel@vger.kernel.org>; Tue, 7 Nov 2023 02:16:17 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-507b9408c61so7204258e87.0 for <linux-kernel@vger.kernel.org>; Tue, 07 Nov 2023 02:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699352175; x=1699956975; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=95vD72c+bC2P8X8C/IdsTMXs0cKxT+IRop924lJhGj8=; b=hm/XMT7SZKzjyj8Ebsm372Kt5mKKn0eOerShTN0y4EaqYFGyT2nkRO7v1MDHjaBH6l FvyoRJZ4orOeOHCNBqBcU0vlncqIvAPJUkDvRc1/RR+rYmToBFrxwSr1RRjP0GD7skPk jggaO0Eox2MG8CPXzvNfK6L1hiZ8m8Klm2kLmsE1mOAXysg/79hDSUX80k1BCT57D991 oguSIftO5JTQ+9YbqGhtyxUahhWNyKCUuu/n2RUuDmskDNZOenjvotUrPPDvSyIzJutK 9KCKOhb8PCi5z5ByEpipK91gmSZcdHntPZyRrYeKuZn/d1omLndnW4rGvH2hyuNwH+Lb 2OdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699352175; x=1699956975; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=95vD72c+bC2P8X8C/IdsTMXs0cKxT+IRop924lJhGj8=; b=ejrc25Wlrb376VqHhMK+HaGcBapYOpVHn49EkcSXXhCJRSjwQWYjpDh+7y2yydOruC ZCPfXDJmKUQJEMZFOc4oHgVEnq7KZv2wOGXw2Z2g2yneM4s1h8bLUjDeehDVOhFBJXmL Khj4JH2OkTELV22oum/Ual/sJ6Oeq1yYb6UxYM3xfWVlXKOPNffJ+ovlbW2IN79cS3CU guNvz2lkxWurKuKrDh0U45c9VXj2mD9H9LfRpQPHu7hMr1px00ha1qyy3XbBYCYRz0uy TPXdU5fuS0ypiSQhecgDcFii+iSDXb8NAly0g8q/tP28gVeUik48bnMzU26Wd8fw3YIv HipQ== X-Gm-Message-State: AOJu0Yzt4NjNrhLsT/LrJ3/IkHHVw0UGGwNO9EHXSpJSfEKrporcAjl6 iaDLDYRsx10wMWQZudDlQr9wvQ== X-Received: by 2002:ac2:546e:0:b0:507:9855:bc68 with SMTP id e14-20020ac2546e000000b005079855bc68mr23509396lfn.37.1699352175531; Tue, 07 Nov 2023 02:16:15 -0800 (PST) Received: from krzk-bin.. ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id l3-20020a05600c4f0300b003fc0505be19sm15249922wmq.37.2023.11.07.02.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 02:16:14 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Banajit Goswami <bgoswami@quicinc.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Ryan Lee <ryans.lee@analog.com>, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org> Subject: [PATCH] ASoC: dt-bindings: use "soundwire" as controller's node name in examples Date: Tue, 7 Nov 2023 11:16:10 +0100 Message-Id: <20231107101610.13728-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 07 Nov 2023 02:16:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781899930704368747 X-GMAIL-MSGID: 1781899930704368747 |
Series |
ASoC: dt-bindings: use "soundwire" as controller's node name in examples
|
|
Commit Message
Krzysztof Kozlowski
Nov. 7, 2023, 10:16 a.m. UTC
Soundwire Devicetree bindings expect the Soundwire controller device
node to be named just "soundwire". Correct examples, so the incorrect
code will not be re-used.
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/sound/adi,max98363.yaml | 2 +-
Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 2 +-
Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Tue, Nov 07, 2023 at 11:16:10AM +0100, Krzysztof Kozlowski wrote: > Soundwire Devicetree bindings expect the Soundwire controller device > node to be named just "soundwire". Correct examples, so the incorrect > code will not be re-used. > > Reported-by: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> FWIW, there are a few instances of "soundwire-controller" in qcom devicetrees that you might also want to change. > --- > Documentation/devicetree/bindings/sound/adi,max98363.yaml | 2 +- > Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 2 +- > Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml b/Documentation/devicetree/bindings/sound/adi,max98363.yaml > index a844b63f3930..c388cda56011 100644 > --- a/Documentation/devicetree/bindings/sound/adi,max98363.yaml > +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml > @@ -39,7 +39,7 @@ unevaluatedProperties: false > > examples: > - | > - soundwire-controller@3250000 { > + soundwire@3250000 { > #address-cells = <2>; > #size-cells = <0>; > reg = <0x3250000 0x2000>; > diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > index ba572a7f4f3c..8e462cdf0018 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > @@ -52,7 +52,7 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > > - soundwire-controller@3250000 { > + soundwire@3250000 { > #address-cells = <2>; > #size-cells = <0>; > reg = <0x3250000 0x2000>; > diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml > index e6723c9e312a..d717017b0fdb 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml > @@ -48,7 +48,7 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > > - soundwire-controller { > + soundwire { > #address-cells = <2>; > #size-cells = <0>; > > -- > 2.34.1 >
On 08/11/2023 13:17, Conor Dooley wrote: > On Tue, Nov 07, 2023 at 11:16:10AM +0100, Krzysztof Kozlowski wrote: >> Soundwire Devicetree bindings expect the Soundwire controller device >> node to be named just "soundwire". Correct examples, so the incorrect >> code will not be re-used. >> >> Reported-by: Neil Armstrong <neil.armstrong@linaro.org> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > FWIW, there are a few instances of "soundwire-controller" in qcom > devicetrees that you might also want to change. Yes, already sent. https://lore.kernel.org/all/?q=s%3Aqcom+s%3Asoundwire+s%3Anode Best regards, Krzysztof
On Tue, 07 Nov 2023 11:16:10 +0100, Krzysztof Kozlowski wrote: > Soundwire Devicetree bindings expect the Soundwire controller device > node to be named just "soundwire". Correct examples, so the incorrect > code will not be re-used. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: use "soundwire" as controller's node name in examples commit: dc29d3d253f1f3513a916f0b4271569223860c71 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml b/Documentation/devicetree/bindings/sound/adi,max98363.yaml index a844b63f3930..c388cda56011 100644 --- a/Documentation/devicetree/bindings/sound/adi,max98363.yaml +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml @@ -39,7 +39,7 @@ unevaluatedProperties: false examples: - | - soundwire-controller@3250000 { + soundwire@3250000 { #address-cells = <2>; #size-cells = <0>; reg = <0x3250000 0x2000>; diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml index ba572a7f4f3c..8e462cdf0018 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml @@ -52,7 +52,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> - soundwire-controller@3250000 { + soundwire@3250000 { #address-cells = <2>; #size-cells = <0>; reg = <0x3250000 0x2000>; diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml index e6723c9e312a..d717017b0fdb 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml @@ -48,7 +48,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> - soundwire-controller { + soundwire { #address-cells = <2>; #size-cells = <0>;