[10/10] bpf: Remove the now superfluous sentinel elements from ctl_table array

Message ID 20231107-jag-sysctl_remove_empty_elem_kernel-v1-10-e4ce1388dfa0@samsung.com
State New
Headers
Series [01/10] kernel misc: Remove the now superfluous sentinel elements from ctl_table array |

Commit Message

Joel Granados via B4 Relay Nov. 7, 2023, 1:45 p.m. UTC
  From: Joel Granados <j.granados@samsung.com>

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)

Remove sentinel element from bpf_syscall_table.

Signed-off-by: Joel Granados <j.granados@samsung.com>
---
 kernel/bpf/syscall.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Andrii Nakryiko Nov. 7, 2023, 6:15 p.m. UTC | #1
On Tue, Nov 7, 2023 at 5:45 AM Joel Granados via B4 Relay
<devnull+j.granados.samsung.com@kernel.org> wrote:
>
> From: Joel Granados <j.granados@samsung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel element from bpf_syscall_table.
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
>  kernel/bpf/syscall.c | 1 -
>  1 file changed, 1 deletion(-)
>

LGTM.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index eb01c31ed591..1cb5b852b4e7 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -5679,7 +5679,6 @@ static struct ctl_table bpf_syscall_table[] = {
>                 .mode           = 0644,
>                 .proc_handler   = bpf_stats_handler,
>         },
> -       { }
>  };
>
>  static int __init bpf_syscall_sysctl_init(void)
>
> --
> 2.30.2
>
  

Patch

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index eb01c31ed591..1cb5b852b4e7 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -5679,7 +5679,6 @@  static struct ctl_table bpf_syscall_table[] = {
 		.mode		= 0644,
 		.proc_handler	= bpf_stats_handler,
 	},
-	{ }
 };
 
 static int __init bpf_syscall_sysctl_init(void)