From patchwork Mon Nov 6 23:11:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 162224 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2982468vqu; Mon, 6 Nov 2023 15:11:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAUtfV+4wWCai/4zdqcx+CX9ZwqK86kKToD/pkyMPBslPsmIIQM0J46PqhT9tGuKih9z2T X-Received: by 2002:a05:6a21:7888:b0:181:a3ae:115b with SMTP id bf8-20020a056a21788800b00181a3ae115bmr12093067pzc.61.1699312292977; Mon, 06 Nov 2023 15:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699312292; cv=none; d=google.com; s=arc-20160816; b=e/h8HuBMbskPm5R6k427a+EWWVtkg6VJeLvVd08wzfPVHBl36IZWnezApy6XqEwtSS wKWNo0463qikfCOcmRaezeuOkWJ+mr5RMzx1vXY6M7kXW468zCyNQHEvADATO1O9Haoq 1CGUr4O0vyK1GoNsoH/iNDRzfQJ78kr6jPVoHVxhy06VY/ZCymw7Ugd71KjPuohN9/4V 18L7jEy812BENrJe0dBqK4TGWMoiKM2fLDayglQlm5JtlS3usCnzPZZgPKvRvqDP85wP IGwWNpMzGhzEhviicbxdFPD9AcDY7B1aB0lSXb0chQJcJ5Q09lI2h789aVINSiXpVWKp Y3Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cl1a3BIlGOodzNLugPywadXuDNbB772BtN6sPF7d3Lw=; fh=3yElqddE99K2Zbz+yUbbSYmnfXWMRh9FV7eRVIGWkEM=; b=xPAZDU6ia24Pe0ybuWF6ypdPT1BnNpn4IdIuB9u4BO9cBUUEWzUWoCKjoUFMySBgS9 lmYY/0/JxctjMd2+Ky5l0Vf8J2J5E37BW8l9RsLvJGk9xBGVDEZea3FM4Rp8oG4sxt/P TPZkKGzQPTW6FCEqGM2sVRBLRxBW9rcXWa+h8bIN2+1QNpKvGXn70F4giIHt+tkTH90t 8XVHeQ20EhUFhW92WhPPGbE0EFF2BYH2WIbz3mSyMu9YtI7GrjyrLNpirSOM5ykrpKRx UR0fVFj2/LKIoz4ju9Q+yZp2lpeuZmq7rRwtv3LoEJo3B9vwe6Z+0yVazgdpRshs0ZVn 9H9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gHkoTftq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bg26-20020a056a02011a00b005afc5ea43fdsi699348pgb.849.2023.11.06.15.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 15:11:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=gHkoTftq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BD60F8078626; Mon, 6 Nov 2023 15:11:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233228AbjKFXLT (ORCPT + 34 others); Mon, 6 Nov 2023 18:11:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233226AbjKFXLR (ORCPT ); Mon, 6 Nov 2023 18:11:17 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4F8AD77 for ; Mon, 6 Nov 2023 15:11:13 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6ce2988d62eso3294220a34.1 for ; Mon, 06 Nov 2023 15:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1699312273; x=1699917073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cl1a3BIlGOodzNLugPywadXuDNbB772BtN6sPF7d3Lw=; b=gHkoTftqQ8UqHb1fR8OSU+h3xjRiunf3HJbSl47pP26UeJXeH4kk7/B+YPKfDV3eXd uLDQOBl+ySS09Dalvr6lcSyRGXIUvH4uk+NUDC5g2Bo5HkC7oMhuIibjsDnzRE8JVqYA YHizBJw34ojHQPMnZtVdYKAIswJKWBSftrPCRxNaqTn72gHtR5DBfbJlp2LmCJFW6ToF DDEMFLlU9J2A6wnGaadN4WIMVXmOjTtyNwKzeSVFQyXGGd04/k0pPUX2iiTTk73NGFuj LqIYs0/Qtd1+J6qHXehEHcFBj2OqgvHtgsgh7HdGdy927Uzd0IQVd0iyEHcMy1vD5zX8 kGaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699312273; x=1699917073; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cl1a3BIlGOodzNLugPywadXuDNbB772BtN6sPF7d3Lw=; b=D1iL/wV5bqX4NFWA/PD4OiA9qlj5TDoqrlgUg3qXVCriksv+zf42A4JP7sYUWFmCXz Xal8+6OEMSAjxcIrBTa1A8c1ZXmwyUtiy8QZ3TsA1Pv5HrDMGKdDagqkB3g/4OqmT/2n iWZ4R0of/xpmsDkukvsyyVxc9cAv6ZirOEkbuQJL0An9AIwO5SKocy9EvObdHpSqq/j0 x9W4PgBBG3T9onvhfxzV/oFX99G3yJtmSJROfhp7n5eyCE7G2CYWyMMhDWv/xiHUv+fC bj+giFAVhuS2w+NNsZNE/ns2pPnc070X6OpzXJHLc49Lt2sO/aoIQpUXIOftFr65940d 9Eyg== X-Gm-Message-State: AOJu0Ywic7PcX/twWaDTqegcZQmDbg9NVID/d0H1RdQNaldbVtnGIlYH Yslrp7xUiT1ThPl65h60ZOQYVCfie+hzh7efm/fqFA== X-Received: by 2002:a05:6830:2b2a:b0:6d3:1f3e:4c4 with SMTP id l42-20020a0568302b2a00b006d31f3e04c4mr19885732otv.0.1699312272970; Mon, 06 Nov 2023 15:11:12 -0800 (PST) Received: from evan.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id w19-20020a9d77d3000000b006d309c126fbsm1418385otl.57.2023.11.06.15.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 15:11:12 -0800 (PST) From: Evan Green To: Palmer Dabbelt Cc: cleger@rivosinc.com, Evan Green , Albert Ou , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Palmer Dabbelt , Paul Walmsley , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH] RISC-V: Remove __init on unaligned_emulation_finish() Date: Mon, 6 Nov 2023 15:11:05 -0800 Message-Id: <20231106231105.3141413-1-evan@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 06 Nov 2023 15:11:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781858087116848176 X-GMAIL-MSGID: 1781858087116848176 This function shouldn't be __init, since it's called during hotplug. The warning says it well enough: WARNING: modpost: vmlinux: section mismatch in reference: check_unaligned_access_all_cpus+0x13a (section: .text) -> unaligned_emulation_finish (section: .init.text) Signed-off-by: Evan Green Fixes: 71c54b3d169d ("riscv: report misaligned accesses emulation to hwprobe") --- arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index bba301b5194d..5eba37147caa 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -625,7 +625,7 @@ bool check_unaligned_access_emulated(int cpu) return misaligned_emu_detected; } -void __init unaligned_emulation_finish(void) +void unaligned_emulation_finish(void) { int cpu;