| Message ID | 20231106092202.11127-1-tomeu@tomeuvizoso.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2535014vqu;
Mon, 6 Nov 2023 01:22:40 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IG9f3Ipx7Qzbo/rvZ4+oWMEvp9KWhFieszZFPZtW1edmEPKRubhsDV/GiOSWz/RozKbkn5D
X-Received: by 2002:a05:6a21:4995:b0:180:e069:57fd with SMTP id
ax21-20020a056a21499500b00180e06957fdmr16739248pzc.36.1699262559840;
Mon, 06 Nov 2023 01:22:39 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699262559; cv=none;
d=google.com; s=arc-20160816;
b=vi+od+oFgolkHNSso0/7tJf7CtG5nE2Kpu68X2zl1ox3/lSFAGt2YSJXk+JccDIhuW
UVi1NBFfWzyZmDpQpsVassunvWYrFqebcGGCSj2RWAGcz/XnOvEJno8BUtBzAdpATrI0
1pQCr2kfxq3GKoZR9isiDT8IAMtzbQ5y+Z6Ifipfr+3Z4LJrmiYSSavB0AGOqFjAd1ot
b0ab03N50wTZSB8jR6ia1WUHT9kttzhS2/7MpBXWS/1bEjJ2BSjwymHmYKkwES65MqT/
SYao1r1XF+cadfp7tm6uPnD2u8Fmqh1SC2OIJw38kS6slf9XuykTHIm2aXAkfjeSJ4re
rV8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=7vxzdd7hvG1LZGKkqhTZumSilwKU2j2TuY6Cx8E9gJo=;
fh=6Kl6oYCz2OnJQ9snSg39ePww5QxE7uDjgVZFmVAK91Q=;
b=XXPja/uX7Mwa/LkPciHF0nLHaCgvERmoaOUREx21MSun89VpL27gsit5kN5PZeiFvZ
hhXpp0g41TyjS6Cxi6XDIF+Dhgr7D5B2gT8luftR4YTorxlfSvLS5GJSGfjBEF3AAl8X
9Aj9/K/5vGI8y5jbvUAUfU+/CwPdNJjLh1AUd1m8GEqhkUtvR4peK++04mlO4r1aKiYV
4fv9aXiCyzYvsccmHclHWLBKoI4OcxIdm4p2yEaBrJ3yNYGMqIewi0szox1j75vSDLYi
EF0RGBxzjjlS5jBbER7QoIwI7CdcKoUPg9WZIs3kn9cY+e/fXe7FPDMy6nh4cNQ67vfe
CLCA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.35 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from groat.vger.email (groat.vger.email. [23.128.96.35])
by mx.google.com with ESMTPS id
n15-20020a170903110f00b001c4062a0e43si8445416plh.169.2023.11.06.01.22.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 06 Nov 2023 01:22:39 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.35 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by groat.vger.email (Postfix) with ESMTP id 8AFB680A0E2E;
Mon, 6 Nov 2023 01:22:37 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231250AbjKFJWS (ORCPT <rfc822;jaysivo@gmail.com> + 36 others);
Mon, 6 Nov 2023 04:22:18 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35824 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230475AbjKFJWQ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 6 Nov 2023 04:22:16 -0500
Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com
[209.85.218.43])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DBEFDF;
Mon, 6 Nov 2023 01:22:12 -0800 (PST)
Received: by mail-ej1-f43.google.com with SMTP id
a640c23a62f3a-991c786369cso614750366b.1;
Mon, 06 Nov 2023 01:22:12 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1699262530; x=1699867330;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=7vxzdd7hvG1LZGKkqhTZumSilwKU2j2TuY6Cx8E9gJo=;
b=ZAVfNjQXQ9iIYVR8xPs5bXtfwI1GmrzhAY0nAmwC7iJiEGthN41WxKuvWbTOpGCvah
SlgAzOFzdowtHPre1yIbkLyWQ/T0NlnjO2jVqopbS5kmwsk22HS+fIqkl/323RdoNJJq
RXqHD6Q2ZTV0wJqoW0dX505zax0MBFOv4iWE0CoUFJnjbsj0iVJBwbihusnAJbNQqWJs
CT9LFrd21T2LmLGfrxRVfBam9vTsmk0RI2HoDc0t+51CbdQsqLm8DJ2gMlLvECrek2id
PUpC/yr3kfdrceEpXaV0syosNb0VAaeGZ5IqZa2scXL7nESbAf/2nCSfuKEpPAJvHuwb
NTwA==
X-Gm-Message-State: AOJu0YwB3G+xi3XtrrTD1rwA4YNoaMIN/DMXy9dOJ4PdXXDsRYTIdCFW
ddXbL5rbiYx/CtM0NOl+Ex2fBrmMT04=
X-Received: by 2002:a17:907:31c3:b0:9bf:122a:7db2 with SMTP id
xf3-20020a17090731c300b009bf122a7db2mr13821438ejb.66.1699262529951;
Mon, 06 Nov 2023 01:22:09 -0800 (PST)
Received: from ramallet.home (cst-prg-38-127.cust.vodafone.cz.
[46.135.38.127])
by smtp.gmail.com with ESMTPSA id
w5-20020a05640234c500b005402748cf29sm4098608edc.50.2023.11.06.01.22.08
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 06 Nov 2023 01:22:09 -0800 (PST)
From: Tomeu Vizoso <tomeu@tomeuvizoso.net>
To: linux-kernel@vger.kernel.org
Cc: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Lucas Stach <l.stach@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson
SoC support),
linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC
support)
Subject: [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the
NPU
Date: Mon, 6 Nov 2023 10:22:02 +0100
Message-ID: <20231106092202.11127-1-tomeu@tomeuvizoso.net>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No,
score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]);
Mon, 06 Nov 2023 01:22:37 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1781805938336309589
X-GMAIL-MSGID: 1781805938336309589
|
| Series |
[RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU
|
|
Commit Message
Tomeu Vizoso
Nov. 6, 2023, 9:22 a.m. UTC
Otherwise they are left at 24MHz and the NPU runs very slowly.
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Suggested-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
1 file changed, 3 insertions(+)
Comments
On 06/11/2023 10:22, Tomeu Vizoso wrote: > Otherwise they are left at 24MHz and the NPU runs very slowly. > > Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> > Suggested-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index ff68b911b729..9d5eab6595d0 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -2502,6 +2502,9 @@ npu: npu@ff100000 { > clocks = <&clkc CLKID_NNA_CORE_CLK>, > <&clkc CLKID_NNA_AXI_CLK>; > clock-names = "core", "bus"; > + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>, > + <&clkc CLKID_NNA_AXI_CLK>; > + assigned-clock-rates = <800000000>, <800000000>; > resets = <&reset RESET_NNA>; > status = "disabled"; > }; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Mon 06 Nov 2023 at 10:26, Neil Armstrong <neil.armstrong@linaro.org> wrote: > On 06/11/2023 10:22, Tomeu Vizoso wrote: patch title is misleading. It does not target the vim3 only but all g12 and sm1 HWs. It should start with "arm64: dts: amlogic: g12: " instead >> Otherwise they are left at 24MHz and the NPU runs very slowly. >> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> >> Suggested-by: Lucas Stach <l.stach@pengutronix.de> >> --- >> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> index ff68b911b729..9d5eab6595d0 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> @@ -2502,6 +2502,9 @@ npu: npu@ff100000 { >> clocks = <&clkc CLKID_NNA_CORE_CLK>, >> <&clkc CLKID_NNA_AXI_CLK>; >> clock-names = "core", "bus"; >> + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>, >> + <&clkc CLKID_NNA_AXI_CLK>; >> + assigned-clock-rates = <800000000>, <800000000>; >> resets = <&reset RESET_NNA>; >> status = "disabled"; >> }; > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Mon, Nov 6, 2023 at 11:43 AM Jerome Brunet <jbrunet@baylibre.com> wrote: > > > On Mon 06 Nov 2023 at 10:26, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > > On 06/11/2023 10:22, Tomeu Vizoso wrote: > > patch title is misleading. It does not target the vim3 only but all g12 > and sm1 HWs. > > It should start with "arm64: dts: amlogic: g12: " instead Thanks, have fixed and resent. Cheers, Tomeu > >> Otherwise they are left at 24MHz and the NPU runs very slowly. > >> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> > >> Suggested-by: Lucas Stach <l.stach@pengutronix.de> > >> --- > >> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++ > >> 1 file changed, 3 insertions(+) > >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > >> b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > >> index ff68b911b729..9d5eab6595d0 100644 > >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > >> @@ -2502,6 +2502,9 @@ npu: npu@ff100000 { > >> clocks = <&clkc CLKID_NNA_CORE_CLK>, > >> <&clkc CLKID_NNA_AXI_CLK>; > >> clock-names = "core", "bus"; > >> + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>, > >> + <&clkc CLKID_NNA_AXI_CLK>; > >> + assigned-clock-rates = <800000000>, <800000000>; > >> resets = <&reset RESET_NNA>; > >> status = "disabled"; > >> }; > > > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi index ff68b911b729..9d5eab6595d0 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi @@ -2502,6 +2502,9 @@ npu: npu@ff100000 { clocks = <&clkc CLKID_NNA_CORE_CLK>, <&clkc CLKID_NNA_AXI_CLK>; clock-names = "core", "bus"; + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>, + <&clkc CLKID_NNA_AXI_CLK>; + assigned-clock-rates = <800000000>, <800000000>; resets = <&reset RESET_NNA>; status = "disabled"; };