From patchwork Mon Nov 6 06:08:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 161827 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2465944vqu; Sun, 5 Nov 2023 22:08:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEud/BiZxYbJnlvs5NG3kBHPzjrfBcbRDDiIgUfZVNII0OAlho/SsPYeBYkYX+Ubglm1xoi X-Received: by 2002:a17:90b:1bc5:b0:27d:a14c:eba6 with SMTP id oa5-20020a17090b1bc500b0027da14ceba6mr5936986pjb.21.1699250930761; Sun, 05 Nov 2023 22:08:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699250930; cv=none; d=google.com; s=arc-20160816; b=UPxCNL+8U+hPbwr3h54haKkT1YtMefVV/5Ar73evJlMmonx8VvcjGB1RVzfsFppIsT Fq8VaGIsyCTZlcO5SohT8zN0RFpKCA3uwYR83IkwXFcfncgCxZi7Wr/cr/06JN7F9ITS H9aT0iiAZVDq8zUi0ieV7g9+QgJeah4LCYX3GXZNLwAX80VXOJ+SGI6t598RLZv6TV1h BJ4kMo2Vyv6IEMQEXe6gs2TKzaYJ9rwShssFsjo6kllkMzUhn/ZzSueEAUZpdTesFTrZ 1+iNuS0BwBbbPWpoZ1A4hXyhklL7ACODT9sWFf4LMGc7rNL+AMhakIEHOwGgajy1uHML elEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=z2JGSPO0NVhbjd7JgxtJdKY4SQJS8cxpCsIy4GMOcPA=; fh=Iwnp3zs/YFrtIRcpJhz50Mn8z3gKY/8iRxG09Hb3GMk=; b=OGOLVMTg+/IPyhnKYwohhOzUpI8OW8RyDZYyW16iBtnUVSULPiKU4GlRRCK5bQzkQQ lfYAMw74gs1HdOvGsT6SHErrzMXOrUUKkyzoxCfbkXKALuotCtkijAAk9vBbrL46E5qi XMYrbQX3eIrGZhaFiLTYSVNGTX6rmoiG2ZehfOYva+XJkP6cMjR//N8y4TecZv8eJnJx ikb1AYibXqeG2WBNlLNb1WJVcVqT539IBajW/jly15IF2BkzKI/VdwN/ZBH66QsJimhD THh2PNMm/eYE56C4MZaIiI1GTtJ921kLHblEuqsW14j7gdStP1SkEDRqAhVzhCmtZ8kE EYDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id k6-20020a170902c40600b001c0c79b3869si7922120plk.578.2023.11.05.22.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 22:08:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6F13780ADEC8; Sun, 5 Nov 2023 22:08:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbjKFGIf (ORCPT + 35 others); Mon, 6 Nov 2023 01:08:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjKFGId (ORCPT ); Mon, 6 Nov 2023 01:08:33 -0500 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 45D38B6; Sun, 5 Nov 2023 22:08:30 -0800 (PST) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id A1A70602AB5FF; Mon, 6 Nov 2023 14:08:27 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: sergeantsagara@protonmail.com, ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: Su Hui , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] HID: wacom_sys: add error code check in wacom_feature_mapping Date: Mon, 6 Nov 2023 14:08:16 +0800 Message-Id: <20231106060815.104971-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 05 Nov 2023 22:08:48 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780264587923051501 X-GMAIL-MSGID: 1781793744073211411 hid_report_raw_event() can return error code like '-ENOMEM' if failed, so check 'ret' to make sure all things work fine. Signed-off-by: Su Hui Reviewed-by: Rahul Rameshbabu --- v2: - report the returned error (Rahul Rameshbabu) and __func__. drivers/hid/wacom_sys.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 3f704b8072e8..899579c6db9d 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -320,6 +320,9 @@ static void wacom_feature_mapping(struct hid_device *hdev, if (ret == n && features->type == HID_GENERIC) { ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT, data, n, 0); + if (ret) + hid_warn(hdev, "%s: failed to report feature: %pe\n", + __func__, ERR_PTR(ret)); } else if (ret == 2 && features->type != HID_GENERIC) { features->touch_max = data[1]; } else { @@ -381,6 +384,9 @@ static void wacom_feature_mapping(struct hid_device *hdev, if (ret == n) { ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT, data, n, 0); + if (ret) + hid_warn(hdev, "%s: failed to report feature: %pe\n", + __func__, ERR_PTR(ret)); } else { hid_warn(hdev, "%s: could not retrieve sensor offsets\n", __func__);