From patchwork Mon Nov 6 09:57:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 161918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2548374vqu; Mon, 6 Nov 2023 01:58:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdVZaeUVPMehJZ4o1soWn6LEPRT1tOlvY9nwXsn4s3SmtPHRYjN695DDGsZ58uLAexXRGD X-Received: by 2002:a05:6a00:6c9c:b0:6bf:15fb:4b32 with SMTP id jc28-20020a056a006c9c00b006bf15fb4b32mr16865928pfb.8.1699264716127; Mon, 06 Nov 2023 01:58:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699264716; cv=none; d=google.com; s=arc-20160816; b=kV/OS93GECe9CjuUHkEseFQBZrzcsUgJjV3oyvq+WK27YdCvtG7j7yENelOszUsDRt dIXQ/ZG2Cofy5j1FaFEPWeBEqNBvARqbYdJ6JjoyhZB3VNtNqbYxz9hTufMBl86My/3c G+PBvdbaqQvsMfufx0RW6l9XBBHx+2lMH1PbG1msq3n/S0I/Z/HV0/yvmsGtba2H7iNl eRezHHWkhpiWZOh+f1m1+TBrBLpJUfi74jttkQgyEdBxvi9utYrc2GTpSROLlz4SYSu9 vxY5/fOvmDRJshJXCdELguq0hCdkpQutwxSMGx+9LWdyiMlPwlWVbBJoEMh+xpWsnroO mESg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=6/RL/qmmgI5Z+RRmCkzW5O00Or8vhXY7cah1IbO0O9M=; fh=iE1ty8JT+x5jtD9OCG3P+Fi1QtkJfVpi3/0ISVKTLMc=; b=LJ+BoCtZzSkDQazbM56e47bIfPrI20HXfM4eueEDSglMFKSeiqGxFLIhOJafU9sNyQ 2ftuUnERca183YxIP22fe5nRQyo0T9ZzaaALFURnoFea11RM2F5SU58m5Qb/fHvQ6E/U WUz//e9kv6X4RGXiJywNlL0lzMFTq8HEWrm9H4n4Hjn69WzsMrSozgVKZuK+xtzJcMxU o2c31DKfJPnVRskcqxXRy4EqItqeIEU2P+7med54vrzc+BBihHw3NF1xBiSkaGWMt0XT fNJY5zx06abr12gnLyH68sVRT8ns/SYK0UdLe7bl0bjQ3BdEyLTTKaSLH4L66NikgdNw NxcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=rZvpMRrx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id d21-20020a056a00199500b0068895dea43csi7639008pfl.78.2023.11.06.01.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 01:58:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=rZvpMRrx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 30E1D802B403; Mon, 6 Nov 2023 01:58:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbjKFJ63 (ORCPT + 36 others); Mon, 6 Nov 2023 04:58:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjKFJ61 (ORCPT ); Mon, 6 Nov 2023 04:58:27 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1472125; Mon, 6 Nov 2023 01:58:24 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2783C13AC; Mon, 6 Nov 2023 10:58:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699264682; bh=bCGMJiX9pW7HAN0UX6C7RxU6jaO0RofSA0XWj512TVE=; h=From:Date:Subject:To:Cc:From; b=rZvpMRrxXN2Lcg1XI58Cv2YBDSIDVVKX4dkzNmmPowXXYxm/Q9Z3JXrf3YU31yhzd xL9Pm4cRDaYE9qW6TqsHSaZ1iNBu0c74Etc6fTC3hpdiLhOThMC7xBh7BoiixQDkTi owZN8RKTmg3inKDunro6ZPfsbDWR8XVEg4hEm/cs= From: Tomi Valkeinen Date: Mon, 06 Nov 2023 11:57:48 +0200 Subject: [PATCH] arm64: dts: ti: k3-am65-main: Fix DSS irq trigger type MIME-Version: 1.0 Message-Id: <20231106-am65-dss-clk-edge-v1-1-4a959fec0e1e@ideasonboard.com> X-B4-Tracking: v=1; b=H4sIAJu4SGUC/x2MSQqAMAwAvyI5G2iVqvgV8aBNqsGVBkQQ/27xO DAzDyhHYYU2eyDyJSrHnsDmGfh52CdGocRQmKK01lQ4bJVDUkW/LsiUhJrsSFR7E1wDqTsjB7n /Z9e/7wcTZfYbYwAAAA== To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Aradhya Bhatia , Tomi Valkeinen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1461; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=bCGMJiX9pW7HAN0UX6C7RxU6jaO0RofSA0XWj512TVE=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlSLi6cvpFRvR+MBUm93OYcll36SndxspyXYJNP R+7CVq+PoCJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZUi4ugAKCRD6PaqMvJYe 9WNqD/40POYjydCN/gA7/aKulSsuQ2NmyAp0NfjkpCTtedx4Akc2Hg7xwvRDsR3+HXDrV7yGL8d rJELklG9a0qUZpAlJWPtw5aS4E3jH/Bk7Ne4OwW811yS88eIZ7OYe+/XoC33sdka/acyH0QXqy7 HAor04fg7kfOTWiQeJOf2CrgidZQA0yv2/Rf/0fgMxCCx48d8e9v6wk+AVqLFeWzf9WV1Pha/8u AaPBz93osRRiWDhs3vR6YujTmD8YiKraJjmM2S+T1o6UvPdpHGdNNQd94v/yfE2TDwZdfYo/bWr DwoZuk/SuLuUytdUT/azmTjGILiOuWyQD9f6XfMMXPh1QpBZoNPLrBZDCsMNO2FaRTodHzqcApd mL50COwjfi9wOp356omx47I/7OVsK1OhKIHn9h+hQO1Kzp60wtKbYCTTeew/lPGfak6OSDDnLMq DNpwsskk6PcA2xgbauSJucb9oSEBO4vr9zZVfJtoOkvpy5TiWVlLhy9nBU4Y+QDFxEjPBl7TNrX nICw71t2BN7sezRG75hqAZjOWoTZblXWagiGRodjbNmjK/a1lYLzcOLaaYSYg5gExcRypNAzkIm iSmbCUSM+9QAURKpmtSa9t2iSrJuylyG9qYFp1ExmkOdwPBB0JlhPpsFBmARPtHLkyJAr0gnqDz vN0JJxtb3iKzRtw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 06 Nov 2023 01:58:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781808199066626270 X-GMAIL-MSGID: 1781808199066626270 DSS irq trigger type is set to IRQ_TYPE_EDGE_RISING in the DT file, but the TRM says it is level triggered. For some reason triggering on rising edge results in double the amount of expected interrupts, e.g. for normal page flipping test the number of interrupts per second is 2 * fps. It is as if the IRQ triggers on both edges. There are no other side effects to this issue than slightly increased CPU & power consumption due to the extra interrupt. Switching to IRQ_TYPE_LEVEL_HIGH is correct and fixes the issue, so let's do that. Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node") Signed-off-by: Tomi Valkeinen Reviewed-by: Aradhya Bhatia --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa change-id: 20231106-am65-dss-clk-edge-7d1bdd7c0f58 Best regards, diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index bc460033a37a..c98068b6c122 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -1034,7 +1034,7 @@ dss: dss@4a00000 { assigned-clocks = <&k3_clks 67 2>; assigned-clock-parents = <&k3_clks 67 5>; - interrupts = ; + interrupts = ; dma-coherent;